<p>fixeria has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/25602">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">osmo-bts-trx: remove an 'else' branch in _sched_dl_burst()<br><br>When I introduced this branch in change [1], I was under assumption<br>that PDCHs never have an associated 'struct gsm_lchan'.  This is<br>incorrect: the association actually happens during PDCH activation,<br>i.e. when osmo-pcu establishes connection over the PCUIF.<br><br>Enforcing attenuation of 0 dB for other channel types makes no sense.<br><br>[1] I3dcee6e910ccc61c5c63c728db9ea04327e2fc98<br><br>Change-Id: I77a839725f22be1be4a025f579c4c9ccdfb53460<br>---<br>M src/common/scheduler.c<br>1 file changed, 0 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/02/25602/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/common/scheduler.c b/src/common/scheduler.c</span><br><span>index 0826eda..0feb00e 100644</span><br><span>--- a/src/common/scheduler.c</span><br><span>+++ b/src/common/scheduler.c</span><br><span>@@ -1327,8 +1327,6 @@</span><br><span>        /* BS Power reduction (in dB) per logical channel */</span><br><span>         if (l1cs->lchan != NULL)</span><br><span>          br->att = l1cs->lchan->bs_power_ctrl.current;</span><br><span style="color: hsl(0, 100%, 40%);">-  else /* Ensure no attenuation in the absence of lchan (e.g. on PDCH) */</span><br><span style="color: hsl(0, 100%, 40%);">-         br->att = 0;</span><br><span> </span><br><span>  /* encrypt */</span><br><span>        if (br->burst_len && l1cs->dl_encr_algo) {</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bts/+/25602">change 25602</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bts/+/25602"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I77a839725f22be1be4a025f579c4c9ccdfb53460 </div>
<div style="display:none"> Gerrit-Change-Number: 25602 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>