<p>osmith <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/25572">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  daniel: Looks good to me, approved
  dexter: Looks good to me, but someone else must approve

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">sched_lchan_tch_x: use ul_cmr and ul_ft when generating RTP bad frame<br><br>All generated RTP that originates from the BTS relates to uplink. When<br>generating AMR BAD frame RTP packets, we must use ul_cmr/ul_ft and not<br>dl_cmr/dl_ft.<br><br>Change-Id: Ifa009819791cf7df2dd8201f442b0dae06f622a4<br>Related: SYS#5549<br>---<br>M src/osmo-bts-trx/sched_lchan_tchf.c<br>M src/osmo-bts-trx/sched_lchan_tchh.c<br>2 files changed, 4 insertions(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bts-trx/sched_lchan_tchf.c b/src/osmo-bts-trx/sched_lchan_tchf.c</span><br><span>index b3649cd..267ca08 100644</span><br><span>--- a/src/osmo-bts-trx/sched_lchan_tchf.c</span><br><span>+++ b/src/osmo-bts-trx/sched_lchan_tchf.c</span><br><span>@@ -280,8 +280,8 @@</span><br><span>                               break;</span><br><span>                       case GSM48_CMODE_SPEECH_AMR: /* AMR */</span><br><span>                               rc = osmo_amr_rtp_enc(tch_data,</span><br><span style="color: hsl(0, 100%, 40%);">-                                 chan_state->codec[chan_state->dl_cmr],</span><br><span style="color: hsl(0, 100%, 40%);">-                                    chan_state->codec[chan_state->dl_ft],</span><br><span style="color: hsl(120, 100%, 40%);">+                                   chan_state->codec[chan_state->ul_cmr],</span><br><span style="color: hsl(120, 100%, 40%);">+                                  chan_state->codec[chan_state->ul_ft],</span><br><span>                                  AMR_BAD);</span><br><span>                            if (rc < 2) {</span><br><span>                                     LOGL1S(DL1P, LOGL_ERROR, l1t, bi->tn, chan, bi->fn,</span><br><span>diff --git a/src/osmo-bts-trx/sched_lchan_tchh.c b/src/osmo-bts-trx/sched_lchan_tchh.c</span><br><span>index 0692f9d..8bde7d4 100644</span><br><span>--- a/src/osmo-bts-trx/sched_lchan_tchh.c</span><br><span>+++ b/src/osmo-bts-trx/sched_lchan_tchh.c</span><br><span>@@ -311,8 +311,8 @@</span><br><span>                             break;</span><br><span>                       case GSM48_CMODE_SPEECH_AMR: /* AMR */</span><br><span>                               rc = osmo_amr_rtp_enc(tch_data,</span><br><span style="color: hsl(0, 100%, 40%);">-                                 chan_state->codec[chan_state->dl_cmr],</span><br><span style="color: hsl(0, 100%, 40%);">-                                    chan_state->codec[chan_state->dl_ft],</span><br><span style="color: hsl(120, 100%, 40%);">+                                   chan_state->codec[chan_state->ul_cmr],</span><br><span style="color: hsl(120, 100%, 40%);">+                                  chan_state->codec[chan_state->ul_ft],</span><br><span>                                  AMR_BAD);</span><br><span>                            if (rc < 2) {</span><br><span>                                     LOGL1S(DL1P, LOGL_ERROR, l1t, bi->tn, chan, bi->fn,</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bts/+/25572">change 25572</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bts/+/25572"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: 2021q1 </div>
<div style="display:none"> Gerrit-Change-Id: Ifa009819791cf7df2dd8201f442b0dae06f622a4 </div>
<div style="display:none"> Gerrit-Change-Number: 25572 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: osmith <osmith@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: daniel <dwillmann@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: osmith <osmith@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>