<p>pespin <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-pcu/+/25540">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  fixeria: Looks good to me, but someone else must approve
  osmith: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">tbf_ul_ass_fsm.c: Fix missing state transition in FSM description<br><br>As seen operating PCU after BTS restart, lots of following message<br>sequences due to FSM kept in same state (hence scheduler retyring every<br>time):<br>"""<br>DTBF tbf_ul_ass_fsm.c:306 UL_ASS_TBF(DL-TFI_0){SEND_ASS}: Received Event CREATE_RLCMAC_MSG<br>DTBF tbf_ul_ass_fsm.c:95 TBF(TFI=0 TLLI=0xf80bd801 DIR=DL STATE=RELEASING EGPRS) We have a schedule for uplink assignment, but there is no uplink TBF<br>DTBF tbf_ul_ass_fsm.c:97 UL_ASS_TBF(DL-TFI_0){SEND_ASS}: transition to state NONE not permitted!<br>DTBF tbf_ul_ass_fsm.c:306 UL_ASS_TBF(DL-TFI_0){SEND_ASS}: Received Event CREATE_RLCMAC_MSG<br>"""<br><br>Change-Id: I91d74f70a9106ccbf0c137b6e713877f9ea8f59d<br>---<br>M src/tbf_ul_ass_fsm.c<br>1 file changed, 3 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/tbf_ul_ass_fsm.c b/src/tbf_ul_ass_fsm.c</span><br><span>index eab34ee..618e072 100644</span><br><span>--- a/src/tbf_ul_ass_fsm.c</span><br><span>+++ b/src/tbf_ul_ass_fsm.c</span><br><span>@@ -257,7 +257,9 @@</span><br><span>   },</span><br><span>   [TBF_UL_ASS_SEND_ASS] = {</span><br><span>            .in_event_mask = X(TBF_UL_ASS_EV_CREATE_RLCMAC_MSG),</span><br><span style="color: hsl(0, 100%, 40%);">-            .out_state_mask = X(TBF_UL_ASS_WAIT_ACK),</span><br><span style="color: hsl(120, 100%, 40%);">+             .out_state_mask =</span><br><span style="color: hsl(120, 100%, 40%);">+                     X(TBF_UL_ASS_WAIT_ACK) |</span><br><span style="color: hsl(120, 100%, 40%);">+                      X(TBF_UL_ASS_NONE),</span><br><span>          .name = "SEND_ASS",</span><br><span>                .action = st_send_ass,</span><br><span>       },</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-pcu/+/25540">change 25540</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-pcu/+/25540"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-pcu </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I91d74f70a9106ccbf0c137b6e713877f9ea8f59d </div>
<div style="display:none"> Gerrit-Change-Number: 25540 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: osmith <osmith@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>