<p>pespin has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/25544">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">abis: Fix memory leak of bts->osmo_link upon link going down<br><br>Commit below (see "Fixes" section) wrongly erased the code re-introduced<br>in this commit, due to not spotting different between "oml_link" and<br>"osmo_link". This commit is hence a revert of such commit, updated to<br>current code.<br><br>Fixes: c2ba34d9c13d309926c760943a9531fd3b236189<br>Change-Id: Id436116e5cd0bec024b2f9943fbff8d0bdc956ac<br>---<br>M src/common/abis.c<br>1 file changed, 7 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/44/25544/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/common/abis.c b/src/common/abis.c</span><br><span>index 3451b2e..93635c2 100644</span><br><span>--- a/src/common/abis.c</span><br><span>+++ b/src/common/abis.c</span><br><span>@@ -102,6 +102,13 @@</span><br><span>          bts->oml_link = NULL;</span><br><span>     }</span><br><span>    memset(&bts->oml_conn_established_timestamp, 0, sizeof(bts->oml_conn_established_timestamp));</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+     /* Same for IPAC_PROTO_OSMO on the same ipa connection: */</span><br><span style="color: hsl(120, 100%, 40%);">+    if (bts->osmo_link) {</span><br><span style="color: hsl(120, 100%, 40%);">+              e1inp_sign_link_destroy(bts->osmo_link);</span><br><span style="color: hsl(120, 100%, 40%);">+           bts->osmo_link = NULL;</span><br><span style="color: hsl(120, 100%, 40%);">+     }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> }</span><br><span> </span><br><span> static int pick_next_bsc(struct osmo_fsm_inst *fi)</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bts/+/25544">change 25544</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bts/+/25544"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Id436116e5cd0bec024b2f9943fbff8d0bdc956ac </div>
<div style="display:none"> Gerrit-Change-Number: 25544 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>