<p>pespin has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/25525">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">bts-trx: Submit TRX_PROV_EV_CFG_ARFCN for C0 during SetBtsAttr<br><br>In oml_rx_set_bts_attr, arfcn for C0 is assigned from NM_ATT_BCCH_ARFCN.<br>The rest of the TRX get their arfcn from oml_rx_set_radio_attr()<br>NM_ATT_ARFCN_LIST.<br><br>Change-Id: I8aa9652622107fe0a707b2cbcbe8be6c71e19087<br>---<br>M src/osmo-bts-trx/l1_if.c<br>1 file changed, 14 insertions(+), 5 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/25/25525/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bts-trx/l1_if.c b/src/osmo-bts-trx/l1_if.c</span><br><span>index 90adde2..a3282ee 100644</span><br><span>--- a/src/osmo-bts-trx/l1_if.c</span><br><span>+++ b/src/osmo-bts-trx/l1_if.c</span><br><span>@@ -230,13 +230,20 @@</span><br><span> /* set bts attributes */</span><br><span> static uint8_t trx_set_bts(struct gsm_bts *bts, struct tlv_parsed *new_attr)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">-     struct gsm_bts_trx *trx;</span><br><span style="color: hsl(120, 100%, 40%);">+      struct phy_instance *pinst = trx_phy_instance(bts->c0);</span><br><span style="color: hsl(120, 100%, 40%);">+    struct trx_l1h *l1h = pinst->u.osmotrx.hdl;</span><br><span>       uint8_t bsic = bts->bsic;</span><br><span style="color: hsl(120, 100%, 40%);">+  struct gsm_bts_trx *trx;</span><br><span style="color: hsl(120, 100%, 40%);">+      struct phy_link *plink;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+     /* ARFCN for C0 is assigned during Set BTS Attr, see oml.c */</span><br><span style="color: hsl(120, 100%, 40%);">+ osmo_fsm_inst_dispatch(l1h->provision_fi, TRX_PROV_EV_CFG_ARFCN, (void*)(intptr_t)pinst->trx->arfcn);</span><br><span> </span><br><span>   llist_for_each_entry(trx, &bts->trx_list, list) {</span><br><span style="color: hsl(0, 100%, 40%);">-                struct phy_instance *pinst = trx_phy_instance(trx);</span><br><span style="color: hsl(0, 100%, 40%);">-             struct phy_link *plink = pinst->phy_link;</span><br><span style="color: hsl(0, 100%, 40%);">-            struct trx_l1h *l1h = pinst->u.osmotrx.hdl;</span><br><span style="color: hsl(120, 100%, 40%);">+                pinst = trx_phy_instance(trx);</span><br><span style="color: hsl(120, 100%, 40%);">+                l1h = pinst->u.osmotrx.hdl;</span><br><span style="color: hsl(120, 100%, 40%);">+                plink = pinst->phy_link;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>                osmo_fsm_inst_dispatch(l1h->provision_fi, TRX_PROV_EV_CFG_BSIC, (void*)(intptr_t)bsic);</span><br><span>           check_transceiver_availability_trx(l1h, phy_link_state_get(plink) != PHY_LINK_SHUTDOWN);</span><br><span>     }</span><br><span>@@ -252,7 +259,9 @@</span><br><span>      struct phy_link *plink = pinst->phy_link;</span><br><span>         uint16_t arfcn = trx->arfcn;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-     osmo_fsm_inst_dispatch(l1h->provision_fi, TRX_PROV_EV_CFG_ARFCN, (void*)(intptr_t)arfcn);</span><br><span style="color: hsl(120, 100%, 40%);">+  /* ARFCN for C0 is assigned during Set BTS Attr, see oml.c */</span><br><span style="color: hsl(120, 100%, 40%);">+ if (trx != trx->bts->c0)</span><br><span style="color: hsl(120, 100%, 40%);">+                osmo_fsm_inst_dispatch(l1h->provision_fi, TRX_PROV_EV_CFG_ARFCN, (void*)(intptr_t)arfcn);</span><br><span> </span><br><span>     /* Begin to ramp up the power if power reduction is set by OML and TRX</span><br><span>          is already running. Otherwise skip, power ramping will be started</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bts/+/25525">change 25525</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bts/+/25525"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I8aa9652622107fe0a707b2cbcbe8be6c71e19087 </div>
<div style="display:none"> Gerrit-Change-Number: 25525 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>