<p>pespin has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/25530">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">nm_bts_fsm: Make sure PHYs are opened when SW_ACTivating it<br><br>Since recently we support shutting down phys when BTS goes into shutdown<br>mode. Let's make sure they are opened again when we connect again to the<br>BSC.<br><br>Change-Id: Ia1df6f4a1e0e6daeffe7303d518776a04b023930<br>---<br>M src/common/nm_bts_fsm.c<br>1 file changed, 14 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/30/25530/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/common/nm_bts_fsm.c b/src/common/nm_bts_fsm.c</span><br><span>index 54737bf..ac8a74d 100644</span><br><span>--- a/src/common/nm_bts_fsm.c</span><br><span>+++ b/src/common/nm_bts_fsm.c</span><br><span>@@ -65,10 +65,24 @@</span><br><span> static void st_op_disabled_notinstalled(struct osmo_fsm_inst *fi, uint32_t event, void *data)</span><br><span> {</span><br><span>         struct gsm_bts *bts = (struct gsm_bts *)fi->priv;</span><br><span style="color: hsl(120, 100%, 40%);">+  struct gsm_bts_trx *trx;</span><br><span> </span><br><span>         switch (event) {</span><br><span>     case NM_EV_SW_ACT:</span><br><span>           oml_mo_tx_sw_act_rep(&bts->mo);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+              llist_for_each_entry(trx, &bts->trx_list, list) {</span><br><span style="color: hsl(120, 100%, 40%);">+                      /* During startup, phy_links are already opened, but if we are</span><br><span style="color: hsl(120, 100%, 40%);">+                         * re-connecting, phy_link was closed when disconnected from</span><br><span style="color: hsl(120, 100%, 40%);">+                   * previous BSC, so let's re-open it.</span><br><span style="color: hsl(120, 100%, 40%);">+                      */</span><br><span style="color: hsl(120, 100%, 40%);">+                   struct phy_instance *pinst = trx_phy_instance(trx);</span><br><span style="color: hsl(120, 100%, 40%);">+                   struct phy_link *plink = pinst->phy_link;</span><br><span style="color: hsl(120, 100%, 40%);">+                  if (phy_link_state_get(plink) == PHY_LINK_SHUTDOWN) {</span><br><span style="color: hsl(120, 100%, 40%);">+                         bts_model_phy_link_open(plink);</span><br><span style="color: hsl(120, 100%, 40%);">+                       }</span><br><span style="color: hsl(120, 100%, 40%);">+             }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>          nm_bts_fsm_state_chg(fi, NM_BTS_ST_OP_DISABLED_OFFLINE);</span><br><span>             return;</span><br><span>      default:</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bts/+/25530">change 25530</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bts/+/25530"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ia1df6f4a1e0e6daeffe7303d518776a04b023930 </div>
<div style="display:none"> Gerrit-Change-Number: 25530 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>