<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/25497">View Change</a></p><div style="white-space:pre-wrap">Approvals:
laforge: Looks good to me, approved; Verified
fixeria: Looks good to me, but someone else must approve
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">base64: Migrate over to osmocom<br><br>This containts the osmocom changes to the mbedtls base64 code<br>merged in the previous commit.<br><br>Change-Id: I82c1bf5f827c8def370dbcb80b146e9e4184c4a3<br>---<br>M include/Makefile.am<br>M include/osmocom/core/base64.h<br>M src/Makefile.am<br>M src/base64.c<br>M tests/Makefile.am<br>A tests/base64/base64_test.c<br>A tests/base64/base64_test.ok<br>M tests/testsuite.at<br>8 files changed, 85 insertions(+), 107 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/include/Makefile.am b/include/Makefile.am</span><br><span>index e25ed48..7df651a 100644</span><br><span>--- a/include/Makefile.am</span><br><span>+++ b/include/Makefile.am</span><br><span>@@ -6,6 +6,7 @@</span><br><span> osmocom/codec/gsm610_bits.h \</span><br><span> osmocom/core/application.h \</span><br><span> osmocom/core/backtrace.h \</span><br><span style="color: hsl(120, 100%, 40%);">+ osmocom/core/base64.h \</span><br><span> osmocom/core/bit16gen.h \</span><br><span> osmocom/core/bit32gen.h \</span><br><span> osmocom/core/bit64gen.h \</span><br><span>diff --git a/include/osmocom/core/base64.h b/include/osmocom/core/base64.h</span><br><span>index 0f7233d..f73db0d 100644</span><br><span>--- a/include/osmocom/core/base64.h</span><br><span>+++ b/include/osmocom/core/base64.h</span><br><span>@@ -21,14 +21,10 @@</span><br><span> * with this program; if not, write to the Free Software Foundation, Inc.,</span><br><span> * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.</span><br><span> */</span><br><span style="color: hsl(0, 100%, 40%);">-#ifndef MBEDTLS_BASE64_H</span><br><span style="color: hsl(0, 100%, 40%);">-#define MBEDTLS_BASE64_H</span><br><span style="color: hsl(120, 100%, 40%);">+#pragma once</span><br><span> </span><br><span> #include <stddef.h></span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-#define MBEDTLS_ERR_BASE64_BUFFER_TOO_SMALL -0x002A /**< Output buffer too small. */</span><br><span style="color: hsl(0, 100%, 40%);">-#define MBEDTLS_ERR_BASE64_INVALID_CHARACTER -0x002C /**< Invalid character in input. */</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> #ifdef __cplusplus</span><br><span> extern "C" {</span><br><span> #endif</span><br><span>@@ -49,7 +45,7 @@</span><br><span> * \note Call this function with dlen = 0 to obtain the</span><br><span> * required buffer size in *olen</span><br><span> */</span><br><span style="color: hsl(0, 100%, 40%);">-int mbedtls_base64_encode( unsigned char *dst, size_t dlen, size_t *olen,</span><br><span style="color: hsl(120, 100%, 40%);">+int osmo_base64_encode( unsigned char *dst, size_t dlen, size_t *olen,</span><br><span> const unsigned char *src, size_t slen );</span><br><span> </span><br><span> /**</span><br><span>@@ -69,18 +65,9 @@</span><br><span> * \note Call this function with *dst = NULL or dlen = 0 to obtain</span><br><span> * the required buffer size in *olen</span><br><span> */</span><br><span style="color: hsl(0, 100%, 40%);">-int mbedtls_base64_decode( unsigned char *dst, size_t dlen, size_t *olen,</span><br><span style="color: hsl(120, 100%, 40%);">+int osmo_base64_decode( unsigned char *dst, size_t dlen, size_t *olen,</span><br><span> const unsigned char *src, size_t slen );</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-/**</span><br><span style="color: hsl(0, 100%, 40%);">- * \brief Checkup routine</span><br><span style="color: hsl(0, 100%, 40%);">- *</span><br><span style="color: hsl(0, 100%, 40%);">- * \return 0 if successful, or 1 if the test failed</span><br><span style="color: hsl(0, 100%, 40%);">- */</span><br><span style="color: hsl(0, 100%, 40%);">-int mbedtls_base64_self_test( int verbose );</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> #ifdef __cplusplus</span><br><span> }</span><br><span> #endif</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-#endif /* base64.h */</span><br><span>diff --git a/src/Makefile.am b/src/Makefile.am</span><br><span>index 2f18d09..3c589e6 100644</span><br><span>--- a/src/Makefile.am</span><br><span>+++ b/src/Makefile.am</span><br><span>@@ -31,6 +31,7 @@</span><br><span> exec.c \</span><br><span> it_q.c \</span><br><span> probes.d \</span><br><span style="color: hsl(120, 100%, 40%);">+ base64.c \</span><br><span> $(NULL)</span><br><span> </span><br><span> if HAVE_SSSE3</span><br><span>diff --git a/src/base64.c b/src/base64.c</span><br><span>index 11cb30b..dbc908b 100644</span><br><span>--- a/src/base64.c</span><br><span>+++ b/src/base64.c</span><br><span>@@ -20,27 +20,11 @@</span><br><span> * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.</span><br><span> */</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-#if !defined(MBEDTLS_CONFIG_FILE)</span><br><span style="color: hsl(0, 100%, 40%);">-#include "mbedtls/config.h"</span><br><span style="color: hsl(0, 100%, 40%);">-#else</span><br><span style="color: hsl(0, 100%, 40%);">-#include MBEDTLS_CONFIG_FILE</span><br><span style="color: hsl(0, 100%, 40%);">-#endif</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-#if defined(MBEDTLS_BASE64_C)</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-#include "mbedtls/base64.h"</span><br><span style="color: hsl(120, 100%, 40%);">+#include <osmocom/core/base64.h></span><br><span> </span><br><span> #include <stdint.h></span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-#if defined(MBEDTLS_SELF_TEST)</span><br><span style="color: hsl(0, 100%, 40%);">-#include <string.h></span><br><span style="color: hsl(0, 100%, 40%);">-#if defined(MBEDTLS_PLATFORM_C)</span><br><span style="color: hsl(0, 100%, 40%);">-#include "mbedtls/platform.h"</span><br><span style="color: hsl(0, 100%, 40%);">-#else</span><br><span> #include <stdio.h></span><br><span style="color: hsl(0, 100%, 40%);">-#define mbedtls_printf printf</span><br><span style="color: hsl(0, 100%, 40%);">-#endif /* MBEDTLS_PLATFORM_C */</span><br><span style="color: hsl(0, 100%, 40%);">-#endif /* MBEDTLS_SELF_TEST */</span><br><span style="color: hsl(120, 100%, 40%);">+#include <errno.h></span><br><span> </span><br><span> static const unsigned char base64_enc_map[64] =</span><br><span> {</span><br><span>@@ -73,7 +57,7 @@</span><br><span> /*</span><br><span> * Encode a buffer into base64 format</span><br><span> */</span><br><span style="color: hsl(0, 100%, 40%);">-int mbedtls_base64_encode( unsigned char *dst, size_t dlen, size_t *olen,</span><br><span style="color: hsl(120, 100%, 40%);">+int osmo_base64_encode( unsigned char *dst, size_t dlen, size_t *olen,</span><br><span> const unsigned char *src, size_t slen )</span><br><span> {</span><br><span> size_t i, n;</span><br><span>@@ -98,7 +82,7 @@</span><br><span> if( dlen < n + 1 )</span><br><span> {</span><br><span> *olen = n + 1;</span><br><span style="color: hsl(0, 100%, 40%);">- return( MBEDTLS_ERR_BASE64_BUFFER_TOO_SMALL );</span><br><span style="color: hsl(120, 100%, 40%);">+ return( -ENOBUFS );</span><br><span> }</span><br><span> </span><br><span> n = ( slen / 3 ) * 3;</span><br><span>@@ -139,7 +123,7 @@</span><br><span> /*</span><br><span> * Decode a base64-formatted buffer</span><br><span> */</span><br><span style="color: hsl(0, 100%, 40%);">-int mbedtls_base64_decode( unsigned char *dst, size_t dlen, size_t *olen,</span><br><span style="color: hsl(120, 100%, 40%);">+int osmo_base64_decode( unsigned char *dst, size_t dlen, size_t *olen,</span><br><span> const unsigned char *src, size_t slen )</span><br><span> {</span><br><span> size_t i, n;</span><br><span>@@ -170,16 +154,16 @@</span><br><span> </span><br><span> /* Space inside a line is an error */</span><br><span> if( x != 0 )</span><br><span style="color: hsl(0, 100%, 40%);">- return( MBEDTLS_ERR_BASE64_INVALID_CHARACTER );</span><br><span style="color: hsl(120, 100%, 40%);">+ return( -EINVAL );</span><br><span> </span><br><span> if( src[i] == '=' && ++j > 2 )</span><br><span style="color: hsl(0, 100%, 40%);">- return( MBEDTLS_ERR_BASE64_INVALID_CHARACTER );</span><br><span style="color: hsl(120, 100%, 40%);">+ return( -EINVAL );</span><br><span> </span><br><span> if( src[i] > 127 || base64_dec_map[src[i]] == 127 )</span><br><span style="color: hsl(0, 100%, 40%);">- return( MBEDTLS_ERR_BASE64_INVALID_CHARACTER );</span><br><span style="color: hsl(120, 100%, 40%);">+ return( -EINVAL );</span><br><span> </span><br><span> if( base64_dec_map[src[i]] < 64 && j != 0 )</span><br><span style="color: hsl(0, 100%, 40%);">- return( MBEDTLS_ERR_BASE64_INVALID_CHARACTER );</span><br><span style="color: hsl(120, 100%, 40%);">+ return( -EINVAL );</span><br><span> </span><br><span> n++;</span><br><span> }</span><br><span>@@ -193,7 +177,7 @@</span><br><span> if( dst == NULL || dlen < n )</span><br><span> {</span><br><span> *olen = n;</span><br><span style="color: hsl(0, 100%, 40%);">- return( MBEDTLS_ERR_BASE64_BUFFER_TOO_SMALL );</span><br><span style="color: hsl(120, 100%, 40%);">+ return( -ENOBUFS );</span><br><span> }</span><br><span> </span><br><span> for( j = 3, n = x = 0, p = dst; i > 0; i--, src++ )</span><br><span>@@ -217,68 +201,3 @@</span><br><span> </span><br><span> return( 0 );</span><br><span> }</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-#if defined(MBEDTLS_SELF_TEST)</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-static const unsigned char base64_test_dec[64] =</span><br><span style="color: hsl(0, 100%, 40%);">-{</span><br><span style="color: hsl(0, 100%, 40%);">- 0x24, 0x48, 0x6E, 0x56, 0x87, 0x62, 0x5A, 0xBD,</span><br><span style="color: hsl(0, 100%, 40%);">- 0xBF, 0x17, 0xD9, 0xA2, 0xC4, 0x17, 0x1A, 0x01,</span><br><span style="color: hsl(0, 100%, 40%);">- 0x94, 0xED, 0x8F, 0x1E, 0x11, 0xB3, 0xD7, 0x09,</span><br><span style="color: hsl(0, 100%, 40%);">- 0x0C, 0xB6, 0xE9, 0x10, 0x6F, 0x22, 0xEE, 0x13,</span><br><span style="color: hsl(0, 100%, 40%);">- 0xCA, 0xB3, 0x07, 0x05, 0x76, 0xC9, 0xFA, 0x31,</span><br><span style="color: hsl(0, 100%, 40%);">- 0x6C, 0x08, 0x34, 0xFF, 0x8D, 0xC2, 0x6C, 0x38,</span><br><span style="color: hsl(0, 100%, 40%);">- 0x00, 0x43, 0xE9, 0x54, 0x97, 0xAF, 0x50, 0x4B,</span><br><span style="color: hsl(0, 100%, 40%);">- 0xD1, 0x41, 0xBA, 0x95, 0x31, 0x5A, 0x0B, 0x97</span><br><span style="color: hsl(0, 100%, 40%);">-};</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-static const unsigned char base64_test_enc[] =</span><br><span style="color: hsl(0, 100%, 40%);">- "JEhuVodiWr2/F9mixBcaAZTtjx4Rs9cJDLbpEG8i7hPK"</span><br><span style="color: hsl(0, 100%, 40%);">- "swcFdsn6MWwINP+Nwmw4AEPpVJevUEvRQbqVMVoLlw==";</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-/*</span><br><span style="color: hsl(0, 100%, 40%);">- * Checkup routine</span><br><span style="color: hsl(0, 100%, 40%);">- */</span><br><span style="color: hsl(0, 100%, 40%);">-int mbedtls_base64_self_test( int verbose )</span><br><span style="color: hsl(0, 100%, 40%);">-{</span><br><span style="color: hsl(0, 100%, 40%);">- size_t len;</span><br><span style="color: hsl(0, 100%, 40%);">- const unsigned char *src;</span><br><span style="color: hsl(0, 100%, 40%);">- unsigned char buffer[128];</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- if( verbose != 0 )</span><br><span style="color: hsl(0, 100%, 40%);">- mbedtls_printf( " Base64 encoding test: " );</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- src = base64_test_dec;</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- if( mbedtls_base64_encode( buffer, sizeof( buffer ), &len, src, 64 ) != 0 ||</span><br><span style="color: hsl(0, 100%, 40%);">- memcmp( base64_test_enc, buffer, 88 ) != 0 )</span><br><span style="color: hsl(0, 100%, 40%);">- {</span><br><span style="color: hsl(0, 100%, 40%);">- if( verbose != 0 )</span><br><span style="color: hsl(0, 100%, 40%);">- mbedtls_printf( "failed\n" );</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- return( 1 );</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- if( verbose != 0 )</span><br><span style="color: hsl(0, 100%, 40%);">- mbedtls_printf( "passed\n Base64 decoding test: " );</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- src = base64_test_enc;</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- if( mbedtls_base64_decode( buffer, sizeof( buffer ), &len, src, 88 ) != 0 ||</span><br><span style="color: hsl(0, 100%, 40%);">- memcmp( base64_test_dec, buffer, 64 ) != 0 )</span><br><span style="color: hsl(0, 100%, 40%);">- {</span><br><span style="color: hsl(0, 100%, 40%);">- if( verbose != 0 )</span><br><span style="color: hsl(0, 100%, 40%);">- mbedtls_printf( "failed\n" );</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- return( 1 );</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- if( verbose != 0 )</span><br><span style="color: hsl(0, 100%, 40%);">- mbedtls_printf( "passed\n\n" );</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- return( 0 );</span><br><span style="color: hsl(0, 100%, 40%);">-}</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-#endif /* MBEDTLS_SELF_TEST */</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-#endif /* MBEDTLS_BASE64_C */</span><br><span>diff --git a/tests/Makefile.am b/tests/Makefile.am</span><br><span>index 5c6f30c..22591fb 100644</span><br><span>--- a/tests/Makefile.am</span><br><span>+++ b/tests/Makefile.am</span><br><span>@@ -43,6 +43,7 @@</span><br><span> bssmap_le/bssmap_le_test \</span><br><span> it_q/it_q_test \</span><br><span> gsm48/rest_octets_test \</span><br><span style="color: hsl(120, 100%, 40%);">+ base64/base64_test \</span><br><span> $(NULL)</span><br><span> </span><br><span> if ENABLE_MSGFILE</span><br><span>@@ -79,6 +80,8 @@</span><br><span> check_PROGRAMS += gb/bssgp_fc_test gb/gprs_bssgp_test gb/gprs_bssgp_rim_test gb/gprs_ns_test gb/gprs_ns2_test fr/fr_test</span><br><span> endif</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+base64_base64_test_SOURCES = base64/base64_test.c</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> utils_utils_test_SOURCES = utils/utils_test.c</span><br><span> utils_utils_test_LDADD = $(LDADD) $(top_builddir)/src/gsm/libosmogsm.la</span><br><span> </span><br><span>@@ -405,6 +408,7 @@</span><br><span> bssmap_le/bssmap_le_test.ok \</span><br><span> it_q/it_q_test.ok \</span><br><span> gsm48/rest_octets_test.ok \</span><br><span style="color: hsl(120, 100%, 40%);">+ base64/base64_test.ok \</span><br><span> $(NULL)</span><br><span> </span><br><span> if ENABLE_LIBSCTP</span><br><span>diff --git a/tests/base64/base64_test.c b/tests/base64/base64_test.c</span><br><span>new file mode 100644</span><br><span>index 0000000..e85f649</span><br><span>--- /dev/null</span><br><span>+++ b/tests/base64/base64_test.c</span><br><span>@@ -0,0 +1,57 @@</span><br><span style="color: hsl(120, 100%, 40%);">+#include <osmocom/core/base64.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <stdio.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <string.h></span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+static const unsigned char base64_test_dec[64] =</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+ 0x24, 0x48, 0x6E, 0x56, 0x87, 0x62, 0x5A, 0xBD,</span><br><span style="color: hsl(120, 100%, 40%);">+ 0xBF, 0x17, 0xD9, 0xA2, 0xC4, 0x17, 0x1A, 0x01,</span><br><span style="color: hsl(120, 100%, 40%);">+ 0x94, 0xED, 0x8F, 0x1E, 0x11, 0xB3, 0xD7, 0x09,</span><br><span style="color: hsl(120, 100%, 40%);">+ 0x0C, 0xB6, 0xE9, 0x10, 0x6F, 0x22, 0xEE, 0x13,</span><br><span style="color: hsl(120, 100%, 40%);">+ 0xCA, 0xB3, 0x07, 0x05, 0x76, 0xC9, 0xFA, 0x31,</span><br><span style="color: hsl(120, 100%, 40%);">+ 0x6C, 0x08, 0x34, 0xFF, 0x8D, 0xC2, 0x6C, 0x38,</span><br><span style="color: hsl(120, 100%, 40%);">+ 0x00, 0x43, 0xE9, 0x54, 0x97, 0xAF, 0x50, 0x4B,</span><br><span style="color: hsl(120, 100%, 40%);">+ 0xD1, 0x41, 0xBA, 0x95, 0x31, 0x5A, 0x0B, 0x97</span><br><span style="color: hsl(120, 100%, 40%);">+};</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+static const unsigned char base64_test_enc[] =</span><br><span style="color: hsl(120, 100%, 40%);">+ "JEhuVodiWr2/F9mixBcaAZTtjx4Rs9cJDLbpEG8i7hPK"</span><br><span style="color: hsl(120, 100%, 40%);">+ "swcFdsn6MWwINP+Nwmw4AEPpVJevUEvRQbqVMVoLlw==";</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+/*</span><br><span style="color: hsl(120, 100%, 40%);">+ * Checkup routine</span><br><span style="color: hsl(120, 100%, 40%);">+ */</span><br><span style="color: hsl(120, 100%, 40%);">+int main(int argc, char **argv)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+ size_t len;</span><br><span style="color: hsl(120, 100%, 40%);">+ const unsigned char *src;</span><br><span style="color: hsl(120, 100%, 40%);">+ unsigned char buffer[128];</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ printf( " Base64 encoding test: " );</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ src = base64_test_dec;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ if( osmo_base64_encode( buffer, sizeof( buffer ), &len, src, 64 ) != 0 ||</span><br><span style="color: hsl(120, 100%, 40%);">+ memcmp( base64_test_enc, buffer, 88 ) != 0 )</span><br><span style="color: hsl(120, 100%, 40%);">+ {</span><br><span style="color: hsl(120, 100%, 40%);">+ printf( "failed\n" );</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ return( 1 );</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ printf( "passed\n Base64 decoding test: " );</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ src = base64_test_enc;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ if( osmo_base64_decode( buffer, sizeof( buffer ), &len, src, 88 ) != 0 ||</span><br><span style="color: hsl(120, 100%, 40%);">+ memcmp( base64_test_dec, buffer, 64 ) != 0 )</span><br><span style="color: hsl(120, 100%, 40%);">+ {</span><br><span style="color: hsl(120, 100%, 40%);">+ printf( "failed\n" );</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ return( 1 );</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ printf( "passed\n\n" );</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ return( 0 );</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span>diff --git a/tests/base64/base64_test.ok b/tests/base64/base64_test.ok</span><br><span>new file mode 100644</span><br><span>index 0000000..ff187d9</span><br><span>--- /dev/null</span><br><span>+++ b/tests/base64/base64_test.ok</span><br><span>@@ -0,0 +1,3 @@</span><br><span style="color: hsl(120, 100%, 40%);">+ Base64 encoding test: passed</span><br><span style="color: hsl(120, 100%, 40%);">+ Base64 decoding test: passed</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>diff --git a/tests/testsuite.at b/tests/testsuite.at</span><br><span>index cb84229..6ac5970 100644</span><br><span>--- a/tests/testsuite.at</span><br><span>+++ b/tests/testsuite.at</span><br><span>@@ -446,3 +446,9 @@</span><br><span> cat $abs_srcdir/it_q/it_q_test.ok > expout</span><br><span> AT_CHECK([$abs_top_builddir/tests/it_q/it_q_test], [0], [expout], [ignore])</span><br><span> AT_CLEANUP</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+AT_SETUP([base64])</span><br><span style="color: hsl(120, 100%, 40%);">+AT_KEYWORDS([base64])</span><br><span style="color: hsl(120, 100%, 40%);">+cat $abs_srcdir/base64/base64_test.ok > expout</span><br><span style="color: hsl(120, 100%, 40%);">+AT_CHECK([$abs_top_builddir/tests/base64/base64_test], [0], [expout], [ignore])</span><br><span style="color: hsl(120, 100%, 40%);">+AT_CLEANUP</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/25497">change 25497</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/25497"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I82c1bf5f827c8def370dbcb80b146e9e4184c4a3 </div>
<div style="display:none"> Gerrit-Change-Number: 25497 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>