<p>neels <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/25462">View Change</a></p><div style="white-space:pre-wrap">Approvals:
neels: Looks good to me, approved
fixeria: Looks good to me, but someone else must approve
pespin: Looks good to me, but someone else must approve
Jenkins Builder: Verified
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">stats_test: assert counter and stat item val counts separately<br><br>Instead of just a send_count, keep one such count for the counter<br>updates, and a separate one for the stat item updates.<br>Print those numbers in the test output.<br><br>An upcoming patch will tweak stat_item reporting so that only an<br>actually changed value results in sending a new stat value. This patch<br>allows illustrating that change clearly.<br><br>Related: SYS#5542<br>Change-Id: I2da003ee6ec15f1c3959efe69e01b4ee24af82bb<br>---<br>M tests/stats/stats_test.c<br>M tests/stats/stats_test.err<br>2 files changed, 51 insertions(+), 57 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/tests/stats/stats_test.c b/tests/stats/stats_test.c</span><br><span>index 2f2c6ec..9489e60 100644</span><br><span>--- a/tests/stats/stats_test.c</span><br><span>+++ b/tests/stats/stats_test.c</span><br><span>@@ -246,7 +246,8 @@</span><br><span> </span><br><span> /* define a special stats reporter for testing */</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-static int send_count;</span><br><span style="color: hsl(120, 100%, 40%);">+static int sent_counter_vals;</span><br><span style="color: hsl(120, 100%, 40%);">+static int sent_stat_item_vals;</span><br><span> </span><br><span> enum {</span><br><span> OSMO_STATS_REPORTER_TEST = OSMO_STATS_REPORTER_LOG + 1,</span><br><span>@@ -265,7 +266,7 @@</span><br><span> group_name, ctrg ? ctrg->idx : 0,</span><br><span> desc->name, (long long)value, (long long)delta);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- send_count += 1;</span><br><span style="color: hsl(120, 100%, 40%);">+ sent_counter_vals++;</span><br><span> return 0;</span><br><span> }</span><br><span> </span><br><span>@@ -279,7 +280,7 @@</span><br><span> statg->desc->group_name_prefix, statg->idx,</span><br><span> desc->name, value, desc->unit ? desc->unit : "");</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- send_count += 1;</span><br><span style="color: hsl(120, 100%, 40%);">+ sent_stat_item_vals++;</span><br><span> return 0;</span><br><span> }</span><br><span> </span><br><span>@@ -310,6 +311,17 @@</span><br><span> return srep;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+static void _do_report(int expect_counter_vals, int expect_stat_item_vals, int line)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+ sent_counter_vals = 0;</span><br><span style="color: hsl(120, 100%, 40%);">+ sent_stat_item_vals = 0;</span><br><span style="color: hsl(120, 100%, 40%);">+ osmo_stats_report();</span><br><span style="color: hsl(120, 100%, 40%);">+ fprintf(stderr, "reported: %d counter vals, %d stat item vals\n", sent_counter_vals, sent_stat_item_vals);</span><br><span style="color: hsl(120, 100%, 40%);">+ OSMO_ASSERT(sent_counter_vals == expect_counter_vals);</span><br><span style="color: hsl(120, 100%, 40%);">+ OSMO_ASSERT(sent_stat_item_vals == expect_stat_item_vals);</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+#define do_report(A, B) _do_report(A, B, __LINE__)</span><br><span> </span><br><span> static void test_reporting()</span><br><span> {</span><br><span>@@ -363,36 +375,28 @@</span><br><span> OSMO_ASSERT(rc >= 0);</span><br><span> </span><br><span> fprintf(stderr, "report (initial):\n");</span><br><span style="color: hsl(0, 100%, 40%);">- send_count = 0;</span><br><span style="color: hsl(0, 100%, 40%);">- osmo_stats_report();</span><br><span style="color: hsl(0, 100%, 40%);">- OSMO_ASSERT(send_count == 20);</span><br><span style="color: hsl(120, 100%, 40%);">+ do_report(12, 8);</span><br><span> </span><br><span> fprintf(stderr, "report (srep1 global):\n");</span><br><span> /* force single flush */</span><br><span> osmo_stats_reporter_set_max_class(srep1, OSMO_STATS_CLASS_GLOBAL);</span><br><span> srep1->force_single_flush = 1;</span><br><span> srep2->force_single_flush = 1;</span><br><span style="color: hsl(0, 100%, 40%);">- send_count = 0;</span><br><span style="color: hsl(0, 100%, 40%);">- osmo_stats_report();</span><br><span style="color: hsl(0, 100%, 40%);">- OSMO_ASSERT(send_count == 10);</span><br><span style="color: hsl(120, 100%, 40%);">+ do_report(6, 4);</span><br><span> </span><br><span> fprintf(stderr, "report (srep1 peer):\n");</span><br><span> /* force single flush */</span><br><span> osmo_stats_reporter_set_max_class(srep1, OSMO_STATS_CLASS_PEER);</span><br><span> srep1->force_single_flush = 1;</span><br><span> srep2->force_single_flush = 1;</span><br><span style="color: hsl(0, 100%, 40%);">- send_count = 0;</span><br><span style="color: hsl(0, 100%, 40%);">- osmo_stats_report();</span><br><span style="color: hsl(0, 100%, 40%);">- OSMO_ASSERT(send_count == 14);</span><br><span style="color: hsl(120, 100%, 40%);">+ do_report(6, 8);</span><br><span> </span><br><span> fprintf(stderr, "report (srep1 subscriber):\n");</span><br><span> /* force single flush */</span><br><span> osmo_stats_reporter_set_max_class(srep1, OSMO_STATS_CLASS_SUBSCRIBER);</span><br><span> srep1->force_single_flush = 1;</span><br><span> srep2->force_single_flush = 1;</span><br><span style="color: hsl(0, 100%, 40%);">- send_count = 0;</span><br><span style="color: hsl(0, 100%, 40%);">- osmo_stats_report();</span><br><span style="color: hsl(0, 100%, 40%);">- OSMO_ASSERT(send_count == 20);</span><br><span style="color: hsl(120, 100%, 40%);">+ do_report(12, 8);</span><br><span> </span><br><span> fprintf(stderr, "report (srep2 disabled):\n");</span><br><span> /* force single flush */</span><br><span>@@ -400,57 +404,39 @@</span><br><span> srep2->force_single_flush = 1;</span><br><span> rc = osmo_stats_reporter_disable(srep2);</span><br><span> OSMO_ASSERT(rc >= 0);</span><br><span style="color: hsl(0, 100%, 40%);">- send_count = 0;</span><br><span style="color: hsl(0, 100%, 40%);">- osmo_stats_report();</span><br><span style="color: hsl(0, 100%, 40%);">- OSMO_ASSERT(send_count == 10);</span><br><span style="color: hsl(120, 100%, 40%);">+ do_report(6, 4);</span><br><span> </span><br><span> fprintf(stderr, "report (srep2 enabled, no flush forced):\n");</span><br><span> rc = osmo_stats_reporter_enable(srep2);</span><br><span> OSMO_ASSERT(rc >= 0);</span><br><span style="color: hsl(0, 100%, 40%);">- send_count = 0;</span><br><span style="color: hsl(0, 100%, 40%);">- osmo_stats_report();</span><br><span style="color: hsl(0, 100%, 40%);">- OSMO_ASSERT(send_count == 10);</span><br><span style="color: hsl(120, 100%, 40%);">+ do_report(6, 4);</span><br><span> </span><br><span> fprintf(stderr, "report (should be empty):\n");</span><br><span style="color: hsl(0, 100%, 40%);">- send_count = 0;</span><br><span style="color: hsl(0, 100%, 40%);">- osmo_stats_report();</span><br><span style="color: hsl(0, 100%, 40%);">- OSMO_ASSERT(send_count == 0);</span><br><span style="color: hsl(120, 100%, 40%);">+ do_report(0, 0);</span><br><span> </span><br><span> fprintf(stderr, "report (group 1, counter 1 update):\n");</span><br><span> rate_ctr_inc(rate_ctr_group_get_ctr(ctrg1, TEST_A_CTR));</span><br><span style="color: hsl(0, 100%, 40%);">- send_count = 0;</span><br><span style="color: hsl(0, 100%, 40%);">- osmo_stats_report();</span><br><span style="color: hsl(0, 100%, 40%);">- OSMO_ASSERT(send_count == 2);</span><br><span style="color: hsl(120, 100%, 40%);">+ do_report(2, 0);</span><br><span> </span><br><span> fprintf(stderr, "report (group 1, item 1 update):\n");</span><br><span> osmo_stat_item_set(osmo_stat_item_group_get_item(statg1, TEST_A_ITEM), 10);</span><br><span style="color: hsl(0, 100%, 40%);">- send_count = 0;</span><br><span style="color: hsl(0, 100%, 40%);">- osmo_stats_report();</span><br><span style="color: hsl(0, 100%, 40%);">- OSMO_ASSERT(send_count == 2);</span><br><span style="color: hsl(120, 100%, 40%);">+ do_report(0, 2);</span><br><span> </span><br><span> fprintf(stderr, "report (group 1, item 1 update twice):\n");</span><br><span> osmo_stat_item_set(osmo_stat_item_group_get_item(statg1, TEST_A_ITEM), 10);</span><br><span> osmo_stat_item_set(osmo_stat_item_group_get_item(statg1, TEST_A_ITEM), 10);</span><br><span style="color: hsl(0, 100%, 40%);">- send_count = 0;</span><br><span style="color: hsl(0, 100%, 40%);">- osmo_stats_report();</span><br><span style="color: hsl(0, 100%, 40%);">- OSMO_ASSERT(send_count == 2);</span><br><span style="color: hsl(120, 100%, 40%);">+ do_report(0, 2);</span><br><span> </span><br><span> fprintf(stderr, "report (group 1, item 1 update twice, check max):\n");</span><br><span> osmo_stat_item_set(osmo_stat_item_group_get_item(statg1, TEST_A_ITEM), 20);</span><br><span> osmo_stat_item_set(osmo_stat_item_group_get_item(statg1, TEST_A_ITEM), 10);</span><br><span style="color: hsl(0, 100%, 40%);">- send_count = 0;</span><br><span style="color: hsl(0, 100%, 40%);">- osmo_stats_report();</span><br><span style="color: hsl(0, 100%, 40%);">- OSMO_ASSERT(send_count == 2);</span><br><span style="color: hsl(120, 100%, 40%);">+ do_report(0, 2);</span><br><span> </span><br><span> fprintf(stderr, "report (group 1, item 1 no update, send last item (!= last max), OS#5215):\n");</span><br><span style="color: hsl(0, 100%, 40%);">- send_count = 0;</span><br><span style="color: hsl(0, 100%, 40%);">- osmo_stats_report();</span><br><span style="color: hsl(0, 100%, 40%);">- OSMO_ASSERT(send_count == 2);</span><br><span style="color: hsl(120, 100%, 40%);">+ do_report(0, 2);</span><br><span> </span><br><span> fprintf(stderr, "report (group 1, item 1 no update, nothing to send):\n");</span><br><span style="color: hsl(0, 100%, 40%);">- send_count = 0;</span><br><span style="color: hsl(0, 100%, 40%);">- osmo_stats_report();</span><br><span style="color: hsl(0, 100%, 40%);">- OSMO_ASSERT(send_count == 0);</span><br><span style="color: hsl(120, 100%, 40%);">+ do_report(0, 0);</span><br><span> </span><br><span> fprintf(stderr, "report (remove statg1, ctrg1):\n");</span><br><span> /* force single flush */</span><br><span>@@ -458,40 +444,30 @@</span><br><span> srep2->force_single_flush = 1;</span><br><span> osmo_stat_item_group_free(statg1);</span><br><span> rate_ctr_group_free(ctrg1);</span><br><span style="color: hsl(0, 100%, 40%);">- send_count = 0;</span><br><span style="color: hsl(0, 100%, 40%);">- osmo_stats_report();</span><br><span style="color: hsl(0, 100%, 40%);">- OSMO_ASSERT(send_count == 12);</span><br><span style="color: hsl(120, 100%, 40%);">+ do_report(8, 4);</span><br><span> </span><br><span> fprintf(stderr, "report (remove srep1):\n");</span><br><span> /* force single flush */</span><br><span> srep1->force_single_flush = 1;</span><br><span> srep2->force_single_flush = 1;</span><br><span> osmo_stats_reporter_free(srep1);</span><br><span style="color: hsl(0, 100%, 40%);">- send_count = 0;</span><br><span style="color: hsl(0, 100%, 40%);">- osmo_stats_report();</span><br><span style="color: hsl(0, 100%, 40%);">- OSMO_ASSERT(send_count == 6);</span><br><span style="color: hsl(120, 100%, 40%);">+ do_report(4, 2);</span><br><span> </span><br><span> fprintf(stderr, "report (remove statg2):\n");</span><br><span> /* force single flush */</span><br><span> srep2->force_single_flush = 1;</span><br><span> osmo_stat_item_group_free(statg2);</span><br><span style="color: hsl(0, 100%, 40%);">- send_count = 0;</span><br><span style="color: hsl(0, 100%, 40%);">- osmo_stats_report();</span><br><span style="color: hsl(0, 100%, 40%);">- OSMO_ASSERT(send_count == 4);</span><br><span style="color: hsl(120, 100%, 40%);">+ do_report(4, 0);</span><br><span> </span><br><span> fprintf(stderr, "report (remove srep2):\n");</span><br><span> /* force single flush */</span><br><span> srep2->force_single_flush = 1;</span><br><span> osmo_stats_reporter_free(srep2);</span><br><span style="color: hsl(0, 100%, 40%);">- send_count = 0;</span><br><span style="color: hsl(0, 100%, 40%);">- osmo_stats_report();</span><br><span style="color: hsl(0, 100%, 40%);">- OSMO_ASSERT(send_count == 0);</span><br><span style="color: hsl(120, 100%, 40%);">+ do_report(0, 0);</span><br><span> </span><br><span> fprintf(stderr, "report (remove ctrg2, should be empty):\n");</span><br><span> rate_ctr_group_free(ctrg2);</span><br><span style="color: hsl(0, 100%, 40%);">- send_count = 0;</span><br><span style="color: hsl(0, 100%, 40%);">- osmo_stats_report();</span><br><span style="color: hsl(0, 100%, 40%);">- OSMO_ASSERT(send_count == 0);</span><br><span style="color: hsl(120, 100%, 40%);">+ do_report(0, 0);</span><br><span> </span><br><span> rate_ctr_group_free(ctrg3);</span><br><span> </span><br><span>diff --git a/tests/stats/stats_test.err b/tests/stats/stats_test.err</span><br><span>index daa3e5c..92d6ce1 100644</span><br><span>--- a/tests/stats/stats_test.err</span><br><span>+++ b/tests/stats/stats_test.err</span><br><span>@@ -31,6 +31,7 @@</span><br><span> test1: item p= g=test.one i=1 n=item.a v=-1 u=ma</span><br><span> test2: item p= g=test.one i=1 n=item.b v=-1 u=kb</span><br><span> test1: item p= g=test.one i=1 n=item.b v=-1 u=kb</span><br><span style="color: hsl(120, 100%, 40%);">+reported: 12 counter vals, 8 stat item vals</span><br><span> report (srep1 global):</span><br><span> test2: counter p= g=ctr-test:one_dot i=3 n=ctr:a v=0 d=0</span><br><span> test2: counter p= g=ctr-test:one_dot i=3 n=ctr:b v=0 d=0</span><br><span>@@ -42,6 +43,7 @@</span><br><span> test2: item p= g=test.one i=2 n=item.b v=-1 u=kb</span><br><span> test2: item p= g=test.one i=1 n=item.a v=-1 u=ma</span><br><span> test2: item p= g=test.one i=1 n=item.b v=-1 u=kb</span><br><span style="color: hsl(120, 100%, 40%);">+reported: 6 counter vals, 4 stat item vals</span><br><span> report (srep1 peer):</span><br><span> test2: counter p= g=ctr-test:one_dot i=3 n=ctr:a v=0 d=0</span><br><span> test2: counter p= g=ctr-test:one_dot i=3 n=ctr:b v=0 d=0</span><br><span>@@ -57,6 +59,7 @@</span><br><span> test1: item p= g=test.one i=1 n=item.a v=-1 u=ma</span><br><span> test2: item p= g=test.one i=1 n=item.b v=-1 u=kb</span><br><span> test1: item p= g=test.one i=1 n=item.b v=-1 u=kb</span><br><span style="color: hsl(120, 100%, 40%);">+reported: 6 counter vals, 8 stat item vals</span><br><span> report (srep1 subscriber):</span><br><span> test2: counter p= g=ctr-test:one_dot i=3 n=ctr:a v=0 d=0</span><br><span> test1: counter p= g=ctr-test:one_dot i=3 n=ctr:a v=0 d=0</span><br><span>@@ -78,6 +81,7 @@</span><br><span> test1: item p= g=test.one i=1 n=item.a v=-1 u=ma</span><br><span> test2: item p= g=test.one i=1 n=item.b v=-1 u=kb</span><br><span> test1: item p= g=test.one i=1 n=item.b v=-1 u=kb</span><br><span style="color: hsl(120, 100%, 40%);">+reported: 12 counter vals, 8 stat item vals</span><br><span> report (srep2 disabled):</span><br><span> test2: close</span><br><span> test1: counter p= g=ctr-test:one_dot i=3 n=ctr:a v=0 d=0</span><br><span>@@ -90,6 +94,7 @@</span><br><span> test1: item p= g=test.one i=2 n=item.b v=-1 u=kb</span><br><span> test1: item p= g=test.one i=1 n=item.a v=-1 u=ma</span><br><span> test1: item p= g=test.one i=1 n=item.b v=-1 u=kb</span><br><span style="color: hsl(120, 100%, 40%);">+reported: 6 counter vals, 4 stat item vals</span><br><span> report (srep2 enabled, no flush forced):</span><br><span> test2: open</span><br><span> test2: counter p= g=ctr-test:one_dot i=3 n=ctr:a v=0 d=0</span><br><span>@@ -102,23 +107,31 @@</span><br><span> test2: item p= g=test.one i=2 n=item.b v=-1 u=kb</span><br><span> test2: item p= g=test.one i=1 n=item.a v=-1 u=ma</span><br><span> test2: item p= g=test.one i=1 n=item.b v=-1 u=kb</span><br><span style="color: hsl(120, 100%, 40%);">+reported: 6 counter vals, 4 stat item vals</span><br><span> report (should be empty):</span><br><span style="color: hsl(120, 100%, 40%);">+reported: 0 counter vals, 0 stat item vals</span><br><span> report (group 1, counter 1 update):</span><br><span> test2: counter p= g=ctr-test:one i=1 n=ctr:a v=1 d=1</span><br><span> test1: counter p= g=ctr-test:one i=1 n=ctr:a v=1 d=1</span><br><span style="color: hsl(120, 100%, 40%);">+reported: 2 counter vals, 0 stat item vals</span><br><span> report (group 1, item 1 update):</span><br><span> test2: item p= g=test.one i=1 n=item.a v=10 u=ma</span><br><span> test1: item p= g=test.one i=1 n=item.a v=10 u=ma</span><br><span style="color: hsl(120, 100%, 40%);">+reported: 0 counter vals, 2 stat item vals</span><br><span> report (group 1, item 1 update twice):</span><br><span> test2: item p= g=test.one i=1 n=item.a v=10 u=ma</span><br><span> test1: item p= g=test.one i=1 n=item.a v=10 u=ma</span><br><span style="color: hsl(120, 100%, 40%);">+reported: 0 counter vals, 2 stat item vals</span><br><span> report (group 1, item 1 update twice, check max):</span><br><span> test2: item p= g=test.one i=1 n=item.a v=20 u=ma</span><br><span> test1: item p= g=test.one i=1 n=item.a v=20 u=ma</span><br><span style="color: hsl(120, 100%, 40%);">+reported: 0 counter vals, 2 stat item vals</span><br><span> report (group 1, item 1 no update, send last item (!= last max), OS#5215):</span><br><span> test2: item p= g=test.one i=1 n=item.a v=10 u=ma</span><br><span> test1: item p= g=test.one i=1 n=item.a v=10 u=ma</span><br><span style="color: hsl(120, 100%, 40%);">+reported: 0 counter vals, 2 stat item vals</span><br><span> report (group 1, item 1 no update, nothing to send):</span><br><span style="color: hsl(120, 100%, 40%);">+reported: 0 counter vals, 0 stat item vals</span><br><span> report (remove statg1, ctrg1):</span><br><span> test2: counter p= g=ctr-test:one_dot i=3 n=ctr:a v=0 d=0</span><br><span> test1: counter p= g=ctr-test:one_dot i=3 n=ctr:a v=0 d=0</span><br><span>@@ -132,6 +145,7 @@</span><br><span> test1: item p= g=test.one i=2 n=item.a v=-1 u=ma</span><br><span> test2: item p= g=test.one i=2 n=item.b v=-1 u=kb</span><br><span> test1: item p= g=test.one i=2 n=item.b v=-1 u=kb</span><br><span style="color: hsl(120, 100%, 40%);">+reported: 8 counter vals, 4 stat item vals</span><br><span> report (remove srep1):</span><br><span> test1: close</span><br><span> test2: counter p= g=ctr-test:one_dot i=3 n=ctr:a v=0 d=0</span><br><span>@@ -140,12 +154,16 @@</span><br><span> test2: counter p= g=ctr-test:one i=2 n=ctr:b v=0 d=0</span><br><span> test2: item p= g=test.one i=2 n=item.a v=-1 u=ma</span><br><span> test2: item p= g=test.one i=2 n=item.b v=-1 u=kb</span><br><span style="color: hsl(120, 100%, 40%);">+reported: 4 counter vals, 2 stat item vals</span><br><span> report (remove statg2):</span><br><span> test2: counter p= g=ctr-test:one_dot i=3 n=ctr:a v=0 d=0</span><br><span> test2: counter p= g=ctr-test:one_dot i=3 n=ctr:b v=0 d=0</span><br><span> test2: counter p= g=ctr-test:one i=2 n=ctr:a v=0 d=0</span><br><span> test2: counter p= g=ctr-test:one i=2 n=ctr:b v=0 d=0</span><br><span style="color: hsl(120, 100%, 40%);">+reported: 4 counter vals, 0 stat item vals</span><br><span> report (remove srep2):</span><br><span> test2: close</span><br><span style="color: hsl(120, 100%, 40%);">+reported: 0 counter vals, 0 stat item vals</span><br><span> report (remove ctrg2, should be empty):</span><br><span style="color: hsl(120, 100%, 40%);">+reported: 0 counter vals, 0 stat item vals</span><br><span> End test: test_reporting</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/25462">change 25462</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/25462"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I2da003ee6ec15f1c3959efe69e01b4ee24af82bb </div>
<div style="display:none"> Gerrit-Change-Number: 25462 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: daniel <dwillmann@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>