<p>pespin has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/25514">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">MS Power Control Loop: Support turn on-off C/I based logic<br><br>Related: SYS#4917<br>Change-Id: Ibd10eb96a5d072d5c19f7449a8b11e64aad1cd4c<br>---<br>M src/common/power_control.c<br>1 file changed, 10 insertions(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/14/25514/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/common/power_control.c b/src/common/power_control.c</span><br><span>index a3334be..8f5ce37 100644</span><br><span>--- a/src/common/power_control.c</span><br><span>+++ b/src/common/power_control.c</span><br><span>@@ -199,7 +199,7 @@</span><br><span>      uint8_t rxlev_avg;</span><br><span>   int16_t ul_lqual_cb_avg;</span><br><span>     const struct gsm_power_ctrl_meas_params *ci_meas;</span><br><span style="color: hsl(0, 100%, 40%);">-       bool ignore;</span><br><span style="color: hsl(120, 100%, 40%);">+  bool ignore, ci_on;</span><br><span> </span><br><span>      if (!trx_ms_pwr_ctrl_is_osmo(trx))</span><br><span>           return 0;</span><br><span>@@ -225,13 +225,19 @@</span><br><span>            return 0;</span><br><span>    }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-   /* If computed C/I is out of acceptable thresholds: */</span><br><span>       ci_meas = lchan_get_ci_thresholds(lchan);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+   /* Is C/I based algo enabled by config?</span><br><span style="color: hsl(120, 100%, 40%);">+       * FIXME: this can later be generalized when properly implementing P & N counting. */</span><br><span style="color: hsl(120, 100%, 40%);">+      ci_on = ci_meas->lower_cmp_n && ci_meas->upper_cmp_n;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>        ul_lqual_cb_avg = do_avg_algo(ci_meas, &state->ci_meas_proc, ul_lqual_cb);</span><br><span>    rxlev_avg = do_avg_algo(&params->rxlev_meas, &state->rxlev_meas_proc, dbm2rxlev(ul_rssi_dbm));</span><br><span style="color: hsl(0, 100%, 40%);">-    if (ul_lqual_cb_avg < ci_meas->lower_thresh * 10) {</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+   /* If computed C/I is enabled and out of acceptable thresholds: */</span><br><span style="color: hsl(120, 100%, 40%);">+    if (ci_on && ul_lqual_cb_avg < ci_meas->lower_thresh * 10) {</span><br><span>           new_dbm = ms_dbm + params->inc_step_size_db;</span><br><span style="color: hsl(0, 100%, 40%);">- } else if (ul_lqual_cb_avg > ci_meas->upper_thresh * 10) {</span><br><span style="color: hsl(120, 100%, 40%);">+      } else if (ci_on && ul_lqual_cb_avg > ci_meas->upper_thresh * 10) {</span><br><span>            new_dbm = ms_dbm - params->red_step_size_db;</span><br><span>      } else {</span><br><span>             /* Calculate the new Tx power value (in dBm) */</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bts/+/25514">change 25514</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bts/+/25514"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ibd10eb96a5d072d5c19f7449a8b11e64aad1cd4c </div>
<div style="display:none"> Gerrit-Change-Number: 25514 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>