<p>pespin <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/25502">View Change</a></p><div style="white-space:pre-wrap">Approvals:
Jenkins Builder: Verified
fixeria: Looks good to me, but someone else must approve
osmith: Looks good to me, but someone else must approve
pespin: Looks good to me, approved
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">tests: MS Power Control Loop: Show oscillation among good power levels<br><br>This test showcases the current issue where the loop keeps bouncing<br>between 2 good MS Power Level values due to the loop "accepting" and<br>"reporting back" the previously considered good MS Power Level<br>announced/used by the MS. Hence, upon report back from the network, the<br>MS will switch to this new MS Power Level, and same thing will ocurr<br>over and over.<br><br>Related: SYS#4917<br>Change-Id: I16ed7fe8a123b99008e0c041d2f3e4232057d55c<br>---<br>M tests/power/ms_power_loop_test.c<br>M tests/power/ms_power_loop_test.err<br>M tests/power/ms_power_loop_test.ok<br>3 files changed, 54 insertions(+), 5 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/tests/power/ms_power_loop_test.c b/tests/power/ms_power_loop_test.c</span><br><span>index 559eacc..d8d1c71 100644</span><br><span>--- a/tests/power/ms_power_loop_test.c</span><br><span>+++ b/tests/power/ms_power_loop_test.c</span><br><span>@@ -70,13 +70,11 @@</span><br><span> printf("\nStarting test case '%s'\n", name);</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-static inline void apply_power_test(struct gsm_lchan *lchan, int rxlev, int lqual_cb, int exp_ret, uint8_t exp_current)</span><br><span style="color: hsl(120, 100%, 40%);">+static void apply_power_test_ext(struct gsm_lchan *lchan, uint8_t ms_pwr, int rxlev, int lqual_cb, int exp_ret, uint8_t exp_current)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">- uint8_t old;</span><br><span> int ret;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- old = lchan->ms_power_ctrl.current;</span><br><span style="color: hsl(0, 100%, 40%);">- ret = lchan_ms_pwr_ctrl(lchan, lchan->ms_power_ctrl.current, rxlev, lqual_cb);</span><br><span style="color: hsl(120, 100%, 40%);">+ ret = lchan_ms_pwr_ctrl(lchan, ms_pwr, rxlev, lqual_cb);</span><br><span> </span><br><span> /* Keep the measurement counter updated */</span><br><span> lchan->meas.res_nr++;</span><br><span>@@ -84,7 +82,12 @@</span><br><span> printf("lchan_ms_pwr_ctrl(RxLvl=%d dBm) returns %d (expected %d)\n",</span><br><span> rxlev, ret, exp_ret);</span><br><span> printf("\tMS current power %u -> %u (expected %u)\n",</span><br><span style="color: hsl(0, 100%, 40%);">- old, lchan->ms_power_ctrl.current, exp_current);</span><br><span style="color: hsl(120, 100%, 40%);">+ ms_pwr, lchan->ms_power_ctrl.current, exp_current);</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+static inline void apply_power_test(struct gsm_lchan *lchan, int rxlev, int lqual_cb, int exp_ret, uint8_t exp_current)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+ apply_power_test_ext(lchan, lchan->ms_power_ctrl.current, rxlev, lqual_cb, exp_ret, exp_current);</span><br><span> }</span><br><span> </span><br><span> static void test_power_loop(void)</span><br><span>@@ -374,6 +377,34 @@</span><br><span> apply_power_test(lchan, -60, too_high_lqual, 1, 14);</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+/* Test whether ping pong between requested MS Power Level and announced MS</span><br><span style="color: hsl(120, 100%, 40%);">+ * Power level occurs, oscillating between considered good levels all the time:</span><br><span style="color: hsl(120, 100%, 40%);">+ * FIXME: Current code shows there's an issue with oscillating values. */</span><br><span style="color: hsl(120, 100%, 40%);">+static void test_good_threshold_convergence(void)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+ struct gsm_lchan *lchan;</span><br><span style="color: hsl(120, 100%, 40%);">+ const struct gsm_power_ctrl_params *params;</span><br><span style="color: hsl(120, 100%, 40%);">+ int16_t good_lqual, good_rxlev;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ init_test(__func__);</span><br><span style="color: hsl(120, 100%, 40%);">+ lchan = &g_trx->ts[0].lchan[0];</span><br><span style="color: hsl(120, 100%, 40%);">+ params = lchan->ms_power_ctrl.dpc_params;</span><br><span style="color: hsl(120, 100%, 40%);">+ lchan->ms_dpc_params.rxlev_meas.upper_thresh = 37;</span><br><span style="color: hsl(120, 100%, 40%);">+ lchan->ms_dpc_params.rxlev_meas.lower_thresh = 30;</span><br><span style="color: hsl(120, 100%, 40%);">+ lchan->type = GSM_LCHAN_SDCCH;</span><br><span style="color: hsl(120, 100%, 40%);">+ good_lqual = (params->ci_sdcch_meas.lower_thresh + 2) * 10;</span><br><span style="color: hsl(120, 100%, 40%);">+ good_rxlev = rxlev2dbm(params->rxlev_meas.lower_thresh + 2);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ lchan->ms_power_ctrl.current = 10;</span><br><span style="color: hsl(120, 100%, 40%);">+ lchan->ms_power_ctrl.max = 2;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ apply_power_test_ext(lchan, 9, good_rxlev, good_lqual, 1, 9);</span><br><span style="color: hsl(120, 100%, 40%);">+ apply_power_test_ext(lchan, 10, good_rxlev, good_lqual, 1, 10);</span><br><span style="color: hsl(120, 100%, 40%);">+ apply_power_test_ext(lchan, 9, good_rxlev, good_lqual, 1, 9);</span><br><span style="color: hsl(120, 100%, 40%);">+ apply_power_test_ext(lchan, 10, good_rxlev, good_lqual, 1, 10);</span><br><span style="color: hsl(120, 100%, 40%);">+ apply_power_test_ext(lchan, 9, good_rxlev, good_lqual, 1, 9);</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> int main(int argc, char **argv)</span><br><span> {</span><br><span> printf("Testing power loop...\n");</span><br><span>@@ -394,6 +425,7 @@</span><br><span> test_power_hysteresis();</span><br><span> test_power_ctrl_interval();</span><br><span> test_power_loop_ci();</span><br><span style="color: hsl(120, 100%, 40%);">+ test_good_threshold_convergence();</span><br><span> </span><br><span> printf("Power loop test OK\n");</span><br><span> </span><br><span>diff --git a/tests/power/ms_power_loop_test.err b/tests/power/ms_power_loop_test.err</span><br><span>index 8f58882..5a68e3b 100644</span><br><span>--- a/tests/power/ms_power_loop_test.err</span><br><span>+++ b/tests/power/ms_power_loop_test.err</span><br><span>@@ -58,3 +58,8 @@</span><br><span> (bts=0,trx=0,ts=0,ss=0) Lowering MS power control level 11 (8 dBm) => 12 (6 dBm): ms-pwr-lvl[curr 11, max 2], RSSI[curr -100, avg -100, thresh -75..-75] dBm, C/I[curr 17, avg 17, thresh 12..16] dB</span><br><span> (bts=0,trx=0,ts=0,ss=0) Lowering MS power control level 12 (6 dBm) => 13 (4 dBm): ms-pwr-lvl[curr 12, max 2], RSSI[curr -60, avg -60, thresh -75..-75] dBm, C/I[curr 14, avg 14, thresh 12..16] dB</span><br><span> (bts=0,trx=0,ts=0,ss=0) Lowering MS power control level 13 (4 dBm) => 14 (2 dBm): ms-pwr-lvl[curr 13, max 2], RSSI[curr -60, avg -60, thresh -75..-75] dBm, C/I[curr 17, avg 17, thresh 12..16] dB</span><br><span style="color: hsl(120, 100%, 40%);">+(bts=0,trx=0,ts=0,ss=0) Raising MS power control level 10 (10 dBm) => 9 (12 dBm): ms-pwr-lvl[curr 9, max 2], RSSI[curr -78, avg -78, thresh -80..-73] dBm, C/I[curr 14, avg 14, thresh 12..16] dB</span><br><span style="color: hsl(120, 100%, 40%);">+(bts=0,trx=0,ts=0,ss=0) Lowering MS power control level 9 (12 dBm) => 10 (10 dBm): ms-pwr-lvl[curr 10, max 2], RSSI[curr -78, avg -78, thresh -80..-73] dBm, C/I[curr 14, avg 14, thresh 12..16] dB</span><br><span style="color: hsl(120, 100%, 40%);">+(bts=0,trx=0,ts=0,ss=0) Raising MS power control level 10 (10 dBm) => 9 (12 dBm): ms-pwr-lvl[curr 9, max 2], RSSI[curr -78, avg -78, thresh -80..-73] dBm, C/I[curr 14, avg 14, thresh 12..16] dB</span><br><span style="color: hsl(120, 100%, 40%);">+(bts=0,trx=0,ts=0,ss=0) Lowering MS power control level 9 (12 dBm) => 10 (10 dBm): ms-pwr-lvl[curr 10, max 2], RSSI[curr -78, avg -78, thresh -80..-73] dBm, C/I[curr 14, avg 14, thresh 12..16] dB</span><br><span style="color: hsl(120, 100%, 40%);">+(bts=0,trx=0,ts=0,ss=0) Raising MS power control level 10 (10 dBm) => 9 (12 dBm): ms-pwr-lvl[curr 9, max 2], RSSI[curr -78, avg -78, thresh -80..-73] dBm, C/I[curr 14, avg 14, thresh 12..16] dB</span><br><span>diff --git a/tests/power/ms_power_loop_test.ok b/tests/power/ms_power_loop_test.ok</span><br><span>index 27992b1..4dc01e4 100644</span><br><span>--- a/tests/power/ms_power_loop_test.ok</span><br><span>+++ b/tests/power/ms_power_loop_test.ok</span><br><span>@@ -164,4 +164,16 @@</span><br><span> MS current power 12 -> 13 (expected 13)</span><br><span> lchan_ms_pwr_ctrl(RxLvl=-60 dBm) returns 1 (expected 1)</span><br><span> MS current power 13 -> 14 (expected 14)</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+Starting test case 'test_good_threshold_convergence'</span><br><span style="color: hsl(120, 100%, 40%);">+lchan_ms_pwr_ctrl(RxLvl=-78 dBm) returns 1 (expected 1)</span><br><span style="color: hsl(120, 100%, 40%);">+ MS current power 9 -> 9 (expected 9)</span><br><span style="color: hsl(120, 100%, 40%);">+lchan_ms_pwr_ctrl(RxLvl=-78 dBm) returns 1 (expected 1)</span><br><span style="color: hsl(120, 100%, 40%);">+ MS current power 10 -> 10 (expected 10)</span><br><span style="color: hsl(120, 100%, 40%);">+lchan_ms_pwr_ctrl(RxLvl=-78 dBm) returns 1 (expected 1)</span><br><span style="color: hsl(120, 100%, 40%);">+ MS current power 9 -> 9 (expected 9)</span><br><span style="color: hsl(120, 100%, 40%);">+lchan_ms_pwr_ctrl(RxLvl=-78 dBm) returns 1 (expected 1)</span><br><span style="color: hsl(120, 100%, 40%);">+ MS current power 10 -> 10 (expected 10)</span><br><span style="color: hsl(120, 100%, 40%);">+lchan_ms_pwr_ctrl(RxLvl=-78 dBm) returns 1 (expected 1)</span><br><span style="color: hsl(120, 100%, 40%);">+ MS current power 9 -> 9 (expected 9)</span><br><span> Power loop test OK</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bts/+/25502">change 25502</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bts/+/25502"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I16ed7fe8a123b99008e0c041d2f3e4232057d55c </div>
<div style="display:none"> Gerrit-Change-Number: 25502 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: osmith <osmith@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>