<p>pespin has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-pcu/+/25504">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">scheduler: Skip Tx DL idle blocks in TRX0 when not in DIRECT_PHY mode<br><br>We also want to avoid sending idle blocs in TRX0 to the BTS, so that the<br>BTS can be aware of blocks being idle and then submitting dummy blokcs<br>by itself applying required BCCH Carrier power reduction.<br><br>Related: SYS#4919<br>Change-Id: Idd58d2a09c3947098b960cfcb5cd1b7b7bca3d84<br>---<br>M src/gprs_rlcmac_sched.cpp<br>1 file changed, 7 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/04/25504/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/gprs_rlcmac_sched.cpp b/src/gprs_rlcmac_sched.cpp</span><br><span>index 08f43cd..405b7db 100644</span><br><span>--- a/src/gprs_rlcmac_sched.cpp</span><br><span>+++ b/src/gprs_rlcmac_sched.cpp</span><br><span>@@ -498,7 +498,13 @@</span><br><span>           */</span><br><span>          const unsigned num_tbfs = pdch->num_tbfs(GPRS_RLCMAC_DL_TBF)</span><br><span>                                      + pdch->num_tbfs(GPRS_RLCMAC_UL_TBF);</span><br><span style="color: hsl(0, 100%, 40%);">-                if (trx != 0 && num_tbfs == 0)</span><br><span style="color: hsl(120, 100%, 40%);">+                bool skip_idle = (num_tbfs == 0);</span><br><span style="color: hsl(120, 100%, 40%);">+#ifdef ENABLE_DIRECT_PHY</span><br><span style="color: hsl(120, 100%, 40%);">+           /* In DIRECT_PHY mode we want to always submit something to L1 in</span><br><span style="color: hsl(120, 100%, 40%);">+              * TRX0, since BTS is not preparing dummy bursts on idle TS for us */</span><br><span style="color: hsl(120, 100%, 40%);">+         skip_idle = skip_idle && trx != 0;</span><br><span style="color: hsl(120, 100%, 40%);">+#endif</span><br><span style="color: hsl(120, 100%, 40%);">+            if (skip_idle)</span><br><span>                       return 0;</span><br><span>            if ((msg = sched_dummy())) {</span><br><span>                         /* increase counter */</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-pcu/+/25504">change 25504</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-pcu/+/25504"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-pcu </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Idd58d2a09c3947098b960cfcb5cd1b7b7bca3d84 </div>
<div style="display:none"> Gerrit-Change-Number: 25504 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>