<p>osmith <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-msc/+/25478">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">msc_vlr_test: remove DLMGCP log messages from unit test output<br><br>The log output of libosmo-mgcp-client has changed. This change causes<br>the unit tests to fail because the log output does not match anymore.<br>Lets disable the DLMGCP log output since it is of minor importance<br>for VLR testing anyway.<br><br>Change-Id: Id197e4ab9ba12e284299ef520edee9c362513bf1<br>Related: SYS#5091<br>---<br>M tests/msc_vlr/msc_vlr_test_authen_reuse.err<br>M tests/msc_vlr/msc_vlr_test_call.err<br>M tests/msc_vlr/msc_vlr_test_gsm_authen.err<br>M tests/msc_vlr/msc_vlr_test_gsm_ciph.err<br>M tests/msc_vlr/msc_vlr_test_hlr_reject.err<br>M tests/msc_vlr/msc_vlr_test_hlr_timeout.err<br>M tests/msc_vlr/msc_vlr_test_ms_timeout.err<br>M tests/msc_vlr/msc_vlr_test_no_authen.err<br>M tests/msc_vlr/msc_vlr_test_reject_concurrency.err<br>M tests/msc_vlr/msc_vlr_test_rest.err<br>M tests/msc_vlr/msc_vlr_test_ss.err<br>M tests/msc_vlr/msc_vlr_test_umts_authen.err<br>M tests/msc_vlr/msc_vlr_tests.c<br>13 files changed, 1 insertion(+), 12 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/tests/msc_vlr/msc_vlr_test_authen_reuse.err b/tests/msc_vlr/msc_vlr_test_authen_reuse.err</span><br><span>index 43237cf..e62857d 100644</span><br><span>--- a/tests/msc_vlr/msc_vlr_test_authen_reuse.err</span><br><span>+++ b/tests/msc_vlr/msc_vlr_test_authen_reuse.err</span><br><span>@@ -1,4 +1,3 @@</span><br><span style="color: hsl(0, 100%, 40%);">-DLMGCP MGCP client: using endpoint domain '@mgw'</span><br><span> ===== test_auth_use_twice_geran</span><br><span> - Location Update request causes a GSUP Send Auth Info request to HLR</span><br><span>   MSC <--GERAN-A-- MS: GSM48_MT_MM_LOC_UPD_REQUEST</span><br><span>diff --git a/tests/msc_vlr/msc_vlr_test_call.err b/tests/msc_vlr/msc_vlr_test_call.err</span><br><span>index e8e3880..2322720 100644</span><br><span>--- a/tests/msc_vlr/msc_vlr_test_call.err</span><br><span>+++ b/tests/msc_vlr/msc_vlr_test_call.err</span><br><span>@@ -1,4 +1,3 @@</span><br><span style="color: hsl(0, 100%, 40%);">-DLMGCP MGCP client: using endpoint domain '@mgw'</span><br><span> ===== test_call_mo</span><br><span> - Total time passed: 0.000000 s</span><br><span> - Location Update request causes a GSUP Send Auth Info request to HLR</span><br><span>diff --git a/tests/msc_vlr/msc_vlr_test_gsm_authen.err b/tests/msc_vlr/msc_vlr_test_gsm_authen.err</span><br><span>index f27d826..cddc592 100644</span><br><span>--- a/tests/msc_vlr/msc_vlr_test_gsm_authen.err</span><br><span>+++ b/tests/msc_vlr/msc_vlr_test_gsm_authen.err</span><br><span>@@ -1,4 +1,3 @@</span><br><span style="color: hsl(0, 100%, 40%);">-DLMGCP MGCP client: using endpoint domain '@mgw'</span><br><span> ===== test_gsm_authen</span><br><span> - Location Update request causes a GSUP Send Auth Info request to HLR</span><br><span>   MSC <--GERAN-A-- MS: GSM48_MT_MM_LOC_UPD_REQUEST</span><br><span>diff --git a/tests/msc_vlr/msc_vlr_test_gsm_ciph.err b/tests/msc_vlr/msc_vlr_test_gsm_ciph.err</span><br><span>index e55c14c..29e75fe 100644</span><br><span>--- a/tests/msc_vlr/msc_vlr_test_gsm_ciph.err</span><br><span>+++ b/tests/msc_vlr/msc_vlr_test_gsm_ciph.err</span><br><span>@@ -1,4 +1,3 @@</span><br><span style="color: hsl(0, 100%, 40%);">-DLMGCP MGCP client: using endpoint domain '@mgw'</span><br><span> ===== test_ciph</span><br><span> - Location Update request causes a GSUP Send Auth Info request to HLR</span><br><span>   MSC <--GERAN-A-- MS: GSM48_MT_MM_LOC_UPD_REQUEST</span><br><span>diff --git a/tests/msc_vlr/msc_vlr_test_hlr_reject.err b/tests/msc_vlr/msc_vlr_test_hlr_reject.err</span><br><span>index 40b26d2..c8aaf4f 100644</span><br><span>--- a/tests/msc_vlr/msc_vlr_test_hlr_reject.err</span><br><span>+++ b/tests/msc_vlr/msc_vlr_test_hlr_reject.err</span><br><span>@@ -1,4 +1,3 @@</span><br><span style="color: hsl(0, 100%, 40%);">-DLMGCP MGCP client: using endpoint domain '@mgw'</span><br><span> ===== test_hlr_rej_auth_info_unknown_imsi</span><br><span> - Location Update request causes a GSUP Send Auth Info request to HLR</span><br><span>   MSC <--GERAN-A-- MS: GSM48_MT_MM_LOC_UPD_REQUEST</span><br><span>diff --git a/tests/msc_vlr/msc_vlr_test_hlr_timeout.err b/tests/msc_vlr/msc_vlr_test_hlr_timeout.err</span><br><span>index 0821a71..df26bd1 100644</span><br><span>--- a/tests/msc_vlr/msc_vlr_test_hlr_timeout.err</span><br><span>+++ b/tests/msc_vlr/msc_vlr_test_hlr_timeout.err</span><br><span>@@ -1,4 +1,3 @@</span><br><span style="color: hsl(0, 100%, 40%);">-DLMGCP MGCP client: using endpoint domain '@mgw'</span><br><span> ===== test_hlr_timeout_lu_auth_info</span><br><span> - Total time passed: 0.000000 s</span><br><span> - Location Update request causes a GSUP Send Auth Info request to HLR</span><br><span>diff --git a/tests/msc_vlr/msc_vlr_test_ms_timeout.err b/tests/msc_vlr/msc_vlr_test_ms_timeout.err</span><br><span>index 0663f9d..89bef91 100644</span><br><span>--- a/tests/msc_vlr/msc_vlr_test_ms_timeout.err</span><br><span>+++ b/tests/msc_vlr/msc_vlr_test_ms_timeout.err</span><br><span>@@ -1,4 +1,3 @@</span><br><span style="color: hsl(0, 100%, 40%);">-DLMGCP MGCP client: using endpoint domain '@mgw'</span><br><span> ===== test_ms_timeout_lu_auth_resp</span><br><span> - Total time passed: 0.000000 s</span><br><span> - Location Update request causes a GSUP Send Auth Info request to HLR</span><br><span>diff --git a/tests/msc_vlr/msc_vlr_test_no_authen.err b/tests/msc_vlr/msc_vlr_test_no_authen.err</span><br><span>index 755f463..9a9f3df 100644</span><br><span>--- a/tests/msc_vlr/msc_vlr_test_no_authen.err</span><br><span>+++ b/tests/msc_vlr/msc_vlr_test_no_authen.err</span><br><span>@@ -1,4 +1,3 @@</span><br><span style="color: hsl(0, 100%, 40%);">-DLMGCP MGCP client: using endpoint domain '@mgw'</span><br><span> ===== test_no_authen</span><br><span> - Location Update request causes a GSUP LU request to HLR</span><br><span>   MSC <--GERAN-A-- MS: GSM48_MT_MM_LOC_UPD_REQUEST</span><br><span>diff --git a/tests/msc_vlr/msc_vlr_test_reject_concurrency.err b/tests/msc_vlr/msc_vlr_test_reject_concurrency.err</span><br><span>index b211fbf..0f50103 100644</span><br><span>--- a/tests/msc_vlr/msc_vlr_test_reject_concurrency.err</span><br><span>+++ b/tests/msc_vlr/msc_vlr_test_reject_concurrency.err</span><br><span>@@ -1,4 +1,3 @@</span><br><span style="color: hsl(0, 100%, 40%);">-DLMGCP MGCP client: using endpoint domain '@mgw'</span><br><span> ===== test_reject_2nd_conn</span><br><span> - Location Update Request on one connection</span><br><span>   MSC <--GERAN-A-- MS: GSM48_MT_MM_LOC_UPD_REQUEST</span><br><span>diff --git a/tests/msc_vlr/msc_vlr_test_rest.err b/tests/msc_vlr/msc_vlr_test_rest.err</span><br><span>index f27108c..02b20b9 100644</span><br><span>--- a/tests/msc_vlr/msc_vlr_test_rest.err</span><br><span>+++ b/tests/msc_vlr/msc_vlr_test_rest.err</span><br><span>@@ -1,4 +1,3 @@</span><br><span style="color: hsl(0, 100%, 40%);">-DLMGCP MGCP client: using endpoint domain '@mgw'</span><br><span> ===== test_cm_service_without_lu</span><br><span> - CM Service Request without a prior Location Updating</span><br><span>   MSC <--GERAN-A-- MS: GSM48_MT_MM_CM_SERV_REQ</span><br><span>diff --git a/tests/msc_vlr/msc_vlr_test_ss.err b/tests/msc_vlr/msc_vlr_test_ss.err</span><br><span>index e83cb01..9a70513 100644</span><br><span>--- a/tests/msc_vlr/msc_vlr_test_ss.err</span><br><span>+++ b/tests/msc_vlr/msc_vlr_test_ss.err</span><br><span>@@ -1,4 +1,3 @@</span><br><span style="color: hsl(0, 100%, 40%);">-DLMGCP MGCP client: using endpoint domain '@mgw'</span><br><span> ===== test_ss_ussd_mo_geran</span><br><span> - Location Update request causes a GSUP LU request to HLR</span><br><span>   MSC <--GERAN-A-- MS: GSM48_MT_MM_LOC_UPD_REQUEST</span><br><span>diff --git a/tests/msc_vlr/msc_vlr_test_umts_authen.err b/tests/msc_vlr/msc_vlr_test_umts_authen.err</span><br><span>index be858b5..7b0c709 100644</span><br><span>--- a/tests/msc_vlr/msc_vlr_test_umts_authen.err</span><br><span>+++ b/tests/msc_vlr/msc_vlr_test_umts_authen.err</span><br><span>@@ -1,4 +1,3 @@</span><br><span style="color: hsl(0, 100%, 40%);">-DLMGCP MGCP client: using endpoint domain '@mgw'</span><br><span> ===== test_umts_authen_geran</span><br><span> - Location Update request causes a GSUP Send Auth Info request to HLR</span><br><span>   MSC <--GERAN-A-- MS: GSM48_MT_MM_LOC_UPD_REQUEST</span><br><span>diff --git a/tests/msc_vlr/msc_vlr_tests.c b/tests/msc_vlr/msc_vlr_tests.c</span><br><span>index 56f3684..102fba7 100644</span><br><span>--- a/tests/msc_vlr/msc_vlr_tests.c</span><br><span>+++ b/tests/msc_vlr/msc_vlr_tests.c</span><br><span>@@ -1194,6 +1194,7 @@</span><br><span>  log_set_print_category(osmo_stderr_target, 1);</span><br><span>       log_set_print_category_hex(osmo_stderr_target, 0);</span><br><span>   log_set_category_filter(osmo_stderr_target, DLSMS, 1, LOGL_DEBUG);</span><br><span style="color: hsl(120, 100%, 40%);">+    log_set_category_filter(osmo_stderr_target, DLMGCP, 0, LOGL_NOTICE);</span><br><span> </span><br><span>     if (cmdline_opts.verbose) {</span><br><span>          log_set_print_filename2(osmo_stderr_target, LOG_FILENAME_BASENAME);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-msc/+/25478">change 25478</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-msc/+/25478"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-msc </div>
<div style="display:none"> Gerrit-Branch: osmith/1.7.1 </div>
<div style="display:none"> Gerrit-Change-Id: Id197e4ab9ba12e284299ef520edee9c362513bf1 </div>
<div style="display:none"> Gerrit-Change-Number: 25478 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: osmith <osmith@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: osmith <osmith@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>