<p>pespin <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/25438">View Change</a></p><div style="white-space:pre-wrap">Approvals:
Jenkins Builder: Verified
osmith: Looks good to me, but someone else must approve
pespin: Looks good to me, approved
laforge: Looks good to me, but someone else must approve
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">MS Power Control Loop: Feed UL RSSI from correct measurement period<br><br>As per 3GPP TS 45.008 sec 4.2, the ms_pwr received in L1 SACCH Header is<br>the value used over previous measurement period. Hence, we need to feed<br>the algo with the measurements taken over that same period.<br><br>Related: SYS#4917<br>Change-Id: I00852cb37a3613606e37476c169f5a32d6b5d75e<br>---<br>M src/common/l1sap.c<br>1 file changed, 7 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/common/l1sap.c b/src/common/l1sap.c</span><br><span>index 2e122e3..a641dab 100644</span><br><span>--- a/src/common/l1sap.c</span><br><span>+++ b/src/common/l1sap.c</span><br><span>@@ -1616,6 +1616,7 @@</span><br><span> handover_frame(lchan);</span><br><span> </span><br><span> if (L1SAP_IS_LINK_SACCH(link_id)) {</span><br><span style="color: hsl(120, 100%, 40%);">+ int8_t ul_rssi;</span><br><span> radio_link_timeout(lchan, false);</span><br><span> le = &lchan->lapdm_ch.lapdm_acch;</span><br><span> /* save the SACCH L1 header in the lchan struct for RSL MEAS RES */</span><br><span>@@ -1647,7 +1648,12 @@</span><br><span> * 1- It contains measurement data for 1 SACCH block only, not the average over the entire period</span><br><span> * 2- It contains measurement data for *current* meas period, not *previous* one.</span><br><span> */</span><br><span style="color: hsl(0, 100%, 40%);">- lchan_ms_pwr_ctrl(lchan, l1_hdr->ms_pwr, data_ind->rssi, data_ind->lqual_cb);</span><br><span style="color: hsl(120, 100%, 40%);">+ /* If DTx is active on Downlink, use the '-SUB', otherwise '-FULL': */</span><br><span style="color: hsl(120, 100%, 40%);">+ if (lchan->tch.dtx.dl_active)</span><br><span style="color: hsl(120, 100%, 40%);">+ ul_rssi = rxlev2dbm(lchan->meas.ul_res.sub.rx_lev);</span><br><span style="color: hsl(120, 100%, 40%);">+ else</span><br><span style="color: hsl(120, 100%, 40%);">+ ul_rssi = rxlev2dbm(lchan->meas.ul_res.full.rx_lev);</span><br><span style="color: hsl(120, 100%, 40%);">+ lchan_ms_pwr_ctrl(lchan, l1_hdr->ms_pwr, ul_rssi, data_ind->lqual_cb);</span><br><span> lchan_bs_pwr_ctrl(lchan, (const struct gsm48_hdr *) &data[5]);</span><br><span> } else</span><br><span> le = &lchan->lapdm_ch.lapdm_dcch;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bts/+/25438">change 25438</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bts/+/25438"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I00852cb37a3613606e37476c169f5a32d6b5d75e </div>
<div style="display:none"> Gerrit-Change-Number: 25438 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: osmith <osmith@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>