<p>pespin has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/25451">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">abis: Clear code and drop code not executed<br><br>abis_init() sets "g_bts = bts;", hence bts object is the same as g_bts<br>(since we only have 1 BTS object in osmo-bts). As a result, dropping<br>checking first bts->... and later g_bts->... makes no sense: the later<br>condition will always be false.<br><br>Change-Id: I5018199221fb3c3329a59d0b91e827f077cef85d<br>---<br>M src/common/abis.c<br>1 file changed, 2 insertions(+), 8 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/51/25451/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/common/abis.c b/src/common/abis.c</span><br><span>index 3325fab..7503798 100644</span><br><span>--- a/src/common/abis.c</span><br><span>+++ b/src/common/abis.c</span><br><span>@@ -102,18 +102,12 @@</span><br><span>                   LOGP(DABIS, LOGL_FATAL, "OML link was closed early within %" PRIu64 " seconds. "</span><br><span>                              "If this situation persists, please check your BTS and BSC configuration files for errors. "</span><br><span>                       "A common error is a mismatch between unit_id configuration parameters of BTS and BSC.\n",</span><br><span style="color: hsl(0, 100%, 40%);">-                            (uint64_t) (now.tv_sec - g_bts->oml_conn_established_timestamp.tv_sec));</span><br><span style="color: hsl(120, 100%, 40%);">+                           (uint64_t) (now.tv_sec - bts->oml_conn_established_timestamp.tv_sec));</span><br><span>               }</span><br><span>            bts->oml_link = NULL;</span><br><span>             oml_rsl_was_connected = true;</span><br><span>        }</span><br><span style="color: hsl(0, 100%, 40%);">-       memset(&g_bts->oml_conn_established_timestamp, 0, sizeof(bts->oml_conn_established_timestamp));</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-       if (g_bts->osmo_link) {</span><br><span style="color: hsl(0, 100%, 40%);">-              e1inp_sign_link_destroy(g_bts->osmo_link);</span><br><span style="color: hsl(0, 100%, 40%);">-           g_bts->osmo_link = NULL;</span><br><span style="color: hsl(0, 100%, 40%);">-             oml_rsl_was_connected = true;</span><br><span style="color: hsl(0, 100%, 40%);">-   }</span><br><span style="color: hsl(120, 100%, 40%);">+     memset(&bts->oml_conn_established_timestamp, 0, sizeof(bts->oml_conn_established_timestamp));</span><br><span> </span><br><span>  /* Then iterate over the RSL signalling links */</span><br><span>     llist_for_each_entry(trx, &bts->trx_list, list) {</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bts/+/25451">change 25451</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bts/+/25451"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I5018199221fb3c3329a59d0b91e827f077cef85d </div>
<div style="display:none"> Gerrit-Change-Number: 25451 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>