<p>Patch set 5:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #d4ffd4;">Code-Review +1</span></p><p><a href="https://gerrit.osmocom.org/c/osmo-mgw/+/25421">View Change</a></p><p>3 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-mgw/+/25421/5/src/libosmo-mgcp/mgcp_codec.c">File src/libosmo-mgcp/mgcp_codec.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-mgw/+/25421/5/src/libosmo-mgcp/mgcp_codec.c@179">Patch Set #5, Line 179:</a> <code style="font-family:monospace,monospace">          strncpy(codec->audio_name, audio_name, sizeof(codec->audio_name));</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">osmo_strlcpy</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-mgw/+/25421/5/src/libosmo-mgcp/mgcp_codec.c@286">Patch Set #5, Line 286:</a> <code style="font-family:monospace,monospace">        if (!strlen(codec->subtype_name))</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">if (codec->subtype_name[0] == '\0')</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-mgw/+/25421/5/src/libosmo-mgcp/mgcp_sdp.c">File src/libosmo-mgcp/mgcp_sdp.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-mgw/+/25421/5/src/libosmo-mgcp/mgcp_sdp.c@442">Patch Set #5, Line 442:</a> <code style="font-family:monospace,monospace">                   strlen(rtp->codecs[i].subtype_name) ? rtp->codecs[i].subtype_name : "unknown");</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">rtp->codecs[i].subtype_name[0] != '\0' ? rtp->codecs[i].subtype_name : "unknown"</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-mgw/+/25421">change 25421</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-mgw/+/25421"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-mgw </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Icc41643050a5e1ca3c66f307d60b6911ba1b8032 </div>
<div style="display:none"> Gerrit-Change-Number: 25421 </div>
<div style="display:none"> Gerrit-PatchSet: 5 </div>
<div style="display:none"> Gerrit-Owner: Hoernchen <ewild@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Fri, 10 Sep 2021 11:21:22 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Gerrit-MessageType: comment </div>