<p>osmith has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-pcu/+/25401">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">pdch: has_gprs_only_tb_attached: use m_num_tbfs<br><br>Make use of the separate EGPRS counters added in previous patch<br>I0c0a1121b4ae5f031782e7e63a0c28eb0b6c8b42 to shorten<br>has_gprs_only_tb_attached.<br><br>Related: SYS#4878<br>Change-Id: I1dd7df2c740ea604f07c65bebcb7c0051aebf9ae<br>---<br>M src/pdch.cpp<br>1 file changed, 1 insertion(+), 12 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/01/25401/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/pdch.cpp b/src/pdch.cpp</span><br><span>index 8b40d7a..3d386ae 100644</span><br><span>--- a/src/pdch.cpp</span><br><span>+++ b/src/pdch.cpp</span><br><span>@@ -1108,18 +1108,7 @@</span><br><span> </span><br><span> bool gprs_rlcmac_pdch::has_gprs_only_tbf_attached() const</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">-     unsigned int i;</span><br><span style="color: hsl(0, 100%, 40%);">- unsigned int j;</span><br><span style="color: hsl(0, 100%, 40%);">- for (i = 0; i < sizeof(m_assigned_tfi[0]); i++) {</span><br><span style="color: hsl(0, 100%, 40%);">-            for (j = 0; j < 2; j++) {</span><br><span style="color: hsl(0, 100%, 40%);">-                    if (m_assigned_tfi[j] & (1UL << i)) {</span><br><span style="color: hsl(0, 100%, 40%);">-                         gprs_rlcmac_tbf *tbf = m_tbfs[j][i];</span><br><span style="color: hsl(0, 100%, 40%);">-                            if (!tbf->is_egprs_enabled())</span><br><span style="color: hsl(0, 100%, 40%);">-                                        return true;</span><br><span style="color: hsl(0, 100%, 40%);">-                    }</span><br><span style="color: hsl(0, 100%, 40%);">-               }</span><br><span style="color: hsl(0, 100%, 40%);">-       }</span><br><span style="color: hsl(0, 100%, 40%);">-       return false;</span><br><span style="color: hsl(120, 100%, 40%);">+ return m_num_tbfs[GPRS_RLCMAC_UL_TBF][TBF_TYPE_EGPRS] + m_num_tbfs[GPRS_RLCMAC_DL_TBF][TBF_TYPE_EGPRS] == 0;</span><br><span> }</span><br><span> </span><br><span> void gprs_rlcmac_pdch::reserve(enum gprs_rlcmac_tbf_direction dir)</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-pcu/+/25401">change 25401</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-pcu/+/25401"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-pcu </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I1dd7df2c740ea604f07c65bebcb7c0051aebf9ae </div>
<div style="display:none"> Gerrit-Change-Number: 25401 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: osmith <osmith@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>