<p><a href="https://gerrit.osmocom.org/c/osmo-pcu/+/25401">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-pcu/+/25401/1/src/pdch.cpp">File src/pdch.cpp:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-pcu/+/25401/1/src/pdch.cpp@1111">Patch Set #1, Line 1111:</a> <code style="font-family:monospace,monospace">      return m_num_tbfs[GPRS_RLCMAC_UL_TBF][TBF_TYPE_EGPRS] + m_num_tbfs[GPRS_RLCMAC_DL_TBF][TBF_TYPE_EGPRS] == 0;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">That's incorrect. You want to check if there's at least one GPRS TBF, not if there's no EGPRS ones.<br>Having 0 GPRS and 0 EGPRS you'd return true, which is not the aiming of this function.<br>Hence, it should be:<br>return (m_num_tbfs[GPRS_RLCMAC_UL_TBF][TBF_TYPE_GPRS] + m_num_tbfs[GPRS_RLCMAC_DL_TBF][TBF_TYPE_GPRS]) > 0;</p><p style="white-space: pre-wrap; word-wrap: break-word;">better wrap the sum in (), it's unclear at first sight the priority of operations imho.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-pcu/+/25401">change 25401</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-pcu/+/25401"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-pcu </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I1dd7df2c740ea604f07c65bebcb7c0051aebf9ae </div>
<div style="display:none"> Gerrit-Change-Number: 25401 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: osmith <osmith@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-CC: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 08 Sep 2021 12:16:00 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Gerrit-MessageType: comment </div>