<p>lynxis lazus <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/25390">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, but someone else must approve
  osmith: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">gprs_ns2: fix NS STATUS validation<br><br>The wrong TLVs were used.<br><br>Change-Id: I01339d93469285cc5340500717ab2b696284e12a<br>---<br>M src/gb/gprs_ns2_message.c<br>1 file changed, 3 insertions(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/gb/gprs_ns2_message.c b/src/gb/gprs_ns2_message.c</span><br><span>index dccf51d..5e3e025 100644</span><br><span>--- a/src/gb/gprs_ns2_message.c</span><br><span>+++ b/src/gb/gprs_ns2_message.c</span><br><span>@@ -95,12 +95,11 @@</span><br><span>           return -1;</span><br><span>   }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-   uint8_t _cause = tlvp_val8(tp, NS_IE_VCI, 0);</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(120, 100%, 40%);">+ uint8_t _cause = tlvp_val8(tp, NS_IE_CAUSE, 0);</span><br><span>      switch (_cause) {</span><br><span>    case NS_CAUSE_NSVC_BLOCKED:</span><br><span>  case NS_CAUSE_NSVC_UNKNOWN:</span><br><span style="color: hsl(0, 100%, 40%);">-             if (!TLVP_PRES_LEN(tp, NS_IE_CAUSE, 1)) {</span><br><span style="color: hsl(120, 100%, 40%);">+             if (!TLVP_PRES_LEN(tp, NS_IE_VCI, 1)) {</span><br><span>                      *cause = NS_CAUSE_MISSING_ESSENT_IE;</span><br><span>                         return -1;</span><br><span>           }</span><br><span>@@ -110,7 +109,7 @@</span><br><span>      case NS_CAUSE_PROTO_ERR_UNSPEC:</span><br><span>      case NS_CAUSE_INVAL_ESSENT_IE:</span><br><span>       case NS_CAUSE_MISSING_ESSENT_IE:</span><br><span style="color: hsl(0, 100%, 40%);">-                if (!TLVP_PRES_LEN(tp, NS_IE_CAUSE, 1)) {</span><br><span style="color: hsl(120, 100%, 40%);">+             if (!TLVP_PRES_LEN(tp, NS_IE_PDU, 1)) {</span><br><span>                      *cause = NS_CAUSE_MISSING_ESSENT_IE;</span><br><span>                         return -1;</span><br><span>           }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/25390">change 25390</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/25390"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I01339d93469285cc5340500717ab2b696284e12a </div>
<div style="display:none"> Gerrit-Change-Number: 25390 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: lynxis lazus <lynxis@fe80.eu> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: lynxis lazus <lynxis@fe80.eu> </div>
<div style="display:none"> Gerrit-Reviewer: osmith <osmith@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>