<p>lynxis lazus <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25341">View Change</a></p><div style="white-space:pre-wrap">Approvals:
lynxis lazus: Looks good to me, approved
pespin: Looks good to me, but someone else must approve
osmith: Looks good to me, but someone else must approve
Jenkins Builder: Verified
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">ns: add TC_sns_bss_remove_bind_fail_sns to check SNS fails correct when removing a bind<br><br>This TC produces an abort of the ns2 dummy by the memory sanitizer.<br>Test if SNS fails when removing a bind which has the last valid connection.<br>The ns2 has 2 binds, ttcn3 1 bind. There are 2 NSVCs.<br><br>Bind -- NSVCs -- Bind.<br><br>(ns2) (ttcn3)<br>1*-----------*1<br> /<br>2*-broken--/<br><br>Remove the 1st ns2 bind after the other NSVC has failed.<br><br>Change-Id: I8f7daee7a3bcadf64e8ae607619425adbefe3c4b<br>---<br>M ns/NS_Tests.ttcn<br>1 file changed, 39 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/ns/NS_Tests.ttcn b/ns/NS_Tests.ttcn</span><br><span>index c08f877..51a30ab 100644</span><br><span>--- a/ns/NS_Tests.ttcn</span><br><span>+++ b/ns/NS_Tests.ttcn</span><br><span>@@ -78,6 +78,7 @@</span><br><span> f_vty_set_prompts(NSVTY);</span><br><span> f_vty_transceive(NSVTY, "enable");</span><br><span> f_vty_transceive(NSVTY, "nsvc nsei " & int2str(mp_nsconfig.nsei) & " force-unconfigured");</span><br><span style="color: hsl(120, 100%, 40%);">+ f_vty_config2(NSVTY, {"ns", "nse " & int2str(mp_nsconfig.nsei)}, "ip-sns-bind local");</span><br><span> f_vty_config2(NSVTY, {"ns", "nse " & int2str(mp_nsconfig.nsei)}, "no ip-sns-bind local2");</span><br><span> f_vty_config2(NSVTY, {"ns", "bind udp local"}, "ip-sns signalling-weight 1 data-weight 1");</span><br><span> f_vty_config2(NSVTY, {"ns", "bind udp local2"}, "ip-sns signalling-weight 1 data-weight 1");</span><br><span>@@ -686,6 +687,43 @@</span><br><span> f_clean_ns_codec();</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+/* Test if SNS fails when removing a bind which has the last valid connection</span><br><span style="color: hsl(120, 100%, 40%);">+ *</span><br><span style="color: hsl(120, 100%, 40%);">+ * ns2 has 2 binds, ttcn3 1 bind.</span><br><span style="color: hsl(120, 100%, 40%);">+ *</span><br><span style="color: hsl(120, 100%, 40%);">+ * nsvcs:</span><br><span style="color: hsl(120, 100%, 40%);">+ * ns2 ttcn3</span><br><span style="color: hsl(120, 100%, 40%);">+ * 1*-----------*1</span><br><span style="color: hsl(120, 100%, 40%);">+ * /</span><br><span style="color: hsl(120, 100%, 40%);">+ * 2*-broken--/</span><br><span style="color: hsl(120, 100%, 40%);">+ *</span><br><span style="color: hsl(120, 100%, 40%);">+ * remove the 1st ns2 bind.</span><br><span style="color: hsl(120, 100%, 40%);">+ */</span><br><span style="color: hsl(120, 100%, 40%);">+testcase TC_sns_bss_remove_bind_fail_sns() runs on RAW_Test_CT {</span><br><span style="color: hsl(120, 100%, 40%);">+ g_handle_rx_alive := true;</span><br><span style="color: hsl(120, 100%, 40%);">+ f_init_vty();</span><br><span style="color: hsl(120, 100%, 40%);">+ f_init_ns_codec(mp_nsconfig);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_init_ns_codec(mp_nsconfig, 1);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_incoming_sns_size();</span><br><span style="color: hsl(120, 100%, 40%);">+ f_incoming_sns_config();</span><br><span style="color: hsl(120, 100%, 40%);">+ f_outgoing_sns_config();</span><br><span style="color: hsl(120, 100%, 40%);">+ var default d := activate(as_rx_alive_tx_ack());</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ f_vty_config2(NSVTY, {"ns", "bind udp local2"}, "ip-sns signalling-weight 1 data-weight 1");</span><br><span style="color: hsl(120, 100%, 40%);">+ f_vty_config2(NSVTY, {"ns", "nse " & int2str(g_nsconfig.nsei)}, "ip-sns-bind local2");</span><br><span style="color: hsl(120, 100%, 40%);">+ f_incoming_sns_add(idx_add := 1, w_sig := 1, w_user := 1);</span><br><span style="color: hsl(120, 100%, 40%);">+ /* 2nd bind won't have a valid connection to the ttcn3 */</span><br><span style="color: hsl(120, 100%, 40%);">+ NSCP[1].receive(t_NS_ALIVE);</span><br><span style="color: hsl(120, 100%, 40%);">+ NSCP[1].receive(t_NS_ALIVE);</span><br><span style="color: hsl(120, 100%, 40%);">+ NSCP[1].receive(t_NS_ALIVE);</span><br><span style="color: hsl(120, 100%, 40%);">+ NSCP[1].receive(t_NS_ALIVE);</span><br><span style="color: hsl(120, 100%, 40%);">+ NSCP[1].receive(t_NS_ALIVE);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_sleep(1.0);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_vty_config2(NSVTY, {"ns", "nse " & int2str(g_nsconfig.nsei)}, "no ip-sns-bind local");</span><br><span style="color: hsl(120, 100%, 40%);">+ setverdict(pass);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_clean_ns_codec();</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> testcase TC_idle() runs on RAW_Test_CT {</span><br><span> f_init_vty();</span><br><span> f_init_ns_codec(mp_nsconfig, guard_secs := 30.0);</span><br><span>@@ -852,6 +890,7 @@</span><br><span> execute( TC_sns_bss_add_change_del() );</span><br><span> /* execute( TC_sns_bss_all_signalling_nsvcs_failed() ); */</span><br><span> execute( TC_sns_rx_size_force_unconf() );</span><br><span style="color: hsl(120, 100%, 40%);">+ execute( TC_sns_bss_remove_bind_fail_sns() );</span><br><span> }</span><br><span> </span><br><span> if (mp_sns_role == SNS_ROLE_SGSN) {</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25341">change 25341</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25341"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I8f7daee7a3bcadf64e8ae607619425adbefe3c4b </div>
<div style="display:none"> Gerrit-Change-Number: 25341 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: lynxis lazus <lynxis@fe80.eu> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: lynxis lazus <lynxis@fe80.eu> </div>
<div style="display:none"> Gerrit-Reviewer: osmith <osmith@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>