<p>lynxis lazus has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/25392">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">gprs_ns2: nsvc: react on STATUS PDUs with cause code NSVC UNKNOWN/NSVC BLOCKED<br><br>A STATUS PDU with cause code NSVC UNKNOWN/NSVC BLOCKED informs the other<br>side about a state mismatch between the side.<br><br>Change-Id: Ib6a2424f3027a30f14ef0a9fc2230e6aae9a2a04<br>---<br>M src/gb/gprs_ns2_vc_fsm.c<br>1 file changed, 27 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/92/25392/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/gb/gprs_ns2_vc_fsm.c b/src/gb/gprs_ns2_vc_fsm.c</span><br><span>index aa4f31d..fa8cec2 100644</span><br><span>--- a/src/gb/gprs_ns2_vc_fsm.c</span><br><span>+++ b/src/gb/gprs_ns2_vc_fsm.c</span><br><span>@@ -618,7 +618,9 @@</span><br><span> {</span><br><span> struct gprs_ns2_vc_priv *priv = fi->priv;</span><br><span> struct gprs_ns2_inst *nsi = ns_inst_from_fi(fi);</span><br><span style="color: hsl(120, 100%, 40%);">+ struct tlv_parsed *tp;</span><br><span> struct msgb *msg = data;</span><br><span style="color: hsl(120, 100%, 40%);">+ uint8_t cause;</span><br><span> </span><br><span> switch (event) {</span><br><span> case GPRS_NS2_EV_REQ_OM_RESET:</span><br><span>@@ -709,6 +711,27 @@</span><br><span> if (fi->state == GPRS_NS2_ST_BLOCKED)</span><br><span> osmo_fsm_inst_state_chg(fi, GPRS_NS2_ST_BLOCKED, nsi->timeout[NS_TOUT_TNS_BLOCK], 0);</span><br><span> break;</span><br><span style="color: hsl(120, 100%, 40%);">+ case GPRS_NS2_EV_RX_STATUS:</span><br><span style="color: hsl(120, 100%, 40%);">+ tp = data;</span><br><span style="color: hsl(120, 100%, 40%);">+ cause = tlvp_val8(tp, NS_IE_CAUSE, 0);</span><br><span style="color: hsl(120, 100%, 40%);">+ switch (cause) {</span><br><span style="color: hsl(120, 100%, 40%);">+ case NS_CAUSE_NSVC_BLOCKED:</span><br><span style="color: hsl(120, 100%, 40%);">+ if (fi->state != GPRS_NS2_ST_BLOCKED) {</span><br><span style="color: hsl(120, 100%, 40%);">+ LOG_NS_SIGNAL(priv->nsvc, "Rx", NS_PDUT_STATUS, LOGL_ERROR, ": remote side reported blocked state.\n");</span><br><span style="color: hsl(120, 100%, 40%);">+ priv->initiate_block = false;</span><br><span style="color: hsl(120, 100%, 40%);">+ priv->accept_unitdata = false;</span><br><span style="color: hsl(120, 100%, 40%);">+ osmo_fsm_inst_state_chg(fi, GPRS_NS2_ST_BLOCKED, nsi->timeout[NS_TOUT_TNS_BLOCK], 0);</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ break;</span><br><span style="color: hsl(120, 100%, 40%);">+ case NS_CAUSE_NSVC_UNKNOWN:</span><br><span style="color: hsl(120, 100%, 40%);">+ if (fi->state != GPRS_NS2_ST_RESET && fi->state != GPRS_NS2_ST_UNCONFIGURED) {</span><br><span style="color: hsl(120, 100%, 40%);">+ LOG_NS_SIGNAL(priv->nsvc, "Rx", NS_PDUT_STATUS, LOGL_ERROR, ": remote side reported unknown nsvc.\n");</span><br><span style="color: hsl(120, 100%, 40%);">+ osmo_fsm_inst_state_chg(fi, GPRS_NS2_ST_RESET, nsi->timeout[NS_TOUT_TNS_RESET], 0);</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ break;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ break;</span><br><span> }</span><br><span> }</span><br><span> </span><br><span>@@ -728,6 +751,7 @@</span><br><span> S(GPRS_NS2_EV_RX_RESET) |</span><br><span> S(GPRS_NS2_EV_RX_ALIVE) |</span><br><span> S(GPRS_NS2_EV_RX_ALIVE_ACK) |</span><br><span style="color: hsl(120, 100%, 40%);">+ S(GPRS_NS2_EV_RX_STATUS) |</span><br><span> S(GPRS_NS2_EV_REQ_FORCE_UNCONFIGURED) |</span><br><span> S(GPRS_NS2_EV_REQ_OM_RESET) |</span><br><span> S(GPRS_NS2_EV_REQ_OM_BLOCK) |</span><br><span>@@ -896,6 +920,9 @@</span><br><span> /* UNITDATA have to free msg because it might send the msg layer upwards */</span><br><span> osmo_fsm_inst_dispatch(fi, GPRS_NS2_EV_RX_UNITDATA, msg);</span><br><span> return 0;</span><br><span style="color: hsl(120, 100%, 40%);">+ case NS_PDUT_STATUS:</span><br><span style="color: hsl(120, 100%, 40%);">+ osmo_fsm_inst_dispatch(fi, GPRS_NS2_EV_RX_STATUS, tp);</span><br><span style="color: hsl(120, 100%, 40%);">+ break;</span><br><span> default:</span><br><span> LOGPFSML(fi, LOGL_ERROR, "NSEI=%u Rx unknown NS PDU type %s\n", nsvc->nse->nsei,</span><br><span> get_value_string(gprs_ns_pdu_strings, nsh->pdu_type));</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/25392">change 25392</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/25392"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ib6a2424f3027a30f14ef0a9fc2230e6aae9a2a04 </div>
<div style="display:none"> Gerrit-Change-Number: 25392 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: lynxis lazus <lynxis@fe80.eu> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>