<p>lynxis lazus <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25138">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">ns2: introduce module parameter SnsRole<br><br>Allow the .cfg to define which tests should be run.<br>The new SGSN role SNS tests have their own configurations for<br>TTCN3 and osmo-nsdummy.<br><br>Change-Id: If8162f256428e2e1f353ffbf42a7c0cd24bcecd9<br>---<br>M ns/NS_Tests.ttcn<br>1 file changed, 17 insertions(+), 9 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/ns/NS_Tests.ttcn b/ns/NS_Tests.ttcn</span><br><span>index d42ef8c..0cef341 100644</span><br><span>--- a/ns/NS_Tests.ttcn</span><br><span>+++ b/ns/NS_Tests.ttcn</span><br><span>@@ -24,7 +24,13 @@</span><br><span> import from Osmocom_VTY_Functions all;</span><br><span> import from TELNETasp_PortType all;</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+type enumerated SnsRole {</span><br><span style="color: hsl(120, 100%, 40%);">+  SNS_ROLE_BSS                    ('00'H),</span><br><span style="color: hsl(120, 100%, 40%);">+      SNS_ROLE_SGSN                   ('01'H)</span><br><span style="color: hsl(120, 100%, 40%);">+};</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> modulepar {</span><br><span style="color: hsl(120, 100%, 40%);">+  SnsRole mp_sns_role := SNS_ROLE_BSS;</span><br><span>         OsmoNsDialect mp_dialect := NS2_DIALECT_IPACCESS;</span><br><span>    NSConfiguration mp_nsconfig := {</span><br><span>             nsei := 96,</span><br><span>@@ -736,15 +742,17 @@</span><br><span>  }</span><br><span> </span><br><span>        if (mp_dialect == NS2_DIALECT_SNS) {</span><br><span style="color: hsl(0, 100%, 40%);">-            /* BSS test cases */</span><br><span style="color: hsl(0, 100%, 40%);">-            execute( TC_sns_bss_config_success() );</span><br><span style="color: hsl(0, 100%, 40%);">-         execute( TC_sns_bss_change_weight() );</span><br><span style="color: hsl(0, 100%, 40%);">-          execute( TC_sns_bss_change_weight_timeout() );</span><br><span style="color: hsl(0, 100%, 40%);">-          execute( TC_sns_bss_add() );</span><br><span style="color: hsl(0, 100%, 40%);">-            execute( TC_sns_bss_del() );</span><br><span style="color: hsl(0, 100%, 40%);">-            execute( TC_sns_bss_add_change_del() );</span><br><span style="color: hsl(0, 100%, 40%);">-         execute( TC_sns_bss_all_signalling_nsvcs_failed() );</span><br><span style="color: hsl(0, 100%, 40%);">-            execute( TC_sns_rx_size_force_unconf() );</span><br><span style="color: hsl(120, 100%, 40%);">+             if (mp_sns_role == SNS_ROLE_BSS) {</span><br><span style="color: hsl(120, 100%, 40%);">+                    /* BSS test cases */</span><br><span style="color: hsl(120, 100%, 40%);">+                  execute( TC_sns_bss_config_success() );</span><br><span style="color: hsl(120, 100%, 40%);">+                       execute( TC_sns_bss_change_weight() );</span><br><span style="color: hsl(120, 100%, 40%);">+                        execute( TC_sns_bss_change_weight_timeout() );</span><br><span style="color: hsl(120, 100%, 40%);">+                        execute( TC_sns_bss_add() );</span><br><span style="color: hsl(120, 100%, 40%);">+                  execute( TC_sns_bss_del() );</span><br><span style="color: hsl(120, 100%, 40%);">+                  execute( TC_sns_bss_add_change_del() );</span><br><span style="color: hsl(120, 100%, 40%);">+                       execute( TC_sns_bss_all_signalling_nsvcs_failed() );</span><br><span style="color: hsl(120, 100%, 40%);">+                  execute( TC_sns_rx_size_force_unconf() );</span><br><span style="color: hsl(120, 100%, 40%);">+             }</span><br><span>    }</span><br><span> }</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25138">change 25138</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25138"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: If8162f256428e2e1f353ffbf42a7c0cd24bcecd9 </div>
<div style="display:none"> Gerrit-Change-Number: 25138 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: lynxis lazus <lynxis@fe80.eu> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: lynxis lazus <lynxis@fe80.eu> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>