<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-trx/+/25318">View Change</a></p><div style="white-space:pre-wrap">Approvals:
Jenkins Builder: Verified
dexter: Looks good to me, but someone else must approve
laforge: Looks good to me, approved
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">computeCI(): Rename verbose repeated getter to constant<br><br>Change-Id: I9b426d01a282f572c0b915c5666642dce4c60475<br>---<br>M Transceiver52M/sigProcLib.cpp<br>1 file changed, 5 insertions(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/Transceiver52M/sigProcLib.cpp b/Transceiver52M/sigProcLib.cpp</span><br><span>index 7169a15..1a72e00 100644</span><br><span>--- a/Transceiver52M/sigProcLib.cpp</span><br><span>+++ b/Transceiver52M/sigProcLib.cpp</span><br><span>@@ -1464,20 +1464,21 @@</span><br><span> static float computeCI(const signalVector *burst, const CorrelationSequence *sync,</span><br><span> float toa, int start, const complex &xcorr)</span><br><span> {</span><br><span style="color: hsl(120, 100%, 40%);">+ const int N = sync->sequence->size();</span><br><span> float S, C;</span><br><span> int ps;</span><br><span> </span><br><span> /* Integer position where the sequence starts */</span><br><span style="color: hsl(0, 100%, 40%);">- ps = start + 1 - sync->sequence->size() + (int)roundf(toa);</span><br><span style="color: hsl(120, 100%, 40%);">+ ps = start + 1 - N + (int)roundf(toa);</span><br><span> </span><br><span> /* Estimate Signal power */</span><br><span> S = 0.0f;</span><br><span style="color: hsl(0, 100%, 40%);">- for (int i=0, j=ps; i<(int)sync->sequence->size(); i++,j++)</span><br><span style="color: hsl(120, 100%, 40%);">+ for (int i=0, j=ps; i<(int)N; i++,j++)</span><br><span> S += (*burst)[j].norm2();</span><br><span style="color: hsl(0, 100%, 40%);">- S /= sync->sequence->size();</span><br><span style="color: hsl(120, 100%, 40%);">+ S /= N;</span><br><span> </span><br><span> /* Esimate Carrier power */</span><br><span style="color: hsl(0, 100%, 40%);">- C = xcorr.norm2() / ((sync->sequence->size() - 1) * sync->gain.abs());</span><br><span style="color: hsl(120, 100%, 40%);">+ C = xcorr.norm2() / ((N - 1) * sync->gain.abs());</span><br><span> </span><br><span> /* Interference = Signal - Carrier, so C/I = C / (S - C) */</span><br><span> return 3.0103f * log2f(C / (S - C));</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-trx/+/25318">change 25318</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-trx/+/25318"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-trx </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I9b426d01a282f572c0b915c5666642dce4c60475 </div>
<div style="display:none"> Gerrit-Change-Number: 25318 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>