<p>dexter has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/25295">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">sched_lchan_tch_x: do not use cmr as ft<br><br>When the AMR voice frame that is received from the MS via the radio<br>interface then CMR and FT are updated, depending on the transmission<br>phase. When the AMR frame is converted to RTP it gets a header that<br>contains the CMF and the FT at the time. When generating the RTP<br>payloed, The present implementation uses the CMR in the position<br>where the FT should be and the FT is ignored. This is not correct.<br><br>Change-Id: I6bb10ff3c76f67b9830787497653b546cf27fe8e<br>Related: SYS#5549<br>---<br>M src/osmo-bts-trx/sched_lchan_tchf.c<br>M src/osmo-bts-trx/sched_lchan_tchh.c<br>2 files changed, 2 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/95/25295/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bts-trx/sched_lchan_tchf.c b/src/osmo-bts-trx/sched_lchan_tchf.c</span><br><span>index 8e6298c..00efcf8 100644</span><br><span>--- a/src/osmo-bts-trx/sched_lchan_tchf.c</span><br><span>+++ b/src/osmo-bts-trx/sched_lchan_tchf.c</span><br><span>@@ -186,7 +186,7 @@</span><br><span>           /* only good speech frames get rtp header */</span><br><span>                 if (rc != GSM_MACBLOCK_LEN && rc >= 4) {</span><br><span>                  if (chan_state->amr_last_dtx == AMR_OTHER) {</span><br><span style="color: hsl(0, 100%, 40%);">-                         ft = chan_state->codec[chan_state->ul_cmr];</span><br><span style="color: hsl(120, 100%, 40%);">+                             ft = chan_state->codec[chan_state->ul_ft];</span><br><span>                     } else {</span><br><span>                             /* SID frames will always get Frame Type Index 8 (AMR_SID) */</span><br><span>                                ft = AMR_SID;</span><br><span>diff --git a/src/osmo-bts-trx/sched_lchan_tchh.c b/src/osmo-bts-trx/sched_lchan_tchh.c</span><br><span>index bfebb66..9402204 100644</span><br><span>--- a/src/osmo-bts-trx/sched_lchan_tchh.c</span><br><span>+++ b/src/osmo-bts-trx/sched_lchan_tchh.c</span><br><span>@@ -210,7 +210,7 @@</span><br><span>                 /* only good speech frames get rtp header */</span><br><span>                 if (rc != GSM_MACBLOCK_LEN && rc >= 4) {</span><br><span>                  if (chan_state->amr_last_dtx == AMR_OTHER) {</span><br><span style="color: hsl(0, 100%, 40%);">-                         ft = chan_state->codec[chan_state->ul_cmr];</span><br><span style="color: hsl(120, 100%, 40%);">+                             ft = chan_state->codec[chan_state->ul_ft];</span><br><span>                     } else {</span><br><span>                             /* SID frames will always get Frame Type Index 8 (AMR_SID) */</span><br><span>                                ft = AMR_SID;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bts/+/25295">change 25295</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bts/+/25295"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I6bb10ff3c76f67b9830787497653b546cf27fe8e </div>
<div style="display:none"> Gerrit-Change-Number: 25295 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>