<p>Patch set 1:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/25270">View Change</a></p><p>4 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/25270/1/src/common/scheduler.c">File src/common/scheduler.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-bts/+/25270/1/src/common/scheduler.c@694">Patch Set #1, Line 694:</a> <code style="font-family:monospace,monospace">                       rate_ctr_group_free(chan_state->ctrs);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">what about NULLing the pointer? I see it being done for other fields here.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-bts/+/25270/1/src/common/scheduler.c@1126">Patch Set #1, Line 1126:</a> <code style="font-family:monospace,monospace">                      chan_state->ctrs = rate_ctr_group_alloc(l1ts,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">no need to free previous field, like done withdl/ul_bursts above?</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-bts/+/25270/1/src/common/scheduler.c@1129">Patch Set #1, Line 1129:</a> <code style="font-family:monospace,monospace">                        snprintf(ctrg_name, sizeof(ctrg_name), "%s %s",</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space in the name? are you sure this is correct? I doubt so.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-bts/+/25270/1/src/common/scheduler.c@1139">Patch Set #1, Line 1139:</a> <code style="font-family:monospace,monospace">                    rate_ctr_group_free(chan_state->ctrs);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">set the pointer to null?</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bts/+/25270">change 25270</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bts/+/25270"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I7aea0529771ad73d5d6bcaf0865f9b0d4ecace6b </div>
<div style="display:none"> Gerrit-Change-Number: 25270 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Mon, 30 Aug 2021 08:42:22 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Gerrit-MessageType: comment </div>