<p>neels has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/25213">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">stat_item desc: add explicit indexes for clarity<br><br>Add explicit indexes like [BSC_STAT_NUM_BTS_TOTAL] = { ...<br><br>BSC_STAT_NUM_BTS_TOTAL == 0 and the first item of bsc_stat_desc of<br>course has index 0, but when grepping the code, it looks like<br>BSC_STAT_NUM_BTS_TOTAL is missing a name definition.<br><br>Same for MSC_STAT_MSC_LINKS_ACTIVE and MSC_STAT_MSC_LINKS_TOTAL.<br><br>Related: SYS#5542<br>Change-Id: Ie47e0857c41d517a9b37be96f6669d1825d24a6d<br>---<br>M src/osmo-bsc/bsc_init.c<br>M src/osmo-bsc/osmo_bsc_msc.c<br>2 files changed, 3 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/13/25213/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bsc/bsc_init.c b/src/osmo-bsc/bsc_init.c</span><br><span>index 24596f4..42acbbc 100644</span><br><span>--- a/src/osmo-bsc/bsc_init.c</span><br><span>+++ b/src/osmo-bsc/bsc_init.c</span><br><span>@@ -47,7 +47,7 @@</span><br><span> #include <stdbool.h></span><br><span> </span><br><span> static const struct osmo_stat_item_desc bsc_stat_desc[] = {</span><br><span style="color: hsl(0, 100%, 40%);">-        { "num_bts:total", "Number of configured BTS for this BSC", "", 16, 0 },</span><br><span style="color: hsl(120, 100%, 40%);">+        [BSC_STAT_NUM_BTS_TOTAL] = { "num_bts:total", "Number of configured BTS for this BSC", "", 16, 0 },</span><br><span> };</span><br><span> </span><br><span> static const struct osmo_stat_item_group_desc bsc_statg_desc = {</span><br><span>diff --git a/src/osmo-bsc/osmo_bsc_msc.c b/src/osmo-bsc/osmo_bsc_msc.c</span><br><span>index 772bea5..a80ee64 100644</span><br><span>--- a/src/osmo-bsc/osmo_bsc_msc.c</span><br><span>+++ b/src/osmo-bsc/osmo_bsc_msc.c</span><br><span>@@ -147,8 +147,8 @@</span><br><span> };</span><br><span> </span><br><span> static const struct osmo_stat_item_desc msc_stat_desc[] = {</span><br><span style="color: hsl(0, 100%, 40%);">- { "msc_links:active", "Number of active MSC links", "", 16, 0 },</span><br><span style="color: hsl(0, 100%, 40%);">-  { "msc_links:total", "Number of configured MSC links", "", 16, 0 },</span><br><span style="color: hsl(120, 100%, 40%);">+     [MSC_STAT_MSC_LINKS_ACTIVE] = { "msc_links:active", "Number of active MSC links", "", 16, 0 },</span><br><span style="color: hsl(120, 100%, 40%);">+  [MSC_STAT_MSC_LINKS_TOTAL] = { "msc_links:total", "Number of configured MSC links", "", 16, 0 },</span><br><span> };</span><br><span> </span><br><span> static const struct osmo_stat_item_group_desc msc_statg_desc = {</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/25213">change 25213</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/25213"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ie47e0857c41d517a9b37be96f6669d1825d24a6d </div>
<div style="display:none"> Gerrit-Change-Number: 25213 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>