<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-pcu/+/25203">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  fixeria: Looks good to me, but someone else must approve
  dexter: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">coverity: fix null deref from recent UL TBF leak fix<br><br>Fix a possible NULL deref, introduced in recent patch<br>I8ce21be6836549b47a606c00b793d6f005964c5c /<br>d8e8ea9c8f16e0a1d09c2ea4395e15eac7358ed2<br><br>Related: OS#5205 SYS#5561 CID#239246<br>Change-Id: I603d4a5bc0fe5bd2e9f0dba171604c459e38aeaf<br>---<br>M src/bts.cpp<br>1 file changed, 6 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/bts.cpp b/src/bts.cpp</span><br><span>index b5fdfee..a40e071 100644</span><br><span>--- a/src/bts.cpp</span><br><span>+++ b/src/bts.cpp</span><br><span>@@ -1162,13 +1162,16 @@</span><br><span> {</span><br><span>     struct gprs_rlcmac_pdch *pdch = &bts->trx[trx_no].pdch[ts];</span><br><span>   struct pdch_ulc_node *poll = pdch_ulc_get_node(pdch->ulc, fn);</span><br><span style="color: hsl(0, 100%, 40%);">-       struct gprs_rlcmac_ul_tbf *ul_tbf = as_ul_tbf(poll->tbf_poll.poll_tbf);</span><br><span style="color: hsl(120, 100%, 40%);">+    struct gprs_rlcmac_ul_tbf *ul_tbf;</span><br><span>   if (!poll || poll->type !=PDCH_ULC_NODE_TBF_POLL ||</span><br><span style="color: hsl(0, 100%, 40%);">-      poll->tbf_poll.poll_tbf->direction != GPRS_RLCMAC_UL_TBF)</span><br><span style="color: hsl(120, 100%, 40%);">+       poll->tbf_poll.poll_tbf->direction != GPRS_RLCMAC_UL_TBF) {</span><br><span>                LOGP(DL1IF, LOGL_DEBUG, "[%s] update TA = %u ignored due to "</span><br><span>                   "unknown UL TBF on TRX = %d, TS = %d, FN = %d\n",</span><br><span>                  p, ta, trx_no, ts, fn);</span><br><span style="color: hsl(0, 100%, 40%);">-    else if (ul_tbf) {</span><br><span style="color: hsl(120, 100%, 40%);">+            return;</span><br><span style="color: hsl(120, 100%, 40%);">+       }</span><br><span style="color: hsl(120, 100%, 40%);">+     ul_tbf = as_ul_tbf(poll->tbf_poll.poll_tbf);</span><br><span style="color: hsl(120, 100%, 40%);">+       if (ul_tbf) {</span><br><span>                /* we need to distinguish TA information provided by L1</span><br><span>               * from PH-DATA-IND and PHY-RA-IND so that we can properly</span><br><span>            * update TA for given TBF</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-pcu/+/25203">change 25203</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-pcu/+/25203"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-pcu </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I603d4a5bc0fe5bd2e9f0dba171604c459e38aeaf </div>
<div style="display:none"> Gerrit-Change-Number: 25203 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>