<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ci/+/25197">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  laforge: Looks good to me, approved; Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">lint: ignore EMBEDDED_FILENAME<br><br>Mentioning the file in itself is useful sometimes (e.g. when explaining<br>how to use a contrib script). So do not let the linter fail here.<br><br>Related: OS#5087<br>Change-Id: I151b97bc7f2fe83898c0598db54360807956993c<br>---<br>M lint/checkpatch/checkpatch_osmo.sh<br>1 file changed, 2 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/lint/checkpatch/checkpatch_osmo.sh b/lint/checkpatch/checkpatch_osmo.sh</span><br><span>index abeed56..b465b5a 100755</span><br><span>--- a/lint/checkpatch/checkpatch_osmo.sh</span><br><span>+++ b/lint/checkpatch/checkpatch_osmo.sh</span><br><span>@@ -14,6 +14,7 @@</span><br><span> # * COMPLEX_MACRO: we don't use parentheses when building macros of strings across multiple lines</span><br><span> # * CONSTANT_COMPARISON: not followed: "Comparisons should place the constant on the right side"</span><br><span> # * DEEP_INDENTATION: warns about many leading tabs, not useful if changing existing code without refactoring</span><br><span style="color: hsl(120, 100%, 40%);">+# * EMBEDDED_FILENAME: this is useful sometimes (e.g. explaining how to use a script), so do not fail here</span><br><span> # * EMBEDDED_FUNCTION_NAME: often __func__ isn't used, arguably not much benefit in changing this when touching code</span><br><span> # * EXECUTE_PERMISSIONS: not followed, files need to be executable: git-version-gen, some in debian/</span><br><span> # * FILE_PATH_CHANGES: we don't use a MAINTAINERS file</span><br><span>@@ -42,6 +43,7 @@</span><br><span>       --ignore COMPLEX_MACRO \</span><br><span>     --ignore CONSTANT_COMPARISON \</span><br><span>       --ignore DEEP_INDENTATION \</span><br><span style="color: hsl(120, 100%, 40%);">+   --ignore EMBEDDED_FILENAME \</span><br><span>         --ignore EMBEDDED_FUNCTION_NAME \</span><br><span>    --ignore EXECUTE_PERMISSIONS \</span><br><span>       --ignore FILE_PATH_CHANGES \</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ci/+/25197">change 25197</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ci/+/25197"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ci </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I151b97bc7f2fe83898c0598db54360807956993c </div>
<div style="display:none"> Gerrit-Change-Number: 25197 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: osmith <osmith@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>