<p>Hoernchen has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/simtrace2/+/25171">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">cardem: fix spurious NULL bytes during transfers<br><br>The "wait time extension timer" was apparently not being reset during<br>normal tx operations, which led to occasional NULL (0x60) bytes getting<br>injected into transfers, which in turn led to more tx bytes than what<br>the reader side expects...<br><br>The odd thing is that this was only noticeable with high baud rates,<br>probably due to the very long default WT of 9600 ETU, and even then only<br>because it led to weird ngff modem resets after benign transfers.<br><br>Change-Id: I15b0b83b7d93b8e5589f3640bd6eb2fc82f93394<br>Related: SYS#5553<br>---<br>M firmware/libcommon/source/card_emu.c<br>1 file changed, 1 insertion(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/simtrace2 refs/changes/71/25171/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/firmware/libcommon/source/card_emu.c b/firmware/libcommon/source/card_emu.c</span><br><span>index 4b84039..debc658 100644</span><br><span>--- a/firmware/libcommon/source/card_emu.c</span><br><span>+++ b/firmware/libcommon/source/card_emu.c</span><br><span>@@ -922,6 +922,7 @@</span><br><span>       byte = msgb_pull_u8(msg);</span><br><span> </span><br><span>        card_emu_uart_tx(ch->uart_chan, byte);</span><br><span style="color: hsl(120, 100%, 40%);">+     card_emu_uart_reset_wt(ch->uart_chan);</span><br><span> </span><br><span>        /* this must happen _after_ the byte has been transmitted */</span><br><span>         switch (ch->tpdu.state) {</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/simtrace2/+/25171">change 25171</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/simtrace2/+/25171"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: simtrace2 </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I15b0b83b7d93b8e5589f3640bd6eb2fc82f93394 </div>
<div style="display:none"> Gerrit-Change-Number: 25171 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Hoernchen <ewild@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>