<p>lynxis lazus has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/25142">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">gprs_ns2_udp: don't start the NSVC fsm for SNS<br><br>The SNS code will always create NSVC on it's own. The only case<br>when the SNS dialect allows dynamic NSE/NSVC is on the SGSN side when accepting<br>dynamic NSE and receiving the first SNS SIZE. In this case the NSVC FSM must not be started yet.<br><br>Change-Id: I86275c99432262b3c19c1ded9a77090b74303bc8<br>---<br>M src/gb/gprs_ns2_udp.c<br>1 file changed, 3 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/42/25142/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/gb/gprs_ns2_udp.c b/src/gb/gprs_ns2_udp.c</span><br><span>index 428fd4a..4816021 100644</span><br><span>--- a/src/gb/gprs_ns2_udp.c</span><br><span>+++ b/src/gb/gprs_ns2_udp.c</span><br><span>@@ -247,7 +247,9 @@</span><br><span>                      goto out;</span><br><span>            case NS2_CS_CREATED:</span><br><span>                         ns2_driver_alloc_vc(bind, nsvc, &saddr);</span><br><span style="color: hsl(0, 100%, 40%);">-                    ns2_vc_fsm_start(nsvc);</span><br><span style="color: hsl(120, 100%, 40%);">+                       /* only start the fsm for non SNS. SNS will take care of its own */</span><br><span style="color: hsl(120, 100%, 40%);">+                   if (nsvc->nse->dialect != GPRS_NS2_DIALECT_SNS)</span><br><span style="color: hsl(120, 100%, 40%);">+                         ns2_vc_fsm_start(nsvc);</span><br><span>                      break;</span><br><span>               }</span><br><span>    }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/25142">change 25142</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/25142"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I86275c99432262b3c19c1ded9a77090b74303bc8 </div>
<div style="display:none"> Gerrit-Change-Number: 25142 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: lynxis lazus <lynxis@fe80.eu> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>