<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25064">View Change</a></p><div style="white-space:pre-wrap">Approvals:
laforge: Looks good to me, approved
dexter: Looks good to me, but someone else must approve
pespin: Looks good to me, but someone else must approve
osmith: Looks good to me, but someone else must approve
Jenkins Builder: Verified
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">msc: fix conn id in 'MGCP OK' msg (as_mgcp_ack_all_mdcx)<br><br>The MDCX OK message should contain the same connection identifier as the<br>MDCX contained. So far we were always sending the second conn id,<br>regardless of which conn id was sent in the MDCX message.<br><br>Related: SYS#5130<br>Change-Id: If6f7f135d95c04ee0240f3fa9ba0b18ffc6fa24a<br>---<br>M msc/MSC_Tests.ttcn<br>1 file changed, 3 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/msc/MSC_Tests.ttcn b/msc/MSC_Tests.ttcn</span><br><span>index 0d95c61..0e0d6b6 100644</span><br><span>--- a/msc/MSC_Tests.ttcn</span><br><span>+++ b/msc/MSC_Tests.ttcn</span><br><span>@@ -5700,6 +5700,8 @@</span><br><span> private altstep as_mgcp_ack_all_mdcx(CallParameters cpars) runs on BSC_ConnHdlr {</span><br><span> var MgcpCommand mgcp_cmd;</span><br><span> [] MGCP.receive(tr_MDCX) -> value mgcp_cmd {</span><br><span style="color: hsl(120, 100%, 40%);">+ var charstring conn_id;</span><br><span style="color: hsl(120, 100%, 40%);">+ f_mgcp_find_param_entry(mgcp_cmd.params, "I", conn_id);</span><br><span> var SDP_Message sdp := valueof(ts_SDP(cpars.mgw_conn_2.mgw_rtp_ip, cpars.mgw_conn_2.mgw_rtp_ip,</span><br><span> hex2str(cpars.mgcp_call_id), "42",</span><br><span> cpars.mgw_conn_2.mgw_rtp_port,</span><br><span>@@ -5707,7 +5709,7 @@</span><br><span> { valueof(ts_SDP_rtpmap(cpars.rtp_payload_type,</span><br><span> cpars.rtp_sdp_format)),</span><br><span> valueof(ts_SDP_ptime(20)) }));</span><br><span style="color: hsl(0, 100%, 40%);">- MGCP.send(ts_MDCX_ACK(mgcp_cmd.line.trans_id, cpars.mgw_conn_2.mgcp_connection_id, sdp));</span><br><span style="color: hsl(120, 100%, 40%);">+ MGCP.send(ts_MDCX_ACK(mgcp_cmd.line.trans_id, str2hex(conn_id), sdp));</span><br><span> repeat;</span><br><span> }</span><br><span> }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25064">change 25064</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25064"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: If6f7f135d95c04ee0240f3fa9ba0b18ffc6fa24a </div>
<div style="display:none"> Gerrit-Change-Number: 25064 </div>
<div style="display:none"> Gerrit-PatchSet: 4 </div>
<div style="display:none"> Gerrit-Owner: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: osmith <osmith@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>