<p>lynxis lazus has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25141">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">ns2: mark TC_sns_bss_all_signalling_nsvcs_failed as broken<br><br>The test case tests the wrong side. The signalling<br>and data weight are valid for the other side. The correct<br>test case needs to add a second bind on the ttcn3 side because<br>the signalling and data weight is valid for the remote side.<br><br>Change-Id: Ice79a038b0b8df9e69232bb24b2f2b18b3632758<br>---<br>M ns/NS_Tests.ttcn<br>1 file changed, 5 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/41/25141/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/ns/NS_Tests.ttcn b/ns/NS_Tests.ttcn</span><br><span>index 99f0a1c..2f69c67 100644</span><br><span>--- a/ns/NS_Tests.ttcn</span><br><span>+++ b/ns/NS_Tests.ttcn</span><br><span>@@ -654,6 +654,10 @@</span><br><span>  * 3. add second bind to SNS</span><br><span>  * 4. stop reacting to NS_ALIVE on first NSVC (only NSVC with sig weight)</span><br><span>  * 5. expect SNS SIZE</span><br><span style="color: hsl(120, 100%, 40%);">+ *</span><br><span style="color: hsl(120, 100%, 40%);">+ * Broken: the test case tests the wrong side. The signalling</span><br><span style="color: hsl(120, 100%, 40%);">+ * and data weight are valid for the other side. The correct</span><br><span style="color: hsl(120, 100%, 40%);">+ * test case needs to add a second bind on the ttcn3 side.</span><br><span>  */</span><br><span> testcase TC_sns_bss_all_signalling_nsvcs_failed() runs on RAW_Test_CT {</span><br><span>  g_handle_rx_alive := true;</span><br><span>@@ -779,7 +783,7 @@</span><br><span>                     execute( TC_sns_bss_add() );</span><br><span>                         execute( TC_sns_bss_del() );</span><br><span>                         execute( TC_sns_bss_add_change_del() );</span><br><span style="color: hsl(0, 100%, 40%);">-                 execute( TC_sns_bss_all_signalling_nsvcs_failed() );</span><br><span style="color: hsl(120, 100%, 40%);">+                  /* execute( TC_sns_bss_all_signalling_nsvcs_failed() ); */</span><br><span>                   execute( TC_sns_rx_size_force_unconf() );</span><br><span>            }</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25141">change 25141</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25141"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ice79a038b0b8df9e69232bb24b2f2b18b3632758 </div>
<div style="display:none"> Gerrit-Change-Number: 25141 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: lynxis lazus <lynxis@fe80.eu> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>