<p>lynxis lazus has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/25150">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">gprs_ns2: improve reselection protection<br><br>Change-Id: I375a7639fb8e0f92fd67bb4176bd6219978aa428<br>---<br>M src/gb/gprs_ns2_sns.c<br>1 file changed, 4 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/50/25150/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/gb/gprs_ns2_sns.c b/src/gb/gprs_ns2_sns.c</span><br><span>index 6773cef..306332b 100644</span><br><span>--- a/src/gb/gprs_ns2_sns.c</span><br><span>+++ b/src/gb/gprs_ns2_sns.c</span><br><span>@@ -2202,6 +2202,9 @@</span><br><span>               /* TODO: keep the order of binds when data != NULL */</span><br><span>                /* tear down previous state</span><br><span>           * gprs_ns2_free_nsvcs() will trigger NO_NSVC, prevent this from triggering a reselection */</span><br><span style="color: hsl(120, 100%, 40%);">+          if (gss->reselection_running)</span><br><span style="color: hsl(120, 100%, 40%);">+                      break;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>             gss->reselection_running = true;</span><br><span>          while (!llist_empty(&nse->nsvc)) {</span><br><span>                    nsvc = llist_first_entry(&nse->nsvc, struct gprs_ns2_vc, list);</span><br><span>@@ -2215,6 +2218,7 @@</span><br><span>                       gss->initial = NULL;</span><br><span>                      ns2_prim_status_ind(gss->nse, NULL, 0, GPRS_NS2_AFF_CAUSE_SNS_NO_ENDPOINTS);</span><br><span>                      osmo_fsm_inst_state_chg(fi, GPRS_SNS_ST_UNCONFIGURED, 0, 3);</span><br><span style="color: hsl(120, 100%, 40%);">+                  gss->reselection_running = false;</span><br><span>                         return;</span><br><span>              } else if (!gss->initial) {</span><br><span>                       gss->initial = llist_first_entry(&gss->sns_endpoints, struct sns_endpoint, list);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/25150">change 25150</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/25150"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I375a7639fb8e0f92fd67bb4176bd6219978aa428 </div>
<div style="display:none"> Gerrit-Change-Number: 25150 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: lynxis lazus <lynxis@fe80.eu> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>