<p>lynxis lazus has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/25151">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">gprs_ns2_sns: ensure the SNS fsm behave correct when no signalling NSVCs are present<br><br>When no remaining signalling NSVCs are available the SNS must be<br>restarted (BSS) or go into unconfigured state (SGSN).<br><br>Change-Id: I95e6bbb7a418d647a8426804879571597ae06ff8<br>---<br>M src/gb/gprs_ns2_sns.c<br>1 file changed, 25 insertions(+), 10 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/51/25151/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/gb/gprs_ns2_sns.c b/src/gb/gprs_ns2_sns.c</span><br><span>index 306332b..91ec495 100644</span><br><span>--- a/src/gb/gprs_ns2_sns.c</span><br><span>+++ b/src/gb/gprs_ns2_sns.c</span><br><span>@@ -196,6 +196,7 @@</span><br><span> if (reason)</span><br><span> LOGPFSMLSRC(fi, LOGL_ERROR, file, line, "NSE %d: SNS failed: %s\n", gss->nse->nsei, reason);</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ gss->alive = false;</span><br><span> if (gss->role == GPRS_SNS_ROLE_SGSN) {</span><br><span> if (!gss->nse->persistent)</span><br><span> gprs_ns2_free_nse(gss->nse);</span><br><span>@@ -2584,22 +2585,36 @@</span><br><span> return;</span><br><span> </span><br><span> gss = nse->bss_sns_fi->priv;</span><br><span style="color: hsl(0, 100%, 40%);">- if(nse->bss_sns_fi->state != GPRS_SNS_ST_CONFIGURED && nse->bss_sns_fi->state != GPRS_SNS_ST_LOCAL_PROCEDURE)</span><br><span style="color: hsl(120, 100%, 40%);">+ if (nse->bss_sns_fi->state != GPRS_SNS_ST_CONFIGURED && nse->bss_sns_fi->state != GPRS_SNS_ST_LOCAL_PROCEDURE)</span><br><span> return;</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ if (gss->alive && nse->sum_sig_weight == 0) {</span><br><span style="color: hsl(120, 100%, 40%);">+ sns_failed(nse->bss_sns_fi, "No signalling NSVC available");</span><br><span style="color: hsl(120, 100%, 40%);">+ return;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* check if this is the current SNS NS-VC */</span><br><span style="color: hsl(120, 100%, 40%);">+ if (nsvc == gss->sns_nsvc && !alive) {</span><br><span style="color: hsl(120, 100%, 40%);">+ /* only replace the SNS NS-VC if there are other alive NS-VC.</span><br><span style="color: hsl(120, 100%, 40%);">+ * There aren't any other alive NS-VC when the SNS fsm just reached CONFIGURED</span><br><span style="color: hsl(120, 100%, 40%);">+ * and couldn't confirm yet if the NS-VC comes up */</span><br><span style="color: hsl(120, 100%, 40%);">+ llist_for_each_entry(tmp, &nse->nsvc, list) {</span><br><span style="color: hsl(120, 100%, 40%);">+ if (nsvc == tmp)</span><br><span style="color: hsl(120, 100%, 40%);">+ continue;</span><br><span style="color: hsl(120, 100%, 40%);">+ if (ns2_vc_is_unblocked(nsvc)) {</span><br><span style="color: hsl(120, 100%, 40%);">+ ns2_sns_replace_nsvc(nsvc);</span><br><span style="color: hsl(120, 100%, 40%);">+ break;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> if (alive == gss->alive)</span><br><span> return;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- /* check if this is the current SNS NS-VC */</span><br><span style="color: hsl(0, 100%, 40%);">- if (nsvc == gss->sns_nsvc) {</span><br><span style="color: hsl(0, 100%, 40%);">- /* only replace the SNS NS-VC if there are other alive NS-VC.</span><br><span style="color: hsl(0, 100%, 40%);">- * There aren't any other alive NS-VC when the SNS fsm just reached CONFIGURED</span><br><span style="color: hsl(0, 100%, 40%);">- * and couldn't confirm yet if the NS-VC comes up */</span><br><span style="color: hsl(0, 100%, 40%);">- if (gss->alive && !alive)</span><br><span style="color: hsl(0, 100%, 40%);">- ns2_sns_replace_nsvc(nsvc);</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> if (alive) {</span><br><span style="color: hsl(120, 100%, 40%);">+ /* we need at least a signalling NSVC before become alive */</span><br><span style="color: hsl(120, 100%, 40%);">+ if (nse->sum_sig_weight == 0)</span><br><span style="color: hsl(120, 100%, 40%);">+ return;</span><br><span> gss->alive = true;</span><br><span> osmo_fsm_inst_dispatch(nse->bss_sns_fi, GPRS_SNS_EV_REQ_NSVC_ALIVE, NULL);</span><br><span> } else {</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/25151">change 25151</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/25151"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I95e6bbb7a418d647a8426804879571597ae06ff8 </div>
<div style="display:none"> Gerrit-Change-Number: 25151 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: lynxis lazus <lynxis@fe80.eu> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>