<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/simtrace2/+/25083">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  laforge: Looks good to me, approved
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">firmware: make the ngff beakout blink<br><br>..but only if the cardem sim is active<br><br>Change-Id: I65f1fbeb06690a143ef4c792728c9cb917a4ffde<br>---<br>M firmware/libboard/common/include/led.h<br>M firmware/libboard/common/source/led.c<br>M firmware/libboard/ngff_cardem/source/sim_switch.c<br>3 files changed, 11 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/firmware/libboard/common/include/led.h b/firmware/libboard/common/include/led.h</span><br><span>index 339702d..1ade823 100644</span><br><span>--- a/firmware/libboard/common/include/led.h</span><br><span>+++ b/firmware/libboard/common/include/led.h</span><br><span>@@ -31,7 +31,8 @@</span><br><span>    BLINK_200O_F            = 7,</span><br><span>         BLINK_600O_F            = 8,</span><br><span>         BLINK_CUSTOM            = 9,</span><br><span style="color: hsl(0, 100%, 40%);">-    BLINK_2F_O,</span><br><span style="color: hsl(120, 100%, 40%);">+   BLINK_2F_O              = 10,</span><br><span style="color: hsl(120, 100%, 40%);">+ BLINK_5O_5F             = 11,</span><br><span>        _NUM_LED_BLINK</span><br><span> };</span><br><span> </span><br><span>diff --git a/firmware/libboard/common/source/led.c b/firmware/libboard/common/source/led.c</span><br><span>index 6772007..4822a6d 100644</span><br><span>--- a/firmware/libboard/common/source/led.c</span><br><span>+++ b/firmware/libboard/common/source/led.c</span><br><span>@@ -58,6 +58,10 @@</span><br><span>       { 0, 1 }</span><br><span> };</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+static const struct blink_state bs_5on_5off[] = {</span><br><span style="color: hsl(120, 100%, 40%);">+ { 500, 1 }, { 500, 0 }</span><br><span style="color: hsl(120, 100%, 40%);">+};</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> static const struct blink_state bs_3on_5off[] = {</span><br><span>    { 300, 1 }, { 500, 0 }</span><br><span> };</span><br><span>@@ -107,6 +111,10 @@</span><br><span>          .states = bs_on,</span><br><span>             .size = ARRAY_SIZE(bs_on),</span><br><span>   },</span><br><span style="color: hsl(120, 100%, 40%);">+    [BLINK_5O_5F] = {</span><br><span style="color: hsl(120, 100%, 40%);">+             .states = bs_5on_5off,</span><br><span style="color: hsl(120, 100%, 40%);">+                .size = ARRAY_SIZE(bs_5on_5off),</span><br><span style="color: hsl(120, 100%, 40%);">+      },</span><br><span>   [BLINK_3O_5F] = {</span><br><span>            .states = bs_3on_5off,</span><br><span>               .size = ARRAY_SIZE(bs_3on_5off),</span><br><span>diff --git a/firmware/libboard/ngff_cardem/source/sim_switch.c b/firmware/libboard/ngff_cardem/source/sim_switch.c</span><br><span>index eb2d305..cc4860a 100644</span><br><span>--- a/firmware/libboard/ngff_cardem/source/sim_switch.c</span><br><span>+++ b/firmware/libboard/ngff_cardem/source/sim_switch.c</span><br><span>@@ -61,7 +61,7 @@</span><br><span>        } else {</span><br><span>             TRACE_INFO("%u: Use remote/emulated SIM\r\n", nr);</span><br><span>                 PIO_Configure(pins_cem, PIO_LISTSIZE(pins_cem));</span><br><span style="color: hsl(0, 100%, 40%);">-                led_blink(led, BLINK_ALWAYS_OFF);</span><br><span style="color: hsl(120, 100%, 40%);">+             led_blink(led, BLINK_5O_5F);</span><br><span>         }</span><br><span> </span><br><span>        /* just power cycle the modem because this circumvents weird issues with unreliable signals */</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/simtrace2/+/25083">change 25083</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/simtrace2/+/25083"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: simtrace2 </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I65f1fbeb06690a143ef4c792728c9cb917a4ffde </div>
<div style="display:none"> Gerrit-Change-Number: 25083 </div>
<div style="display:none"> Gerrit-PatchSet: 10 </div>
<div style="display:none"> Gerrit-Owner: Hoernchen <ewild@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: osmith <osmith@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>