<p>Hoernchen has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/simtrace2/+/25081">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">firmware: proper makefile deps<br><br>Single threaded evaluation is (assumed to be!) left to right, depth<br>first - but with concurrent make using -j this breaks, because the<br>actual usb string header is generated after the attempt to concurrently<br>compile the code that needs it, since there is no explicit order among<br>the all: dependencies.<br><br>This is fixed by properly adding a dependency on that header.<br><br>Change-Id: I0bdf915deabeda861f6398e654764918e58a64c2<br>---<br>M firmware/Makefile<br>1 file changed, 2 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/simtrace2 refs/changes/81/25081/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/firmware/Makefile b/firmware/Makefile</span><br><span>index 76a58e1..2a14025 100644</span><br><span>--- a/firmware/Makefile</span><br><span>+++ b/firmware/Makefile</span><br><span>@@ -197,7 +197,7 @@</span><br><span> #               Rules</span><br><span> #-------------------------------------------------------------------------------</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-all: apps/$(APP)/usb_strings_generated.h $(BIN) $(OBJ) $(MEMORIES)</span><br><span style="color: hsl(120, 100%, 40%);">+all: $(BIN) $(OBJ) $(MEMORIES)</span><br><span> </span><br><span> combined: $(OUTPUT)-combined.bin</span><br><span> </span><br><span>@@ -208,7 +208,7 @@</span><br><span> $(OUTPUT)-combined.bin: $(BIN)/$(BOARD)-dfu-flash-padded.bin $(OUTPUT)-dfu.bin</span><br><span>  cat $^ > $@</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-$(BIN) $(OBJ):</span><br><span style="color: hsl(120, 100%, 40%);">+$(BIN) $(OBJ): apps/$(APP)/usb_strings_generated.h</span><br><span>         mkdir -p $@</span><br><span> </span><br><span> usbstring/usbstring: usbstring/usbstring.c</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/simtrace2/+/25081">change 25081</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/simtrace2/+/25081"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: simtrace2 </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I0bdf915deabeda861f6398e654764918e58a64c2 </div>
<div style="display:none"> Gerrit-Change-Number: 25081 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Hoernchen <ewild@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>