<p>pespin has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/25057">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">utils: Fix c++ warn in OSMO_STRBUF_APPEND<br><br>It's really a false positive since _sb_l is compared and granted to be<br>psotivie by the time we compare, so we don't really care, but c++ is not<br>happy about it.<br><br>"""<br>/osmocom/core/utils.h:227:40: error: comparison of integer expressions of different signedness: ‘int’ and ‘size_t’ {aka ‘long unsigned int’} [-Werror=sign-compare]<br>  227 |                 if (_sb_l < 0 || _sb_l > _sb_remain) \<br>      |                                  ~~~~~~^~~~~~~~~~~~<br>"""<br><br>Change-Id: I90e7374aa959468670f1c0ea65a427398d423ddb<br>---<br>M include/osmocom/core/utils.h<br>1 file changed, 1 insertion(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/57/25057/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/include/osmocom/core/utils.h b/include/osmocom/core/utils.h</span><br><span>index c9d5560..1c60390 100644</span><br><span>--- a/include/osmocom/core/utils.h</span><br><span>+++ b/include/osmocom/core/utils.h</span><br><span>@@ -224,7 +224,7 @@</span><br><span>                  (STRBUF).pos = (STRBUF).buf; \</span><br><span>               size_t _sb_remain = (STRBUF).buf ? (STRBUF).len - ((STRBUF).pos - (STRBUF).buf) : 0; \</span><br><span>               int _sb_l = func((STRBUF).pos, _sb_remain, ##args); \</span><br><span style="color: hsl(0, 100%, 40%);">-           if (_sb_l < 0 || _sb_l > _sb_remain) \</span><br><span style="color: hsl(120, 100%, 40%);">+          if (_sb_l < 0 || (size_t)_sb_l > _sb_remain) \</span><br><span>                         (STRBUF).pos = (STRBUF).buf + (STRBUF).len; \</span><br><span>                else if ((STRBUF).pos) \</span><br><span>                     (STRBUF).pos += _sb_l; \</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/25057">change 25057</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/25057"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I90e7374aa959468670f1c0ea65a427398d423ddb </div>
<div style="display:none"> Gerrit-Change-Number: 25057 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>