<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25014">View Change</a></p><div style="white-space:pre-wrap">Approvals:
laforge: Looks good to me, approved
pespin: Looks good to me, but someone else must approve
Jenkins Builder: Verified
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">bsc: properly f_rslem_unregister() released channels<br><br>After the RSL RF Release has happened, by definition the RSL_Emulation<br>should no longer direct RSL messages on that chan_nr to the test<br>component that used to own the chan_nr in the ConnectionTable.<br><br>Before this patch, re-using e.g. an already freed SDCCH would result in<br>non-obvious test failure. This is most relevant for generic functions<br>called from various tests, but fixing all occurences anyway.<br><br>Related: SYS#5130<br>Change-Id: I764ea2ed9af9358adeb42d7ed46b84f30f1e224c<br>---<br>M bsc/BSC_Tests.ttcn<br>1 file changed, 7 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn</span><br><span>index 47e2ad9..2012346 100644</span><br><span>--- a/bsc/BSC_Tests.ttcn</span><br><span>+++ b/bsc/BSC_Tests.ttcn</span><br><span>@@ -5041,10 +5041,12 @@</span><br><span> [] RSL.receive(tr_RSL_DEACT_SACCH(g_chan_nr)) {}</span><br><span> [] RSL.receive(tr_RSL_MsgTypeD(RSL_MT_RF_CHAN_REL)) {</span><br><span> RSL.send(ts_RSL_RF_CHAN_REL_ACK(g_chan_nr));</span><br><span style="color: hsl(120, 100%, 40%);">+ f_rslem_unregister(0, g_chan_nr);</span><br><span> }</span><br><span> [] RSL1.receive(tr_RSL_DEACT_SACCH(new_chan_nr)) {}</span><br><span> [] RSL1.receive(tr_RSL_MsgTypeD(RSL_MT_RF_CHAN_REL)) {</span><br><span> RSL1.send(ts_RSL_RF_CHAN_REL_ACK(new_chan_nr));</span><br><span style="color: hsl(120, 100%, 40%);">+ f_rslem_unregister(0, g_chan_nr, PT := RSL1_PROC);</span><br><span> }</span><br><span> [] BSSAP.receive(tr_BSSMAP_ClearComplete) {}</span><br><span> }</span><br><span>@@ -5426,6 +5428,7 @@</span><br><span> [] RSL.receive(tr_RSL_MsgTypeD(RSL_MT_RF_CHAN_REL)) {</span><br><span> log("Got RF Chan Rel");</span><br><span> RSL.send(ts_RSL_RF_CHAN_REL_ACK(g_chan_nr));</span><br><span style="color: hsl(120, 100%, 40%);">+ f_rslem_unregister(0, g_chan_nr);</span><br><span> }</span><br><span> }</span><br><span> </span><br><span>@@ -7216,6 +7219,7 @@</span><br><span> [] rsl.receive(tr_RSL_MsgTypeD(RSL_MT_RF_CHAN_REL)) {</span><br><span> f_logp(BSCVTY, "Got RSL RF Chan Rel, sending Rel Ack");</span><br><span> rsl.send(ts_RSL_RF_CHAN_REL_ACK(g_chan_nr));</span><br><span style="color: hsl(120, 100%, 40%);">+ f_rslem_unregister(0, g_chan_nr);</span><br><span> break;</span><br><span> }</span><br><span> }</span><br><span>@@ -7240,6 +7244,7 @@</span><br><span> [] rsl.receive(tr_RSL_MsgTypeD(RSL_MT_RF_CHAN_REL)) {</span><br><span> f_logp(BSCVTY, "Got RSL RF Chan Rel, sending Rel Ack");</span><br><span> rsl.send(ts_RSL_RF_CHAN_REL_ACK(g_chan_nr));</span><br><span style="color: hsl(120, 100%, 40%);">+ f_rslem_unregister(0, g_chan_nr);</span><br><span> }</span><br><span> }</span><br><span> }</span><br><span>@@ -9198,6 +9203,7 @@</span><br><span> [] RSL.receive(tr_RSL_MsgTypeD(RSL_MT_RF_CHAN_REL)) {</span><br><span> f_logp(BSCVTY, "Got RSL RF Chan Rel, sending Rel Ack");</span><br><span> RSL.send(ts_RSL_RF_CHAN_REL_ACK(g_chan_nr));</span><br><span style="color: hsl(120, 100%, 40%);">+ f_rslem_unregister(0, g_chan_nr);</span><br><span> }</span><br><span> }</span><br><span> setverdict(pass);</span><br><span>@@ -9374,6 +9380,7 @@</span><br><span> [] RSL.receive(tr_RSL_DEACT_SACCH(g_chan_nr)) {}</span><br><span> [] RSL.receive(tr_RSL_MsgTypeD(RSL_MT_RF_CHAN_REL)) {</span><br><span> RSL.send(ts_RSL_RF_CHAN_REL_ACK(g_chan_nr));</span><br><span style="color: hsl(120, 100%, 40%);">+ f_rslem_unregister(0, g_chan_nr);</span><br><span> }</span><br><span> [] BSSAP.receive(tr_BSSMAP_ClearComplete) {</span><br><span> BSSAP.send(RAN_Conn_Prim:MSC_CONN_PRIM_DISC_REQ);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25014">change 25014</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25014"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I764ea2ed9af9358adeb42d7ed46b84f30f1e224c </div>
<div style="display:none"> Gerrit-Change-Number: 25014 </div>
<div style="display:none"> Gerrit-PatchSet: 4 </div>
<div style="display:none"> Gerrit-Owner: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>