<p>pespin has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-pcu/+/25056">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">WIP: Replace ul_ass_state with osmocom FSM<br><br>Change-Id: Id414eafe9c04a9a8759c6fb1a483bf2ee093a4d2<br>---<br>M src/Makefile.am<br>M src/gprs_rlcmac_sched.cpp<br>M src/pdch.cpp<br>M src/tbf.cpp<br>M src/tbf.h<br>A src/tbf_ul_ass_fsm.c<br>A src/tbf_ul_ass_fsm.h<br>7 files changed, 308 insertions(+), 64 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/56/25056/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/Makefile.am b/src/Makefile.am</span><br><span>index 8070fda..c36abed 100644</span><br><span>--- a/src/Makefile.am</span><br><span>+++ b/src/Makefile.am</span><br><span>@@ -60,6 +60,7 @@</span><br><span> tbf.cpp \</span><br><span> tbf_fsm.c \</span><br><span> tbf_ul.cpp \</span><br><span style="color: hsl(120, 100%, 40%);">+ tbf_ul_ass_fsm.c \</span><br><span> tbf_dl.cpp \</span><br><span> bts.cpp \</span><br><span> pdch.cpp \</span><br><span>@@ -99,6 +100,7 @@</span><br><span> tbf.h \</span><br><span> tbf_fsm.h \</span><br><span> tbf_ul.h \</span><br><span style="color: hsl(120, 100%, 40%);">+ tbf_ul_ass_fsm.h \</span><br><span> tbf_dl.h \</span><br><span> bts.h \</span><br><span> pdch.h \</span><br><span>diff --git a/src/gprs_rlcmac_sched.cpp b/src/gprs_rlcmac_sched.cpp</span><br><span>index 2adf1f3..b65d5be 100644</span><br><span>--- a/src/gprs_rlcmac_sched.cpp</span><br><span>+++ b/src/gprs_rlcmac_sched.cpp</span><br><span>@@ -58,8 +58,7 @@</span><br><span> tbf_cand->ul_ack = ul_tbf;</span><br><span> if (ul_tbf->dl_ass_state_is(GPRS_RLCMAC_DL_ASS_SEND_ASS))</span><br><span> tbf_cand->dl_ass = ul_tbf;</span><br><span style="color: hsl(0, 100%, 40%);">- if (ul_tbf->ul_ass_state_is(GPRS_RLCMAC_UL_ASS_SEND_ASS)</span><br><span style="color: hsl(0, 100%, 40%);">- || ul_tbf->ul_ass_state_is(GPRS_RLCMAC_UL_ASS_SEND_ASS_REJ))</span><br><span style="color: hsl(120, 100%, 40%);">+ if (tbf_ul_ass_rts(ul_tbf))</span><br><span> tbf_cand->ul_ass = ul_tbf;</span><br><span> /* NACC ready to send. TFI assigned is needed to send messages */</span><br><span> if (ul_tbf->is_tfi_assigned() && ms_nacc_rts(ul_tbf->ms()))</span><br><span>@@ -75,8 +74,7 @@</span><br><span> continue;</span><br><span> if (dl_tbf->dl_ass_state_is(GPRS_RLCMAC_DL_ASS_SEND_ASS))</span><br><span> tbf_cand->dl_ass = dl_tbf;</span><br><span style="color: hsl(0, 100%, 40%);">- if (dl_tbf->ul_ass_state_is(GPRS_RLCMAC_UL_ASS_SEND_ASS)</span><br><span style="color: hsl(0, 100%, 40%);">- || dl_tbf->ul_ass_state_is(GPRS_RLCMAC_UL_ASS_SEND_ASS_REJ))</span><br><span style="color: hsl(120, 100%, 40%);">+ if (tbf_ul_ass_rts(dl_tbf))</span><br><span> tbf_cand->ul_ass = dl_tbf;</span><br><span> /* NACC ready to send. TFI assigned is needed to send messages */</span><br><span> if (dl_tbf->is_tfi_assigned() && ms_nacc_rts(dl_tbf->ms()))</span><br><span>@@ -169,7 +167,7 @@</span><br><span> * received, thus preventing the others from being processed.</span><br><span> */</span><br><span> if (tbf == tbfs->ul_ass && tbf->ul_ass_state_is(GPRS_RLCMAC_UL_ASS_SEND_ASS_REJ))</span><br><span style="color: hsl(0, 100%, 40%);">- msg = tbfs->ul_ass->create_packet_access_reject();</span><br><span style="color: hsl(120, 100%, 40%);">+ msg = tbf_ul_ass_create_rlcmac_msg(tbfs->ul_ass);</span><br><span> else if (tbf == tbfs->ul_ass && tbf->direction == GPRS_RLCMAC_DL_TBF)</span><br><span> msg = tbfs->ul_ass->create_ul_ass(fn, ts);</span><br><span> else if (tbf == tbfs->dl_ass && tbf->direction == GPRS_RLCMAC_UL_TBF)</span><br><span>diff --git a/src/pdch.cpp b/src/pdch.cpp</span><br><span>index b5622b4..ce29fbb 100644</span><br><span>--- a/src/pdch.cpp</span><br><span>+++ b/src/pdch.cpp</span><br><span>@@ -124,10 +124,10 @@</span><br><span> /* schedule uplink assignment or reject */</span><br><span> if (ul_tbf) {</span><br><span> LOGP(DRLCMAC, LOGL_DEBUG, "MS requests UL TBF in ack message, so we provide one:\n");</span><br><span style="color: hsl(0, 100%, 40%);">- TBF_SET_ASS_STATE_UL(tbf, GPRS_RLCMAC_UL_ASS_SEND_ASS);</span><br><span style="color: hsl(120, 100%, 40%);">+ osmo_fsm_inst_dispatch(tbf->ul_ass_fsm.fi, TBF_UL_ASS_EV_SCHED_ASS, NULL);</span><br><span> } else {</span><br><span> LOGP(DRLCMAC, LOGL_DEBUG, "MS requests UL TBF in ack message, so we packet access reject:\n");</span><br><span style="color: hsl(0, 100%, 40%);">- TBF_SET_ASS_STATE_UL(tbf, GPRS_RLCMAC_UL_ASS_SEND_ASS_REJ);</span><br><span style="color: hsl(120, 100%, 40%);">+ osmo_fsm_inst_dispatch(tbf->ul_ass_fsm.fi, TBF_UL_ASS_EV_SCHED_ASS_REJ, NULL);</span><br><span> }</span><br><span> }</span><br><span> </span><br><span>@@ -695,7 +695,7 @@</span><br><span> </span><br><span> ul_tbf->control_ts = ts_no;</span><br><span> /* schedule uplink assignment */</span><br><span style="color: hsl(0, 100%, 40%);">- TBF_SET_ASS_STATE_UL(ul_tbf, GPRS_RLCMAC_UL_ASS_SEND_ASS);</span><br><span style="color: hsl(120, 100%, 40%);">+ osmo_fsm_inst_dispatch(tbf->ul_ass_fsm.fi, TBF_UL_ASS_EV_SCHED_ASS, NULL);</span><br><span> </span><br><span> /* get measurements */</span><br><span> get_meas(meas, request);</span><br><span>diff --git a/src/tbf.cpp b/src/tbf.cpp</span><br><span>index 8f85d2e..fc42148 100644</span><br><span>--- a/src/tbf.cpp</span><br><span>+++ b/src/tbf.cpp</span><br><span>@@ -50,6 +50,7 @@</span><br><span> #include "gsm_rlcmac.h"</span><br><span> #include "coding_scheme.h"</span><br><span> #include "nacc_fsm.h"</span><br><span style="color: hsl(120, 100%, 40%);">+#include "tbf_ul_ass_fsm.h"</span><br><span> }</span><br><span> </span><br><span> #include <errno.h></span><br><span>@@ -133,7 +134,6 @@</span><br><span> m_ctrs(NULL),</span><br><span> m_ms(ms),</span><br><span> dl_ass_state(GPRS_RLCMAC_DL_ASS_NONE),</span><br><span style="color: hsl(0, 100%, 40%);">- ul_ass_state(GPRS_RLCMAC_UL_ASS_NONE),</span><br><span> ul_ack_state(GPRS_RLCMAC_UL_ACK_NONE),</span><br><span> m_egprs_enabled(false)</span><br><span> {</span><br><span>@@ -153,6 +153,10 @@</span><br><span> state_fsm.tbf = this;</span><br><span> state_fsm.fi = osmo_fsm_inst_alloc(&tbf_fsm, this, &state_fsm, LOGL_INFO, NULL);</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ memset(&ul_ass_fsm, 0, sizeof(ul_state_fsm));</span><br><span style="color: hsl(120, 100%, 40%);">+ ul_ass_fsm.tbf = this;</span><br><span style="color: hsl(120, 100%, 40%);">+ ul_ass_fsm.fi = osmo_fsm_inst_alloc(&tbf_ul_ass_fsm, this, &ul_ass_fsm, LOGL_INFO, NULL);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> m_rlc.init();</span><br><span> m_llc.init();</span><br><span> </span><br><span>@@ -164,6 +168,10 @@</span><br><span> {</span><br><span> osmo_fsm_inst_free(state_fsm.fi);</span><br><span> state_fsm.fi = NULL;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ osmo_fsm_inst_free(ul_ass_fsm.fi);</span><br><span style="color: hsl(120, 100%, 40%);">+ ul_ass_fsm.fi = NULL;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> rate_ctr_group_free(m_ctrs);</span><br><span> }</span><br><span> </span><br><span>@@ -921,36 +929,6 @@</span><br><span> return NULL;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-struct msgb *gprs_rlcmac_tbf::create_packet_access_reject()</span><br><span style="color: hsl(0, 100%, 40%);">-{</span><br><span style="color: hsl(0, 100%, 40%);">- struct msgb *msg;</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- msg = msgb_alloc(GSM_MACBLOCK_LEN, "rlcmac_ul_ass_rej");</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- bitvec *packet_access_rej = bitvec_alloc(GSM_MACBLOCK_LEN, tall_pcu_ctx);</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- bitvec_unhex(packet_access_rej, DUMMY_VEC);</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- Encoding::write_packet_access_reject(packet_access_rej, tlli(),</span><br><span style="color: hsl(0, 100%, 40%);">- osmo_tdef_get(bts->T_defs_bts, 3172, OSMO_TDEF_MS, -1));</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- bts_do_rate_ctr_inc(bts, CTR_PKT_ACCESS_REJ);</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- bitvec_pack(packet_access_rej, msgb_put(msg, GSM_MACBLOCK_LEN));</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- bitvec_free(packet_access_rej);</span><br><span style="color: hsl(0, 100%, 40%);">- ul_ass_state = GPRS_RLCMAC_UL_ASS_NONE;</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- /* Start release only if it is UL TBF */</span><br><span style="color: hsl(0, 100%, 40%);">- if (direction == GPRS_RLCMAC_UL_TBF) {</span><br><span style="color: hsl(0, 100%, 40%);">- /* tbf_free() called in gprs_rlcmac_tbf::handle_timeout */</span><br><span style="color: hsl(0, 100%, 40%);">- T_START(this, T0, -2000, "reject (PACCH)", true);</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- return msg;</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-}</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> struct msgb *gprs_rlcmac_tbf::create_ul_ass(uint32_t fn, uint8_t ts)</span><br><span> {</span><br><span> struct msgb *msg = NULL;</span><br><span>diff --git a/src/tbf.h b/src/tbf.h</span><br><span>index 6c33bc2..485f559 100644</span><br><span>--- a/src/tbf.h</span><br><span>+++ b/src/tbf.h</span><br><span>@@ -64,15 +64,6 @@</span><br><span> </span><br><span> extern const struct value_string gprs_rlcmac_tbf_dl_ass_state_names[];</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-enum gprs_rlcmac_tbf_ul_ass_state {</span><br><span style="color: hsl(0, 100%, 40%);">- GPRS_RLCMAC_UL_ASS_NONE = 0,</span><br><span style="color: hsl(0, 100%, 40%);">- GPRS_RLCMAC_UL_ASS_SEND_ASS, /* send uplink assignment on next RTS */</span><br><span style="color: hsl(0, 100%, 40%);">- GPRS_RLCMAC_UL_ASS_SEND_ASS_REJ, /* send assignment reject next RTS */</span><br><span style="color: hsl(0, 100%, 40%);">- GPRS_RLCMAC_UL_ASS_WAIT_ACK, /* wait for PACKET CONTROL ACK */</span><br><span style="color: hsl(0, 100%, 40%);">-};</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-extern const struct value_string gprs_rlcmac_tbf_ul_ass_state_names[];</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> enum gprs_rlcmac_tbf_ul_ack_state {</span><br><span> GPRS_RLCMAC_UL_ACK_NONE = 0,</span><br><span> GPRS_RLCMAC_UL_ACK_SEND_ACK, /* send acknowledge on next RTS */</span><br><span>@@ -153,7 +144,6 @@</span><br><span> #define T_START(tbf, t, T, r, f) tbf->t_start(t, T, r, f, __FILE__, __LINE__)</span><br><span> </span><br><span> #define TBF_SET_ASS_STATE_DL(t, st) do { t->set_ass_state_dl(st, __FILE__, __LINE__); } while(0)</span><br><span style="color: hsl(0, 100%, 40%);">-#define TBF_SET_ASS_STATE_UL(t, st) do { t->set_ass_state_ul(st, __FILE__, __LINE__); } while(0)</span><br><span> #define TBF_SET_ACK_STATE(t, st) do { t->set_ack_state(st, __FILE__, __LINE__); } while(0)</span><br><span> </span><br><span> #ifdef __cplusplus</span><br><span>@@ -196,10 +186,9 @@</span><br><span> bool state_is(enum tbf_fsm_states rhs) const;</span><br><span> bool state_is_not(enum tbf_fsm_states rhs) const;</span><br><span> bool dl_ass_state_is(enum gprs_rlcmac_tbf_dl_ass_state rhs) const;</span><br><span style="color: hsl(0, 100%, 40%);">- bool ul_ass_state_is(enum gprs_rlcmac_tbf_ul_ass_state rhs) const;</span><br><span style="color: hsl(120, 100%, 40%);">+ bool ul_ass_state_is(enum tbf_ul_ass_fsm_event rhs) const;</span><br><span> bool ul_ack_state_is(enum gprs_rlcmac_tbf_ul_ack_state rhs) const;</span><br><span> void set_ass_state_dl(enum gprs_rlcmac_tbf_dl_ass_state new_state, const char *file, int line);</span><br><span style="color: hsl(0, 100%, 40%);">- void set_ass_state_ul(enum gprs_rlcmac_tbf_ul_ass_state new_state, const char *file, int line);</span><br><span> void set_ack_state(enum gprs_rlcmac_tbf_ul_ack_state new_state, const char *file, int line);</span><br><span> void poll_sched_set(const char *file, int line);</span><br><span> void poll_sched_unset(const char *file, int line);</span><br><span>@@ -210,7 +199,6 @@</span><br><span> </span><br><span> struct msgb *create_dl_ass(uint32_t fn, uint8_t ts);</span><br><span> struct msgb *create_ul_ass(uint32_t fn, uint8_t ts);</span><br><span style="color: hsl(0, 100%, 40%);">- struct msgb *create_packet_access_reject();</span><br><span> </span><br><span> GprsMs *ms() const;</span><br><span> void set_ms(GprsMs *ms);</span><br><span>@@ -305,6 +293,8 @@</span><br><span> </span><br><span> struct rate_ctr_group *m_ctrs;</span><br><span> struct tbf_fsm_ctx state_fsm;</span><br><span style="color: hsl(120, 100%, 40%);">+ struct tbf_ul_ass_fsm_ctx ul_ass_fsm;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> struct llist_item m_ms_list;</span><br><span> struct llist_item m_trx_list;</span><br><span> </span><br><span>@@ -318,7 +308,6 @@</span><br><span> private:</span><br><span> void enable_egprs();</span><br><span> enum gprs_rlcmac_tbf_dl_ass_state dl_ass_state;</span><br><span style="color: hsl(0, 100%, 40%);">- enum gprs_rlcmac_tbf_ul_ass_state ul_ass_state;</span><br><span> enum gprs_rlcmac_tbf_ul_ack_state ul_ack_state;</span><br><span> bool m_egprs_enabled;</span><br><span> struct osmo_timer_list Tarr[T_MAX];</span><br><span>@@ -336,9 +325,9 @@</span><br><span> return dl_ass_state == rhs;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-inline bool gprs_rlcmac_tbf::ul_ass_state_is(enum gprs_rlcmac_tbf_ul_ass_state rhs) const</span><br><span style="color: hsl(120, 100%, 40%);">+inline bool gprs_rlcmac_tbf::ul_ass_state_is(enum tbf_ul_ass_fsm_event rhs) const</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">- return ul_ass_state == rhs;</span><br><span style="color: hsl(120, 100%, 40%);">+ return (enum tbf_fsm_states)tbf->ul_ass_fsm.fi->state == rhs;</span><br><span> }</span><br><span> </span><br><span> inline bool gprs_rlcmac_tbf::ul_ack_state_is(enum gprs_rlcmac_tbf_ul_ack_state rhs) const</span><br><span>@@ -366,15 +355,6 @@</span><br><span> dl_ass_state = new_state;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-inline void gprs_rlcmac_tbf::set_ass_state_ul(enum gprs_rlcmac_tbf_ul_ass_state new_state, const char *file, int line)</span><br><span style="color: hsl(0, 100%, 40%);">-{</span><br><span style="color: hsl(0, 100%, 40%);">- LOGPSRC(DTBF, LOGL_DEBUG, file, line, "%s changes UL ASS state from %s to %s\n",</span><br><span style="color: hsl(0, 100%, 40%);">- tbf_name(this),</span><br><span style="color: hsl(0, 100%, 40%);">- get_value_string(gprs_rlcmac_tbf_ul_ass_state_names, ul_ass_state),</span><br><span style="color: hsl(0, 100%, 40%);">- get_value_string(gprs_rlcmac_tbf_ul_ass_state_names, new_state));</span><br><span style="color: hsl(0, 100%, 40%);">- ul_ass_state = new_state;</span><br><span style="color: hsl(0, 100%, 40%);">-}</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> inline void gprs_rlcmac_tbf::set_ack_state(enum gprs_rlcmac_tbf_ul_ack_state new_state, const char *file, int line)</span><br><span> {</span><br><span> LOGPSRC(DTBF, LOGL_DEBUG, file, line, "%s changes UL ACK state from %s to %s\n",</span><br><span>diff --git a/src/tbf_ul_ass_fsm.c b/src/tbf_ul_ass_fsm.c</span><br><span>new file mode 100644</span><br><span>index 0000000..e45482f</span><br><span>--- /dev/null</span><br><span>+++ b/src/tbf_ul_ass_fsm.c</span><br><span>@@ -0,0 +1,221 @@</span><br><span style="color: hsl(120, 100%, 40%);">+/* tbf_ul_ass_fsm.c</span><br><span style="color: hsl(120, 100%, 40%);">+ *</span><br><span style="color: hsl(120, 100%, 40%);">+ * Copyright (C) 2021 by sysmocom - s.f.m.c. GmbH <info@sysmocom.de></span><br><span style="color: hsl(120, 100%, 40%);">+ * Author: Pau Espin Pedrol <pespin@sysmocom.de></span><br><span style="color: hsl(120, 100%, 40%);">+ *</span><br><span style="color: hsl(120, 100%, 40%);">+ * This program is free software; you can redistribute it and/or</span><br><span style="color: hsl(120, 100%, 40%);">+ * modify it under the terms of the GNU General Public License</span><br><span style="color: hsl(120, 100%, 40%);">+ * as published by the Free Software Foundation; either version 2</span><br><span style="color: hsl(120, 100%, 40%);">+ * of the License, or (at your option) any later version.</span><br><span style="color: hsl(120, 100%, 40%);">+ *</span><br><span style="color: hsl(120, 100%, 40%);">+ * This program is distributed in the hope that it will be useful,</span><br><span style="color: hsl(120, 100%, 40%);">+ * but WITHOUT ANY WARRANTY; without even the implied warranty of</span><br><span style="color: hsl(120, 100%, 40%);">+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the</span><br><span style="color: hsl(120, 100%, 40%);">+ * GNU General Public License for more details.</span><br><span style="color: hsl(120, 100%, 40%);">+ *</span><br><span style="color: hsl(120, 100%, 40%);">+ * You should have received a copy of the GNU General Public License</span><br><span style="color: hsl(120, 100%, 40%);">+ * along with this program; if not, write to the Free Software</span><br><span style="color: hsl(120, 100%, 40%);">+ * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA.</span><br><span style="color: hsl(120, 100%, 40%);">+ */</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+#include <unistd.h></span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+#include <talloc.h></span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+#include <tbf_ul_ass_fsm.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <gprs_rlcmac.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <gprs_debug.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <gprs_ms.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <encoding.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <bts.h></span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+#define X(s) (1 << (s))</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+const struct osmo_tdef_state_timeout tbf_ul_ass_fsm_timeouts[32] = {</span><br><span style="color: hsl(120, 100%, 40%);">+ [TBF_UL_ASS_NONE] = {},</span><br><span style="color: hsl(120, 100%, 40%);">+ [TBF_UL_ASS_SEND_ASS] = {},</span><br><span style="color: hsl(120, 100%, 40%);">+ [TBF_UL_ASS_SEND_ASS_REJ] = {},</span><br><span style="color: hsl(120, 100%, 40%);">+ [TBF_UL_ASS_WAIT_ACK] = {},</span><br><span style="color: hsl(120, 100%, 40%);">+};</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+const struct value_string tbf_ul_ass_fsm_event_names[] = {</span><br><span style="color: hsl(120, 100%, 40%);">+ { TBF_UL_ASS_EV_SCHED_ASS, "SCHED_ASS" },</span><br><span style="color: hsl(120, 100%, 40%);">+ { TBF_UL_ASS_EV_SCHED_ASS_REJ, "SCHED_ASS_REJ" },</span><br><span style="color: hsl(120, 100%, 40%);">+ { TBF_UL_ASS_EV_CREATE_RLCMAC_MSG, "CREATE_RLCMAC_MSG" },</span><br><span style="color: hsl(120, 100%, 40%);">+ { 0, NULL }</span><br><span style="color: hsl(120, 100%, 40%);">+};</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+static struct msgb *create_packet_access_reject(const struct tbf_ul_ass_fsm_ctx *ctx)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+ struct msgb *msg;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ msg = msgb_alloc(GSM_MACBLOCK_LEN, "rlcmac_ul_ass_rej");</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ bitvec *packet_access_rej = bitvec_alloc(GSM_MACBLOCK_LEN, tall_pcu_ctx);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ bitvec_unhex(packet_access_rej, DUMMY_VEC);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ Encoding::write_packet_access_reject(packet_access_rej, tlli(),</span><br><span style="color: hsl(120, 100%, 40%);">+ osmo_tdef_get(bts->T_defs_bts, 3172, OSMO_TDEF_MS, -1));</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ bts_do_rate_ctr_inc(bts, CTR_PKT_ACCESS_REJ);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ bitvec_pack(packet_access_rej, msgb_put(msg, GSM_MACBLOCK_LEN));</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ bitvec_free(packet_access_rej);</span><br><span style="color: hsl(120, 100%, 40%);">+ ul_ass_state = GPRS_RLCMAC_UL_ASS_NONE;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Start release only if it is UL TBF */</span><br><span style="color: hsl(120, 100%, 40%);">+ if (direction == GPRS_RLCMAC_UL_TBF) {</span><br><span style="color: hsl(120, 100%, 40%);">+ /* tbf_free() called in gprs_rlcmac_tbf::handle_timeout */</span><br><span style="color: hsl(120, 100%, 40%);">+ T_START(this, T0, -2000, "reject (PACCH)", true);</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ return msg;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+static void st_none(struct osmo_fsm_inst *fi, uint32_t event, void *data)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+ struct tbf_ul_ass_fsm_ctx *ctx = (struct tbf_ul_ass_fsm_ctx *)fi->priv;</span><br><span style="color: hsl(120, 100%, 40%);">+ switch (event) {</span><br><span style="color: hsl(120, 100%, 40%);">+ case TBF_UL_ASS_EV_SCHED_ASS:</span><br><span style="color: hsl(120, 100%, 40%);">+ tbf_ul_ass_fsm_state_chg(fi, TBF_UL_ASS_SEND_ASS);</span><br><span style="color: hsl(120, 100%, 40%);">+ break;</span><br><span style="color: hsl(120, 100%, 40%);">+ case TBF_UL_ASS_EV_SCHED_ASS_REJ:</span><br><span style="color: hsl(120, 100%, 40%);">+ tbf_ul_ass_fsm_state_chg(fi, TBF_UL_ASS_SEND_ASS_REJ);</span><br><span style="color: hsl(120, 100%, 40%);">+ break;</span><br><span style="color: hsl(120, 100%, 40%);">+ default:</span><br><span style="color: hsl(120, 100%, 40%);">+ OSMO_ASSERT(0);</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+static void st_send_ass(struct osmo_fsm_inst *fi, uint32_t event, void *data)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+ struct tbf_ul_ass_fsm_ctx *ctx = (struct tbf_ul_ass_fsm_ctx *)fi->priv;</span><br><span style="color: hsl(120, 100%, 40%);">+ switch (event) {</span><br><span style="color: hsl(120, 100%, 40%);">+ case TBF_UL_ASS_EV_CREATE_RLCMAC_MSG:</span><br><span style="color: hsl(120, 100%, 40%);">+ break;</span><br><span style="color: hsl(120, 100%, 40%);">+ default:</span><br><span style="color: hsl(120, 100%, 40%);">+ OSMO_ASSERT(0);</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+static void st_send_ass_rej(struct osmo_fsm_inst *fi, uint32_t event, void *data)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+ struct tbf_ul_ass_fsm_ctx *ctx = (struct tbf_ul_ass_fsm_ctx *)fi->priv;</span><br><span style="color: hsl(120, 100%, 40%);">+ switch (event) {</span><br><span style="color: hsl(120, 100%, 40%);">+ case TBF_UL_ASS_EV_CREATE_RLCMAC_MSG:</span><br><span style="color: hsl(120, 100%, 40%);">+ data_ctx = (struct ms_anr_ev_create_rlcmac_msg_ctx *)data;</span><br><span style="color: hsl(120, 100%, 40%);">+ *data = create_packet_access_reject(ctx);</span><br><span style="color: hsl(120, 100%, 40%);">+ if (!*data)</span><br><span style="color: hsl(120, 100%, 40%);">+ return;</span><br><span style="color: hsl(120, 100%, 40%);">+ tbf_ul_ass_fsm_state_chg(fi, TBF_UL_ASS_NONE);</span><br><span style="color: hsl(120, 100%, 40%);">+ break;</span><br><span style="color: hsl(120, 100%, 40%);">+ default:</span><br><span style="color: hsl(120, 100%, 40%);">+ OSMO_ASSERT(0);</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+static void st_wait_ack(struct osmo_fsm_inst *fi, uint32_t event, void *data)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+ struct tbf_ul_ass_fsm_ctx *ctx = (struct tbf_ul_ass_fsm_ctx *)fi->priv;</span><br><span style="color: hsl(120, 100%, 40%);">+ switch (event) {</span><br><span style="color: hsl(120, 100%, 40%);">+ default:</span><br><span style="color: hsl(120, 100%, 40%);">+ OSMO_ASSERT(0);</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+static void tbf_ul_ass_fsm_cleanup(struct osmo_fsm_inst *fi, enum osmo_fsm_term_cause cause)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+ /* TODO: needed ?</span><br><span style="color: hsl(120, 100%, 40%);">+ * struct tbf_ul_ass_fsm_ctx *ctx = (struct tbf_ul_ass_fsm_ctx *)fi->priv;</span><br><span style="color: hsl(120, 100%, 40%);">+ */</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+static int tbf_ul_ass_fsm_timer_cb(struct osmo_fsm_inst *fi)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+ struct tbf_ul_ass_fsm_ctx *ctx = (struct tbf_ul_ass_fsm_ctx *)fi->priv;</span><br><span style="color: hsl(120, 100%, 40%);">+ switch (fi->T) {</span><br><span style="color: hsl(120, 100%, 40%);">+ default:</span><br><span style="color: hsl(120, 100%, 40%);">+ OSMO_ASSERT(0);</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ return 0;</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+static struct osmo_fsm_state tbf_ul_ass_fsm_states[] = {</span><br><span style="color: hsl(120, 100%, 40%);">+ [TBF_UL_ASS_NONE] = {</span><br><span style="color: hsl(120, 100%, 40%);">+ .in_event_mask =</span><br><span style="color: hsl(120, 100%, 40%);">+ X(TBF_UL_ASS_EV_SCHED_ASS) |</span><br><span style="color: hsl(120, 100%, 40%);">+ X(TBF_UL_ASS_EV_SCHED_ASS_REJ),</span><br><span style="color: hsl(120, 100%, 40%);">+ .out_state_mask =</span><br><span style="color: hsl(120, 100%, 40%);">+ X(TBF_UL_ASS_SEND_ASS) |</span><br><span style="color: hsl(120, 100%, 40%);">+ X(TBF_UL_ASS_SEND_ASS_REJ),</span><br><span style="color: hsl(120, 100%, 40%);">+ .name = "NONE",</span><br><span style="color: hsl(120, 100%, 40%);">+ .action = st_none,</span><br><span style="color: hsl(120, 100%, 40%);">+ },</span><br><span style="color: hsl(120, 100%, 40%);">+ [TBF_UL_ASS_SEND_ASS] = {</span><br><span style="color: hsl(120, 100%, 40%);">+ .in_event_mask = X(TBF_UL_ASS_EV_CREATE_RLCMAC_MSG),</span><br><span style="color: hsl(120, 100%, 40%);">+ .out_state_mask = X(TBF_UL_ASS_WAIT_ACK),</span><br><span style="color: hsl(120, 100%, 40%);">+ .name = "SEND_ASS",</span><br><span style="color: hsl(120, 100%, 40%);">+ //.onenter = st_assign_on_enter,</span><br><span style="color: hsl(120, 100%, 40%);">+ .action = st_send_ass,</span><br><span style="color: hsl(120, 100%, 40%);">+ },</span><br><span style="color: hsl(120, 100%, 40%);">+ [TBF_UL_ASS_SEND_ASS_REJ] = {</span><br><span style="color: hsl(120, 100%, 40%);">+ .in_event_mask = X(TBF_UL_ASS_EV_CREATE_RLCMAC_MSG),</span><br><span style="color: hsl(120, 100%, 40%);">+ .out_state_mask = X(TBF_UL_ASS_NONE),</span><br><span style="color: hsl(120, 100%, 40%);">+ .name = "SEND_ASS_REJ",</span><br><span style="color: hsl(120, 100%, 40%);">+ //.onenter = st_flow_on_enter,</span><br><span style="color: hsl(120, 100%, 40%);">+ .action = st_send_ass_rej,</span><br><span style="color: hsl(120, 100%, 40%);">+ },</span><br><span style="color: hsl(120, 100%, 40%);">+ [TBF_UL_ASS_WAIT_ACK] = {</span><br><span style="color: hsl(120, 100%, 40%);">+ .in_event_mask = 0,</span><br><span style="color: hsl(120, 100%, 40%);">+ .out_state_mask = X(TBF_UL_ASS_NONE),</span><br><span style="color: hsl(120, 100%, 40%);">+ .name = "WAIT_ACK",</span><br><span style="color: hsl(120, 100%, 40%);">+ //.onenter = st_finished_on_enter,</span><br><span style="color: hsl(120, 100%, 40%);">+ .action = st_wait_ack,</span><br><span style="color: hsl(120, 100%, 40%);">+ },</span><br><span style="color: hsl(120, 100%, 40%);">+};</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+/*void tbf_ul_ass_fsm_allstate_action(struct osmo_fsm_inst *fi, uint32_t event, void *data)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+ struct tbf_ul_ass_fsm_ctx *ctx = (struct tbf_ul_ass_fsm_ctx *)fi->priv;</span><br><span style="color: hsl(120, 100%, 40%);">+ switch (event) {</span><br><span style="color: hsl(120, 100%, 40%);">+ case TBF_EV_ASSIGN_DEL_CCCH:</span><br><span style="color: hsl(120, 100%, 40%);">+ mod_ass_type(ctx, GPRS_RLCMAC_FLAG_CCCH, false);</span><br><span style="color: hsl(120, 100%, 40%);">+ break;</span><br><span style="color: hsl(120, 100%, 40%);">+ default:</span><br><span style="color: hsl(120, 100%, 40%);">+ OSMO_ASSERT(0);</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+}*/</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+struct osmo_fsm tbf_ul_ass_fsm = {</span><br><span style="color: hsl(120, 100%, 40%);">+ .name = "UL_ASS_TBF",</span><br><span style="color: hsl(120, 100%, 40%);">+ .states = tbf_ul_ass_fsm_states,</span><br><span style="color: hsl(120, 100%, 40%);">+ .num_states = ARRAY_SIZE(tbf_ul_ass_fsm_states),</span><br><span style="color: hsl(120, 100%, 40%);">+ .timer_cb = tbf_ul_ass_fsm_timer_cb,</span><br><span style="color: hsl(120, 100%, 40%);">+ .cleanup = tbf_ul_ass_fsm_cleanup,</span><br><span style="color: hsl(120, 100%, 40%);">+ .log_subsys = DTBF,</span><br><span style="color: hsl(120, 100%, 40%);">+ .event_names = tbf_ul_ass_fsm_event_names,</span><br><span style="color: hsl(120, 100%, 40%);">+ //.allstate_action = tbf_ul_ass_fsm_allstate_action,</span><br><span style="color: hsl(120, 100%, 40%);">+ //.allstate_event_mask = 0,</span><br><span style="color: hsl(120, 100%, 40%);">+};</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+static __attribute__((constructor)) void tbf_ul_ass_fsm_init(void)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+ OSMO_ASSERT(osmo_fsm_register(&tbf_ul_ass_fsm) == 0);</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+struct msgb *tbf_ul_ass_create_rlcmac_msg(const struct gprs_rlcmac_tbf* tbf)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+ int rc;</span><br><span style="color: hsl(120, 100%, 40%);">+ struct msgb *msg = NULL;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ rc = osmo_fsm_inst_dispatch(tbf->ul_ass_fsm.fi, TBF_UL_ASS_EV_CREATE_RLCMAC_MSG, &msg);</span><br><span style="color: hsl(120, 100%, 40%);">+ if (rc != 0 || !msg)</span><br><span style="color: hsl(120, 100%, 40%);">+ return NULL;</span><br><span style="color: hsl(120, 100%, 40%);">+ return msg;</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span>diff --git a/src/tbf_ul_ass_fsm.h b/src/tbf_ul_ass_fsm.h</span><br><span>new file mode 100644</span><br><span>index 0000000..9aa84fc</span><br><span>--- /dev/null</span><br><span>+++ b/src/tbf_ul_ass_fsm.h</span><br><span>@@ -0,0 +1,65 @@</span><br><span style="color: hsl(120, 100%, 40%);">+/* tbf_ul_ass_fsm.h</span><br><span style="color: hsl(120, 100%, 40%);">+ *</span><br><span style="color: hsl(120, 100%, 40%);">+ * Copyright (C) 2021 by sysmocom - s.f.m.c. GmbH <info@sysmocom.de></span><br><span style="color: hsl(120, 100%, 40%);">+ * Author: Pau Espin Pedrol <pespin@sysmocom.de></span><br><span style="color: hsl(120, 100%, 40%);">+ *</span><br><span style="color: hsl(120, 100%, 40%);">+ * This program is free software; you can redistribute it and/or</span><br><span style="color: hsl(120, 100%, 40%);">+ * modify it under the terms of the GNU General Public License</span><br><span style="color: hsl(120, 100%, 40%);">+ * as published by the Free Software Foundation; either version 2</span><br><span style="color: hsl(120, 100%, 40%);">+ * of the License, or (at your option) any later version.</span><br><span style="color: hsl(120, 100%, 40%);">+ *</span><br><span style="color: hsl(120, 100%, 40%);">+ * This program is distributed in the hope that it will be useful,</span><br><span style="color: hsl(120, 100%, 40%);">+ * but WITHOUT ANY WARRANTY; without even the implied warranty of</span><br><span style="color: hsl(120, 100%, 40%);">+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the</span><br><span style="color: hsl(120, 100%, 40%);">+ * GNU General Public License for more details.</span><br><span style="color: hsl(120, 100%, 40%);">+ *</span><br><span style="color: hsl(120, 100%, 40%);">+ * You should have received a copy of the GNU General Public License</span><br><span style="color: hsl(120, 100%, 40%);">+ * along with this program; if not, write to the Free Software</span><br><span style="color: hsl(120, 100%, 40%);">+ * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA.</span><br><span style="color: hsl(120, 100%, 40%);">+ */</span><br><span style="color: hsl(120, 100%, 40%);">+#pragma once</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+#include <osmocom/core/fsm.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <osmocom/core/tdef.h></span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+#include <gprs_pcu.h></span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+struct gprs_rlcmac_ul_tbf;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+enum tbf_ul_ass_fsm_event {</span><br><span style="color: hsl(120, 100%, 40%);">+ TBF_UL_ASS_EV_SCHED_ASS, /* Tx Uplink Assignment is pending */</span><br><span style="color: hsl(120, 100%, 40%);">+ TBF_UL_ASS_EV_SCHED_ASS_REJ, /* Tx Uplink Assignment is pending */</span><br><span style="color: hsl(120, 100%, 40%);">+ TBF_UL_ASS_EV_CREATE_RLCMAC_MSG, /* SCheduler wants to schedule a rlcmac msg from us */</span><br><span style="color: hsl(120, 100%, 40%);">+};</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+enum tbf_ul_ass_fsm_states {</span><br><span style="color: hsl(120, 100%, 40%);">+ TBF_UL_ASS_NONE = 0,</span><br><span style="color: hsl(120, 100%, 40%);">+ TBF_UL_ASS_SEND_ASS, /* send uplink assignment on next RTS */</span><br><span style="color: hsl(120, 100%, 40%);">+ TBF_UL_ASS_SEND_ASS_REJ, /* send assignment reject next RTS */</span><br><span style="color: hsl(120, 100%, 40%);">+ TBF_UL_ASS_WAIT_ACK, /* wait for PACKET CONTROL ACK */</span><br><span style="color: hsl(120, 100%, 40%);">+};</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+struct tbf_ul_ass_fsm_ctx {</span><br><span style="color: hsl(120, 100%, 40%);">+ struct osmo_fsm_inst *fi;</span><br><span style="color: hsl(120, 100%, 40%);">+ struct gprs_rlcmac_tbf* tbf; /* back pointer */</span><br><span style="color: hsl(120, 100%, 40%);">+};</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+extern const struct osmo_tdef_state_timeout tbf_ul_ass_fsm_timeouts[32];</span><br><span style="color: hsl(120, 100%, 40%);">+/* Transition to a state, using the T timer defined in assignment_fsm_timeouts.</span><br><span style="color: hsl(120, 100%, 40%);">+ * The actual timeout value is in turn obtained from conn->T_defs.</span><br><span style="color: hsl(120, 100%, 40%);">+ * Assumes local variable fi exists. */</span><br><span style="color: hsl(120, 100%, 40%);">+#define tbf_ul_ass_fsm_state_chg(fi, NEXT_STATE) \</span><br><span style="color: hsl(120, 100%, 40%);">+ osmo_tdef_fsm_inst_state_chg(fi, NEXT_STATE, \</span><br><span style="color: hsl(120, 100%, 40%);">+ tbf_ul_ass_fsm_timeouts, \</span><br><span style="color: hsl(120, 100%, 40%);">+ the_pcu->T_defs, \</span><br><span style="color: hsl(120, 100%, 40%);">+ -1)</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+extern struct osmo_fsm tbf_ul_ass_fsm;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+struct msgb *tbf_ul_ass_create_rlcmac_msg_rej(const struct gprs_rlcmac_tbf* tbf);</span><br><span style="color: hsl(120, 100%, 40%);">+static inline bool tbf_ul_ass_rts(const struct gprs_rlcmac_tbf* tbf)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+ return tbf->ul_ass_fsm.fi->state == TBF_UL_ASS_SEND_ASS ||</span><br><span style="color: hsl(120, 100%, 40%);">+ tbf->ul_ass_fsm.fi->state == TBF_UL_ASS_SEND_ASS_REJ;</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-pcu/+/25056">change 25056</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-pcu/+/25056"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-pcu </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Id414eafe9c04a9a8759c6fb1a483bf2ee093a4d2 </div>
<div style="display:none"> Gerrit-Change-Number: 25056 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-CC: Jenkins Builder </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>