<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25015">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  laforge: Looks good to me, approved
  pespin: Looks good to me, but someone else must approve
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">bsc: f_expect_dlcx_conns(): do not rx Clear Complete<br><br>The function f_expect_dlcx_conns() is clearly related to MGCP, and<br>semantically should not interfere with BSSAP by also receiving the Clear<br>Complete.<br><br>For some tests, this incidentally makes sense, but an upcoming test<br>failed in a non-obvious way because of this.<br><br>Related: SYS#5130<br>Change-Id: I637414f4db8ea7c4b59aaee205d65926574b5ccd<br>---<br>M bsc/BSC_Tests.ttcn<br>1 file changed, 10 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn</span><br><span>index 2012346..dc3df66 100644</span><br><span>--- a/bsc/BSC_Tests.ttcn</span><br><span>+++ b/bsc/BSC_Tests.ttcn</span><br><span>@@ -5106,8 +5106,6 @@</span><br><span>                   MGCP_MULTI.send(t_MGCP_SendToMrf(mrf, msg_resp));</span><br><span>            };</span><br><span>   }</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-       BSSAP.receive(tr_BSSMAP_ClearComplete);</span><br><span> }</span><br><span> </span><br><span> private function f_ho_out_of_this_bsc(template (omit) BSSMAP_oldToNewBSSIEs exp_oldToNewBSSIEs := omit) runs on MSC_ConnHdlr {</span><br><span>@@ -5160,6 +5158,7 @@</span><br><span>   [] RSL.receive(tr_RSL_DATA_REQ(g_chan_nr, ?, decmatch tr_RRM_RR_RELEASE));</span><br><span>   [] RSL.receive(tr_RSL_DEACT_SACCH(g_chan_nr));</span><br><span>       [] RSL.receive(tr_RSL_RF_CHAN_REL(g_chan_nr));</span><br><span style="color: hsl(120, 100%, 40%);">+        [] BSSAP.receive(tr_BSSMAP_ClearComplete);</span><br><span>   }</span><br><span>    setverdict(pass);</span><br><span> }</span><br><span>@@ -5433,6 +5432,7 @@</span><br><span>       }</span><br><span> </span><br><span>        f_expect_dlcx_conns();</span><br><span style="color: hsl(120, 100%, 40%);">+        BSSAP.receive(tr_BSSMAP_ClearComplete);</span><br><span> </span><br><span>  setverdict(pass);</span><br><span>    f_sleep(1.0);</span><br><span>@@ -5743,6 +5743,8 @@</span><br><span>        BSSAP.send(ts_BSSMAP_ClearCommand(cause));</span><br><span> </span><br><span>       f_expect_dlcx_conns();</span><br><span style="color: hsl(120, 100%, 40%);">+        BSSAP.receive(tr_BSSMAP_ClearComplete);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>    setverdict(pass);</span><br><span>    f_sleep(1.0);</span><br><span> </span><br><span>@@ -5834,6 +5836,8 @@</span><br><span>    BSSAP.send(ts_BSSMAP_ClearCommand(cause));</span><br><span> </span><br><span>       f_expect_dlcx_conns();</span><br><span style="color: hsl(120, 100%, 40%);">+        BSSAP.receive(tr_BSSMAP_ClearComplete);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>    f_sleep(1.0);</span><br><span> }</span><br><span> testcase TC_ho_in_fail_msc_clears_after_ho_detect() runs on test_CT {</span><br><span>@@ -5921,6 +5925,8 @@</span><br><span>  BSSAP.send(ts_BSSMAP_ClearCommand(cause));</span><br><span> </span><br><span>       f_expect_dlcx_conns();</span><br><span style="color: hsl(120, 100%, 40%);">+        BSSAP.receive(tr_BSSMAP_ClearComplete);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>    f_sleep(1.0);</span><br><span> }</span><br><span> testcase TC_ho_in_fail_no_detect() runs on test_CT {</span><br><span>@@ -6000,6 +6006,8 @@</span><br><span>           BSSAP.send(ts_BSSMAP_ClearCommand(cause));</span><br><span>   };</span><br><span>   f_expect_dlcx_conns();</span><br><span style="color: hsl(120, 100%, 40%);">+        BSSAP.receive(tr_BSSMAP_ClearComplete);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>    f_sleep(1.0);</span><br><span> }</span><br><span> testcase TC_ho_in_fail_no_detect2() runs on test_CT {</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25015">change 25015</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25015"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I637414f4db8ea7c4b59aaee205d65926574b5ccd </div>
<div style="display:none"> Gerrit-Change-Number: 25015 </div>
<div style="display:none"> Gerrit-PatchSet: 4 </div>
<div style="display:none"> Gerrit-Owner: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>