<p>pespin has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/25043">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">gb/bssgp: Abort clearly if backward-compat API is used wrongly<br><br>Some tests under osmo-pcu (TbfTest) were caught accessning NULL pointer<br>bssgp_nsi in bssgp_tx_llc_discarded triggered by timeout while stepping<br>slowly with the debugger.<br><br>It seems that test is not properly using neither the old nor the new<br>API. Let's catch such cases easily.<br><br>Change-Id: I3ea42755c4bfd29e4a01ad57f186f28d58ab466a<br>---<br>M src/gb/gprs_bssgp.c<br>1 file changed, 1 insertion(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/43/25043/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/gb/gprs_bssgp.c b/src/gb/gprs_bssgp.c</span><br><span>index 14a5e9d..c967f73 100644</span><br><span>--- a/src/gb/gprs_bssgp.c</span><br><span>+++ b/src/gb/gprs_bssgp.c</span><br><span>@@ -77,6 +77,7 @@</span><br><span> /* callback to be backward compatible with old users which do not set the bssgp_ns_send function */</span><br><span> static int _gprs_ns_sendmsg(void *ctx, struct msgb *msg)</span><br><span> {</span><br><span style="color: hsl(120, 100%, 40%);">+       OSMO_ASSERT(bssgp_nsi);</span><br><span>      return gprs_ns_sendmsg(bssgp_nsi, msg);</span><br><span> }</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/25043">change 25043</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/25043"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I3ea42755c4bfd29e4a01ad57f186f28d58ab466a </div>
<div style="display:none"> Gerrit-Change-Number: 25043 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>