<p>pespin has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-pcu/+/25049">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Drop duplicate log line<br><br>Same line (or similar if run_diag) is logged immediately below, showing<br>up twice in log which is confusing:<br><br>"""<br>20210726171543005 DTBF tbf.cpp:455 TBF(TFI=2 TLLI=0xfe563576 DIR=DL STATE=WAIT_RELEASE EGPRS) T3193 timeout expired, freeing TBF<br>20210726171543005 DTBF tbf.cpp:462 TBF(TFI=2 TLLI=0xfe563576 DIR=DL STATE=WAIT_RELEASE EGPRS) T3193 timeout expired, freeing TBF<br>"""<br><br>Change-Id: Ie171c458e670f8471ac93f78520a05926114c974<br>---<br>M src/tbf.cpp<br>1 file changed, 0 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/49/25049/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/tbf.cpp b/src/tbf.cpp</span><br><span>index e3b171b..2529eaa 100644</span><br><span>--- a/src/tbf.cpp</span><br><span>+++ b/src/tbf.cpp</span><br><span>@@ -452,9 +452,6 @@</span><br><span> </span><br><span> static inline void tbf_timeout_free(struct gprs_rlcmac_tbf *tbf, enum tbf_timers t, bool run_diag)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">-      LOGPTBF(tbf, LOGL_NOTICE, "%s timeout expired, freeing TBF\n",</span><br><span style="color: hsl(0, 100%, 40%);">-                get_value_string(tbf_timers_names, t));</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span>      if (run_diag) {</span><br><span>              LOGPTBF(tbf, LOGL_NOTICE, "%s timeout expired, freeing TBF: %s\n",</span><br><span>                         get_value_string(tbf_timers_names, t), tbf->rlcmac_diag().c_str());</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-pcu/+/25049">change 25049</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-pcu/+/25049"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-pcu </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ie171c458e670f8471ac93f78520a05926114c974 </div>
<div style="display:none"> Gerrit-Change-Number: 25049 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>