<p>neels has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25018">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">bsc: expect proper chan_nr for various RSL_MT_RF_CHAN_REL<br><br>So far we were often just expecting the message type. Instead expect a<br>release on the proper channel number.<br><br>While hunting a test error, this confused me for a while, because a<br>missing handler resulted in the release message handled in the wrong<br>place, even though the chan_nr mismatched.<br><br>Related: SYS#5130<br>Change-Id: I002c9273a387104bea062dec8879b4e19a72008d<br>---<br>M bsc/BSC_Tests.ttcn<br>1 file changed, 7 insertions(+), 7 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/18/25018/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn</span><br><span>index 5ab3cc7..4d3acc2 100644</span><br><span>--- a/bsc/BSC_Tests.ttcn</span><br><span>+++ b/bsc/BSC_Tests.ttcn</span><br><span>@@ -4937,12 +4937,12 @@</span><br><span>   interleave {</span><br><span>         [] RSL.receive(tr_RSL_DATA_REQ(g_chan_nr, ?, decmatch tr_RRM_RR_RELEASE(int2oct(enum2int(rr_cause), 1)))) {}</span><br><span>         [] RSL.receive(tr_RSL_DEACT_SACCH(g_chan_nr)) {}</span><br><span style="color: hsl(0, 100%, 40%);">-        [] RSL.receive(tr_RSL_MsgTypeD(RSL_MT_RF_CHAN_REL)) {</span><br><span style="color: hsl(120, 100%, 40%);">+ [] RSL.receive(tr_RSL_RF_CHAN_REL(g_chan_nr)) {</span><br><span>                      RSL.send(ts_RSL_RF_CHAN_REL_ACK(g_chan_nr));</span><br><span>                         f_rslem_unregister(0, g_chan_nr);</span><br><span>            }</span><br><span>    [] RSL1.receive(tr_RSL_DEACT_SACCH(new_chan_nr)) {}</span><br><span style="color: hsl(0, 100%, 40%);">-     [] RSL1.receive(tr_RSL_MsgTypeD(RSL_MT_RF_CHAN_REL)) {</span><br><span style="color: hsl(120, 100%, 40%);">+        [] RSL1.receive(tr_RSL_RF_CHAN_REL(new_chan_nr)) {</span><br><span>                   RSL1.send(ts_RSL_RF_CHAN_REL_ACK(new_chan_nr));</span><br><span>                      f_rslem_unregister(0, g_chan_nr, PT := RSL1_PROC);</span><br><span>           }</span><br><span>@@ -5322,7 +5322,7 @@</span><br><span>    [] RSL.receive(tr_RSL_DATA_REQ(g_chan_nr, ?, decmatch tr_RRM_RR_RELEASE)) {</span><br><span>                  log("Got RR Release");</span><br><span>             }</span><br><span style="color: hsl(0, 100%, 40%);">-       [] RSL.receive(tr_RSL_MsgTypeD(RSL_MT_RF_CHAN_REL)) {</span><br><span style="color: hsl(120, 100%, 40%);">+ [] RSL.receive(tr_RSL_RF_CHAN_REL(g_chan_nr)) {</span><br><span>                      log("Got RF Chan Rel");</span><br><span>                    RSL.send(ts_RSL_RF_CHAN_REL_ACK(g_chan_nr));</span><br><span>                         f_rslem_unregister(0, g_chan_nr);</span><br><span>@@ -7121,7 +7121,7 @@</span><br><span>    [] rsl_pt.receive(tr_RSL_DEACT_SACCH(g_chan_nr)) {</span><br><span>                   f_logp(BSCVTY, "Got RSL Deact SACCH");</span><br><span>             }</span><br><span style="color: hsl(0, 100%, 40%);">-       [] rsl_pt.receive(tr_RSL_MsgTypeD(RSL_MT_RF_CHAN_REL)) {</span><br><span style="color: hsl(120, 100%, 40%);">+      [] rsl_pt.receive(tr_RSL_RF_CHAN_REL(g_chan_nr)) {</span><br><span>                   f_logp(BSCVTY, "Got RSL RF Chan Rel, sending Rel Ack");</span><br><span>                    rsl_pt.send(ts_RSL_RF_CHAN_REL_ACK(g_chan_nr));</span><br><span>                      f_rslem_unregister(0, g_chan_nr, PT := rsl_proc_pt);</span><br><span>@@ -7147,7 +7147,7 @@</span><br><span>                         /* Also drop the SCCP connection */</span><br><span>                  BSSAP.send(RAN_Conn_Prim:MSC_CONN_PRIM_DISC_REQ);</span><br><span>            }</span><br><span style="color: hsl(0, 100%, 40%);">-       [] rsl_pt.receive(tr_RSL_MsgTypeD(RSL_MT_RF_CHAN_REL)) {</span><br><span style="color: hsl(120, 100%, 40%);">+      [] rsl_pt.receive(tr_RSL_RF_CHAN_REL(g_chan_nr)) {</span><br><span>                   f_logp(BSCVTY, "Got RSL RF Chan Rel, sending Rel Ack");</span><br><span>                    rsl_pt.send(ts_RSL_RF_CHAN_REL_ACK(g_chan_nr));</span><br><span>                      f_rslem_unregister(0, g_chan_nr, PT := rsl_proc_pt);</span><br><span>@@ -9094,7 +9094,7 @@</span><br><span>         [] RSL.receive(tr_RSL_DEACT_SACCH(g_chan_nr)) {</span><br><span>                      f_logp(BSCVTY, "Got RSL Deact SACCH");</span><br><span>             }</span><br><span style="color: hsl(0, 100%, 40%);">-       [] RSL.receive(tr_RSL_MsgTypeD(RSL_MT_RF_CHAN_REL)) {</span><br><span style="color: hsl(120, 100%, 40%);">+ [] RSL.receive(tr_RSL_RF_CHAN_REL(g_chan_nr)) {</span><br><span>                      f_logp(BSCVTY, "Got RSL RF Chan Rel, sending Rel Ack");</span><br><span>                    RSL.send(ts_RSL_RF_CHAN_REL_ACK(g_chan_nr));</span><br><span>                         f_rslem_unregister(0, g_chan_nr);</span><br><span>@@ -9272,7 +9272,7 @@</span><br><span>    [] MGCP.receive(tr_DLCX) {}</span><br><span>  [] RSL.receive(tr_RSL_DATA_REQ(g_chan_nr, ?, decmatch tr_RRM_RR_RELEASE)) {}</span><br><span>         [] RSL.receive(tr_RSL_DEACT_SACCH(g_chan_nr)) {}</span><br><span style="color: hsl(0, 100%, 40%);">-        [] RSL.receive(tr_RSL_MsgTypeD(RSL_MT_RF_CHAN_REL)) {</span><br><span style="color: hsl(120, 100%, 40%);">+ [] RSL.receive(tr_RSL_RF_CHAN_REL(g_chan_nr)) {</span><br><span>                      RSL.send(ts_RSL_RF_CHAN_REL_ACK(g_chan_nr));</span><br><span>                         f_rslem_unregister(0, g_chan_nr);</span><br><span>            }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25018">change 25018</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25018"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I002c9273a387104bea062dec8879b4e19a72008d </div>
<div style="display:none"> Gerrit-Change-Number: 25018 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>