<p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/25006">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/25006/2/src/osmo-bsc/abis_rsl.c">File src/osmo-bsc/abis_rsl.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/25006/2/src/osmo-bsc/abis_rsl.c@2028">Patch Set #2, Line 2028:</a> <code style="font-family:monospace,monospace">             }</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">I think it would be useful to log if one of the new conditions are hit that cause it not to get an lchan. Maybe like this?</p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">  if (!lchan) {<br>    if (!gsm_chreq_reason_is_voicecall(rqd->reason)) {<br>       /* log message */<br>    } else if (!bts->chan_alloc_allow_tch_for_signalling) {<br>       /* log message */<br>    } else {<br>      /* try tch_h */<br>      if (!lchan)<br>        /* try tch_f */<br>  }</pre></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/25006">change 25006</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/25006"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ib08027125145df26602069bfb51847063b0ccc0c </div>
<div style="display:none"> Gerrit-Change-Number: 25006 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-CC: osmith <osmith@sysmocom.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 22 Jul 2021 15:58:34 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Gerrit-MessageType: comment </div>