<p>dexter has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-mgw/+/25004">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mcgp_client: initalize domain name from mgcp_client_conf_init<br><br>Te function mgcp_client_conf_init initalizes an mgcp client<br>configuration struct with some default values but it does not initalize<br>the buffer for the mgw domain name. If the configuration is not<br>initalized with zeros by the API user in some way, the endpoint domain<br>name buffer still might contain random data, even after<br>calling mgcp_client_conf_init().<br><br>Change-Id: Iabef17c7ab0e0f4a9a0cb3ad4ec83006bd07f566<br>---<br>M src/libosmo-mgcp-client/mgcp_client.c<br>1 file changed, 3 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/04/25004/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/libosmo-mgcp-client/mgcp_client.c b/src/libosmo-mgcp-client/mgcp_client.c</span><br><span>index 9d60ee8..7a7dcb5 100644</span><br><span>--- a/src/libosmo-mgcp-client/mgcp_client.c</span><br><span>+++ b/src/libosmo-mgcp-client/mgcp_client.c</span><br><span>@@ -201,6 +201,9 @@</span><br><span>            .remote_addr = NULL,</span><br><span>                 .remote_port = -1,</span><br><span>   };</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+  /* See also function mgcp_client_endpoint_domain() */</span><br><span style="color: hsl(120, 100%, 40%);">+ memset(conf->endpoint_domain_name, 0, sizeof(conf->endpoint_domain_name));</span><br><span> }</span><br><span> </span><br><span> static void mgcp_client_handle_response(struct mgcp_client *mgcp,</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-mgw/+/25004">change 25004</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-mgw/+/25004"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-mgw </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Iabef17c7ab0e0f4a9a0cb3ad4ec83006bd07f566 </div>
<div style="display:none"> Gerrit-Change-Number: 25004 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>