<p>daniel has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-gbproxy/+/24964">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">gbproxy_ctrl: Fix crash in nsvc-state ctrl command<br><br>ctrl_nsvc_state_cb() expects us to pass a struct nsvc_cb_data so do that<br>instead of passing only the ctrl_cmd.<br><br>Related: OS#5200, SYS#5542<br>Change-Id: I8bc67cc9bc90dab9cfca30b062d1d78897aa1e51<br>---<br>M src/gb_proxy_ctrl.c<br>1 file changed, 16 insertions(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-gbproxy refs/changes/64/24964/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/gb_proxy_ctrl.c b/src/gb_proxy_ctrl.c</span><br><span>index 35ef81b..99dcbe1 100644</span><br><span>--- a/src/gb_proxy_ctrl.c</span><br><span>+++ b/src/gb_proxy_ctrl.c</span><br><span>@@ -64,15 +64,27 @@</span><br><span>     /* NS-VCs for SGSN */</span><br><span>        hash_for_each(cfg->sgsn_nses, i, nse_peer, list) {</span><br><span>                nse = gprs_ns2_nse_by_nsei(nsi, nse_peer->nsei);</span><br><span style="color: hsl(0, 100%, 40%);">-             if (nse)</span><br><span style="color: hsl(0, 100%, 40%);">-                        gprs_ns2_nse_foreach_nsvc(nse, &ctrl_nsvc_state_cb, cmd);</span><br><span style="color: hsl(120, 100%, 40%);">+         if (nse) {</span><br><span style="color: hsl(120, 100%, 40%);">+                    struct nsvc_cb_data cb_data = {</span><br><span style="color: hsl(120, 100%, 40%);">+                               .cmd = cmd,</span><br><span style="color: hsl(120, 100%, 40%);">+                           .nsei = nse_peer->nsei,</span><br><span style="color: hsl(120, 100%, 40%);">+                            .is_sgsn = true,</span><br><span style="color: hsl(120, 100%, 40%);">+                      };</span><br><span style="color: hsl(120, 100%, 40%);">+                    gprs_ns2_nse_foreach_nsvc(nse, &ctrl_nsvc_state_cb, &cb_data);</span><br><span style="color: hsl(120, 100%, 40%);">+                }</span><br><span>    }</span><br><span> </span><br><span>        /* NS-VCs for BSS peers */</span><br><span>   hash_for_each(cfg->bss_nses, i, nse_peer, list) {</span><br><span>                 nse = gprs_ns2_nse_by_nsei(nsi, nse_peer->nsei);</span><br><span style="color: hsl(0, 100%, 40%);">-             if (nse)</span><br><span style="color: hsl(0, 100%, 40%);">-                        gprs_ns2_nse_foreach_nsvc(nse, &ctrl_nsvc_state_cb, cmd);</span><br><span style="color: hsl(120, 100%, 40%);">+         if (nse) {</span><br><span style="color: hsl(120, 100%, 40%);">+                    struct nsvc_cb_data cb_data = {</span><br><span style="color: hsl(120, 100%, 40%);">+                               .cmd = cmd,</span><br><span style="color: hsl(120, 100%, 40%);">+                           .nsei = nse_peer->nsei,</span><br><span style="color: hsl(120, 100%, 40%);">+                            .is_sgsn = true,</span><br><span style="color: hsl(120, 100%, 40%);">+                      };</span><br><span style="color: hsl(120, 100%, 40%);">+                    gprs_ns2_nse_foreach_nsvc(nse, &ctrl_nsvc_state_cb, &cb_data);</span><br><span style="color: hsl(120, 100%, 40%);">+                }</span><br><span>    }</span><br><span> </span><br><span>        return CTRL_CMD_REPLY;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-gbproxy/+/24964">change 24964</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-gbproxy/+/24964"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-gbproxy </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I8bc67cc9bc90dab9cfca30b062d1d78897aa1e51 </div>
<div style="display:none"> Gerrit-Change-Number: 24964 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: daniel <dwillmann@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>