<p>daniel has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-gbproxy/+/24965">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">gbproxy_ctrl: Ignore SIG-BVCI in ctrl commands<br><br>Both ctrl commands gbproxy-state and number-of-peers should only<br>operate on PtP-BVCs. This patch avoids a crash in gbproxy-state and<br>fixes the count of number-of-peers to only include PtP-BVCs.<br><br>Related: SYS#5542, OS#5200<br>Change-Id: Ida5f9ad0a16b991e77eec0e3cdb779dcfa472fab<br>---<br>M src/gb_proxy_ctrl.c<br>1 file changed, 7 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-gbproxy refs/changes/65/24965/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/gb_proxy_ctrl.c b/src/gb_proxy_ctrl.c</span><br><span>index 99dcbe1..1d51d22 100644</span><br><span>--- a/src/gb_proxy_ctrl.c</span><br><span>+++ b/src/gb_proxy_ctrl.c</span><br><span>@@ -103,6 +103,9 @@</span><br><span>       hash_for_each(cfg->bss_nses, i, nse_peer, list) {</span><br><span>                 struct gbproxy_bvc *bvc;</span><br><span>             hash_for_each(nse_peer->bvcs, j, bvc, list) {</span><br><span style="color: hsl(120, 100%, 40%);">+                      if (bvc->bvci == 0)</span><br><span style="color: hsl(120, 100%, 40%);">+                                continue;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>                  struct gprs_ra_id *raid = &bvc->cell->id.raid;</span><br><span> </span><br><span>                         cmd->reply = talloc_asprintf_append(cmd->reply, "%u,%u,%u-%u-%u-%u,%s\n",</span><br><span>@@ -127,8 +130,11 @@</span><br><span>     int i, j;</span><br><span> </span><br><span>        hash_for_each(cfg->bss_nses, i, nse_peer, list) {</span><br><span style="color: hsl(0, 100%, 40%);">-            hash_for_each(nse_peer->bvcs, j, bvc, list)</span><br><span style="color: hsl(120, 100%, 40%);">+                hash_for_each(nse_peer->bvcs, j, bvc, list) {</span><br><span style="color: hsl(120, 100%, 40%);">+                      if (bvc->bvci == 0)</span><br><span style="color: hsl(120, 100%, 40%);">+                                continue;</span><br><span>                    count++;</span><br><span style="color: hsl(120, 100%, 40%);">+              }</span><br><span>    }</span><br><span> </span><br><span>        cmd->reply = talloc_strdup(cmd, "");</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-gbproxy/+/24965">change 24965</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-gbproxy/+/24965"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-gbproxy </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ida5f9ad0a16b991e77eec0e3cdb779dcfa472fab </div>
<div style="display:none"> Gerrit-Change-Number: 24965 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: daniel <dwillmann@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>