<p>dexter <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/24513">View Change</a></p><div style="white-space:pre-wrap">Approvals:
Jenkins Builder: Verified
pespin: Looks good to me, approved
laforge: Looks good to me, but someone else must approve
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">allow to configure multiple oml remote-ip addresses<br><br>At the moment we can only configure a single BSC in the BTS<br>configuration. This also means that if this single BSC fails for some<br>reason the BTS has no alternate BSC to connect to. Lets extend the<br>remote-ip parameter so that it can be used multiple times so that an<br>operater can configure any number of BSCs that are tried one after<br>another during BTS startup.<br><br>Change-Id: I205f68a3a7f35fee4c38a7cfba2b014237df2727<br>Related: SYS#4971<br>---<br>M include/osmo-bts/abis.h<br>M include/osmo-bts/bts.h<br>M src/common/abis.c<br>M src/common/bts.c<br>M src/common/main.c<br>M src/common/vty.c<br>M src/osmo-bts-omldummy/main.c<br>7 files changed, 292 insertions(+), 80 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/include/osmo-bts/abis.h b/include/osmo-bts/abis.h</span><br><span>index 62407ec..8963c3c 100644</span><br><span>--- a/include/osmo-bts/abis.h</span><br><span>+++ b/include/osmo-bts/abis.h</span><br><span>@@ -16,9 +16,14 @@</span><br><span> LINK_STATE_CONNECT,</span><br><span> };</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+enum abis_link_fsm_event {</span><br><span style="color: hsl(120, 100%, 40%);">+ ABIS_LINK_EV_SIGN_LINK_DOWN,</span><br><span style="color: hsl(120, 100%, 40%);">+ ABIS_LINK_EV_VTY_RM_ADDR,</span><br><span style="color: hsl(120, 100%, 40%);">+};</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> void abis_init(struct gsm_bts *bts);</span><br><span style="color: hsl(0, 100%, 40%);">-struct e1inp_line *abis_open(struct gsm_bts *bts, char *dst_host,</span><br><span style="color: hsl(0, 100%, 40%);">- char *model_name);</span><br><span style="color: hsl(120, 100%, 40%);">+int abis_open(struct gsm_bts *bts, char *model_name);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> </span><br><span> </span><br><span> int abis_oml_sendmsg(struct msgb *msg);</span><br><span>diff --git a/include/osmo-bts/bts.h b/include/osmo-bts/bts.h</span><br><span>index 6a61d01..6e0e47b 100644</span><br><span>--- a/include/osmo-bts/bts.h</span><br><span>+++ b/include/osmo-bts/bts.h</span><br><span>@@ -133,6 +133,12 @@</span><br><span> struct gsm_abis_mo mo;</span><br><span> };</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+/* Struct that holds one OML-Address (Address of the BSC) */</span><br><span style="color: hsl(120, 100%, 40%);">+struct bsc_oml_host {</span><br><span style="color: hsl(120, 100%, 40%);">+ struct llist_head list;</span><br><span style="color: hsl(120, 100%, 40%);">+ char *addr;</span><br><span style="color: hsl(120, 100%, 40%);">+};</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> /* One BTS */</span><br><span> struct gsm_bts {</span><br><span> /* list header in net->bts_list */</span><br><span>@@ -295,7 +301,7 @@</span><br><span> } etws;</span><br><span> </span><br><span> struct paging_state *paging_state;</span><br><span style="color: hsl(0, 100%, 40%);">- char *bsc_oml_host;</span><br><span style="color: hsl(120, 100%, 40%);">+ struct llist_head bsc_oml_hosts;</span><br><span> struct llist_head oml_queue;</span><br><span> unsigned int rtp_jitter_buf_ms;</span><br><span> bool rtp_jitter_adaptive;</span><br><span>@@ -363,6 +369,7 @@</span><br><span> } gsmtap;</span><br><span> </span><br><span> struct osmo_fsm_inst *shutdown_fi; /* FSM instance to manage shutdown procedure during process exit */</span><br><span style="color: hsl(120, 100%, 40%);">+ struct osmo_fsm_inst *abis_link_fi; /* FSM instance to manage abis connection during process startup and link failure */</span><br><span> struct osmo_tdef *T_defs; /* Timer defines */</span><br><span> </span><br><span> void *model_priv; /* Allocated by bts_model, contains model specific data pointer */</span><br><span>diff --git a/src/common/abis.c b/src/common/abis.c</span><br><span>index abef826..3325fab 100644</span><br><span>--- a/src/common/abis.c</span><br><span>+++ b/src/common/abis.c</span><br><span>@@ -38,11 +38,13 @@</span><br><span> #include <osmocom/core/msgb.h></span><br><span> #include <osmocom/core/signal.h></span><br><span> #include <osmocom/core/macaddr.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <osmocom/core/fsm.h></span><br><span> #include <osmocom/abis/abis.h></span><br><span> #include <osmocom/abis/e1_input.h></span><br><span> #include <osmocom/abis/ipaccess.h></span><br><span> #include <osmocom/gsm/ipa.h></span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+#include <osmo-bts/abis.h></span><br><span> #include <osmo-bts/logging.h></span><br><span> #include <osmo-bts/gsm_data.h></span><br><span> #include <osmo-bts/bts.h></span><br><span>@@ -54,6 +56,204 @@</span><br><span> </span><br><span> static struct gsm_bts *g_bts;</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+static struct e1inp_line_ops line_ops;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+static struct ipaccess_unit bts_dev_info;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+#define S(x) (1 << (x))</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+enum abis_link_fsm_state {</span><br><span style="color: hsl(120, 100%, 40%);">+ ABIS_LINK_ST_CONNECTING,</span><br><span style="color: hsl(120, 100%, 40%);">+ ABIS_LINK_ST_CONNECTED,</span><br><span style="color: hsl(120, 100%, 40%);">+ ABIS_LINK_ST_FAILED,</span><br><span style="color: hsl(120, 100%, 40%);">+};</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+static const struct value_string abis_link_fsm_event_names[] = {</span><br><span style="color: hsl(120, 100%, 40%);">+ OSMO_VALUE_STRING(ABIS_LINK_EV_SIGN_LINK_DOWN),</span><br><span style="color: hsl(120, 100%, 40%);">+ OSMO_VALUE_STRING(ABIS_LINK_EV_VTY_RM_ADDR),</span><br><span style="color: hsl(120, 100%, 40%);">+ {}</span><br><span style="color: hsl(120, 100%, 40%);">+};</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+struct abis_link_fsm_priv {</span><br><span style="color: hsl(120, 100%, 40%);">+ struct llist_head *bsc_oml_host;</span><br><span style="color: hsl(120, 100%, 40%);">+ struct gsm_bts *bts;</span><br><span style="color: hsl(120, 100%, 40%);">+ char *model_name;</span><br><span style="color: hsl(120, 100%, 40%);">+ int line_ctr;</span><br><span style="color: hsl(120, 100%, 40%);">+};</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+static void abis_link_connected(struct osmo_fsm_inst *fi, uint32_t event, void *data)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+ struct abis_link_fsm_priv *priv = fi->priv;</span><br><span style="color: hsl(120, 100%, 40%);">+ struct gsm_bts *bts = priv->bts;</span><br><span style="color: hsl(120, 100%, 40%);">+ struct gsm_bts_trx *trx;</span><br><span style="color: hsl(120, 100%, 40%);">+ bool oml_rsl_was_connected = false;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ OSMO_ASSERT(event == ABIS_LINK_EV_SIGN_LINK_DOWN);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* First remove the OML signalling link */</span><br><span style="color: hsl(120, 100%, 40%);">+ if (bts->oml_link) {</span><br><span style="color: hsl(120, 100%, 40%);">+ struct timespec now;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ e1inp_sign_link_destroy(bts->oml_link);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Log a special notice if the OML connection was dropped relatively quickly. */</span><br><span style="color: hsl(120, 100%, 40%);">+ if (bts->oml_conn_established_timestamp.tv_sec != 0 && clock_gettime(CLOCK_MONOTONIC, &now) == 0 &&</span><br><span style="color: hsl(120, 100%, 40%);">+ bts->oml_conn_established_timestamp.tv_sec + OSMO_BTS_OML_CONN_EARLY_DISCONNECT >= now.tv_sec) {</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGP(DABIS, LOGL_FATAL, "OML link was closed early within %" PRIu64 " seconds. "</span><br><span style="color: hsl(120, 100%, 40%);">+ "If this situation persists, please check your BTS and BSC configuration files for errors. "</span><br><span style="color: hsl(120, 100%, 40%);">+ "A common error is a mismatch between unit_id configuration parameters of BTS and BSC.\n",</span><br><span style="color: hsl(120, 100%, 40%);">+ (uint64_t) (now.tv_sec - g_bts->oml_conn_established_timestamp.tv_sec));</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ bts->oml_link = NULL;</span><br><span style="color: hsl(120, 100%, 40%);">+ oml_rsl_was_connected = true;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ memset(&g_bts->oml_conn_established_timestamp, 0, sizeof(bts->oml_conn_established_timestamp));</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ if (g_bts->osmo_link) {</span><br><span style="color: hsl(120, 100%, 40%);">+ e1inp_sign_link_destroy(g_bts->osmo_link);</span><br><span style="color: hsl(120, 100%, 40%);">+ g_bts->osmo_link = NULL;</span><br><span style="color: hsl(120, 100%, 40%);">+ oml_rsl_was_connected = true;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Then iterate over the RSL signalling links */</span><br><span style="color: hsl(120, 100%, 40%);">+ llist_for_each_entry(trx, &bts->trx_list, list) {</span><br><span style="color: hsl(120, 100%, 40%);">+ if (trx->rsl_link) {</span><br><span style="color: hsl(120, 100%, 40%);">+ e1inp_sign_link_destroy(trx->rsl_link);</span><br><span style="color: hsl(120, 100%, 40%);">+ trx->rsl_link = NULL;</span><br><span style="color: hsl(120, 100%, 40%);">+ oml_rsl_was_connected = true;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Note: if there was an OML or RSL connection present (the BTS was connected to a BSC). Then we will not try</span><br><span style="color: hsl(120, 100%, 40%);">+ * to connect to an alternate BSC. Instead we will shut down the BTS process. This will ensure that all states</span><br><span style="color: hsl(120, 100%, 40%);">+ * in the BTS (hardware and software) are reset properly. It is then up to the process management of the host</span><br><span style="color: hsl(120, 100%, 40%);">+ * to restart osmo-bts. */</span><br><span style="color: hsl(120, 100%, 40%);">+ if (oml_rsl_was_connected)</span><br><span style="color: hsl(120, 100%, 40%);">+ osmo_fsm_inst_state_chg(fi, ABIS_LINK_ST_FAILED, 0, 0);</span><br><span style="color: hsl(120, 100%, 40%);">+ else</span><br><span style="color: hsl(120, 100%, 40%);">+ osmo_fsm_inst_state_chg(fi, ABIS_LINK_ST_CONNECTING, 0, 0);</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+static void abis_link_connecting_onenter(struct osmo_fsm_inst *fi, uint32_t prev_state)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+ struct e1inp_line *line;</span><br><span style="color: hsl(120, 100%, 40%);">+ struct abis_link_fsm_priv *priv = fi->priv;</span><br><span style="color: hsl(120, 100%, 40%);">+ struct gsm_bts *bts = priv->bts;</span><br><span style="color: hsl(120, 100%, 40%);">+ struct bsc_oml_host *bsc_oml_host;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ if (priv->bsc_oml_host) {</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Get a BSC host from the list and move the list head one position forward. */</span><br><span style="color: hsl(120, 100%, 40%);">+ bsc_oml_host = (struct bsc_oml_host *)priv->bsc_oml_host;</span><br><span style="color: hsl(120, 100%, 40%);">+ if (priv->bsc_oml_host == llist_last(&bts->bsc_oml_hosts))</span><br><span style="color: hsl(120, 100%, 40%);">+ priv->bsc_oml_host = NULL;</span><br><span style="color: hsl(120, 100%, 40%);">+ else</span><br><span style="color: hsl(120, 100%, 40%);">+ priv->bsc_oml_host = priv->bsc_oml_host->next;</span><br><span style="color: hsl(120, 100%, 40%);">+ } else {</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGP(DABIS, LOGL_FATAL, "No BSC available, A-bis connection establishment failed\n");</span><br><span style="color: hsl(120, 100%, 40%);">+ osmo_fsm_inst_state_chg(fi, ABIS_LINK_ST_FAILED, 0, 0);</span><br><span style="color: hsl(120, 100%, 40%);">+ return;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGP(DABIS, LOGL_NOTICE, "A-bis connection establishment to BSC (%s) in progress...\n", bsc_oml_host->addr);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* patch in various data from VTY and other sources */</span><br><span style="color: hsl(120, 100%, 40%);">+ line_ops.cfg.ipa.addr = bsc_oml_host->addr;</span><br><span style="color: hsl(120, 100%, 40%);">+ osmo_get_macaddr(bts_dev_info.mac_addr, "eth0");</span><br><span style="color: hsl(120, 100%, 40%);">+ bts_dev_info.site_id = bts->ip_access.site_id;</span><br><span style="color: hsl(120, 100%, 40%);">+ bts_dev_info.bts_id = bts->ip_access.bts_id;</span><br><span style="color: hsl(120, 100%, 40%);">+ bts_dev_info.unit_name = priv->model_name;</span><br><span style="color: hsl(120, 100%, 40%);">+ if (bts->description)</span><br><span style="color: hsl(120, 100%, 40%);">+ bts_dev_info.unit_name = bts->description;</span><br><span style="color: hsl(120, 100%, 40%);">+ bts_dev_info.location2 = priv->model_name;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ line = e1inp_line_find(priv->line_ctr);</span><br><span style="color: hsl(120, 100%, 40%);">+ if (line) {</span><br><span style="color: hsl(120, 100%, 40%);">+ e1inp_line_get2(line, __FILE__); /* We want a new reference for returned line */</span><br><span style="color: hsl(120, 100%, 40%);">+ } else</span><br><span style="color: hsl(120, 100%, 40%);">+ line = e1inp_line_create(priv->line_ctr, "ipa"); /* already comes with a reference */</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* The abis connection may fail and we may have to try again with a different BSC (if configured). The next</span><br><span style="color: hsl(120, 100%, 40%);">+ * attempt must happen on a different line. */</span><br><span style="color: hsl(120, 100%, 40%);">+ priv->line_ctr++;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ if (!line) {</span><br><span style="color: hsl(120, 100%, 40%);">+ osmo_fsm_inst_state_chg(fi, ABIS_LINK_ST_FAILED, 0, 0);</span><br><span style="color: hsl(120, 100%, 40%);">+ return;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ e1inp_line_bind_ops(line, &line_ops);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* This will open the OML connection now */</span><br><span style="color: hsl(120, 100%, 40%);">+ if (e1inp_line_update(line) < 0) {</span><br><span style="color: hsl(120, 100%, 40%);">+ osmo_fsm_inst_state_chg(fi, ABIS_LINK_ST_FAILED, 0, 0);</span><br><span style="color: hsl(120, 100%, 40%);">+ return;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* The TCP connection to the BSC is now in progress. */</span><br><span style="color: hsl(120, 100%, 40%);">+ osmo_fsm_inst_state_chg(fi, ABIS_LINK_ST_CONNECTED, 0, 0);</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+static void abis_link_failed_onenter(struct osmo_fsm_inst *fi, uint32_t prev_state)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+ struct abis_link_fsm_priv *priv = fi->priv;</span><br><span style="color: hsl(120, 100%, 40%);">+ struct gsm_bts *bts = priv->bts;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* None of the configured BSCs was reachable or there was an existing</span><br><span style="color: hsl(120, 100%, 40%);">+ * OML/RSL connection that beoke. Initiate BTS process shut down now. */</span><br><span style="color: hsl(120, 100%, 40%);">+ bts_model_abis_close(bts);</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+static void abis_link_allstate(struct osmo_fsm_inst *fi, uint32_t event, void *data)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+ struct abis_link_fsm_priv *priv = fi->priv;</span><br><span style="color: hsl(120, 100%, 40%);">+ struct gsm_bts *bts = priv->bts;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ if (event != ABIS_LINK_EV_VTY_RM_ADDR)</span><br><span style="color: hsl(120, 100%, 40%);">+ return;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ if (priv->bsc_oml_host == data) {</span><br><span style="color: hsl(120, 100%, 40%);">+ if (llist_count(&bts->bsc_oml_hosts) <= 1)</span><br><span style="color: hsl(120, 100%, 40%);">+ priv->bsc_oml_host = NULL;</span><br><span style="color: hsl(120, 100%, 40%);">+ else if (priv->bsc_oml_host == llist_last(&bts->bsc_oml_hosts))</span><br><span style="color: hsl(120, 100%, 40%);">+ priv->bsc_oml_host = priv->bsc_oml_host->prev;</span><br><span style="color: hsl(120, 100%, 40%);">+ else</span><br><span style="color: hsl(120, 100%, 40%);">+ priv->bsc_oml_host = priv->bsc_oml_host->next;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+static struct osmo_fsm_state abis_link_fsm_states[] = {</span><br><span style="color: hsl(120, 100%, 40%);">+ [ABIS_LINK_ST_CONNECTED] = {</span><br><span style="color: hsl(120, 100%, 40%);">+ .name = "CONNECTED",</span><br><span style="color: hsl(120, 100%, 40%);">+ .in_event_mask =</span><br><span style="color: hsl(120, 100%, 40%);">+ S(ABIS_LINK_EV_SIGN_LINK_DOWN),</span><br><span style="color: hsl(120, 100%, 40%);">+ .out_state_mask =</span><br><span style="color: hsl(120, 100%, 40%);">+ S(ABIS_LINK_ST_CONNECTING) |</span><br><span style="color: hsl(120, 100%, 40%);">+ S(ABIS_LINK_ST_FAILED),</span><br><span style="color: hsl(120, 100%, 40%);">+ .action = abis_link_connected,</span><br><span style="color: hsl(120, 100%, 40%);">+ },</span><br><span style="color: hsl(120, 100%, 40%);">+ [ABIS_LINK_ST_CONNECTING] = {</span><br><span style="color: hsl(120, 100%, 40%);">+ .name = "CONNECTING",</span><br><span style="color: hsl(120, 100%, 40%);">+ .out_state_mask =</span><br><span style="color: hsl(120, 100%, 40%);">+ S(ABIS_LINK_ST_CONNECTING) |</span><br><span style="color: hsl(120, 100%, 40%);">+ S(ABIS_LINK_ST_CONNECTED) |</span><br><span style="color: hsl(120, 100%, 40%);">+ S(ABIS_LINK_ST_FAILED),</span><br><span style="color: hsl(120, 100%, 40%);">+ .onenter = abis_link_connecting_onenter,</span><br><span style="color: hsl(120, 100%, 40%);">+ },</span><br><span style="color: hsl(120, 100%, 40%);">+ [ABIS_LINK_ST_FAILED] = {</span><br><span style="color: hsl(120, 100%, 40%);">+ .name = "FAILED",</span><br><span style="color: hsl(120, 100%, 40%);">+ .onenter = abis_link_failed_onenter,</span><br><span style="color: hsl(120, 100%, 40%);">+ },</span><br><span style="color: hsl(120, 100%, 40%);">+};</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+static struct osmo_fsm abis_link_fsm = {</span><br><span style="color: hsl(120, 100%, 40%);">+ .name = "abis_link",</span><br><span style="color: hsl(120, 100%, 40%);">+ .states = abis_link_fsm_states,</span><br><span style="color: hsl(120, 100%, 40%);">+ .num_states = ARRAY_SIZE(abis_link_fsm_states),</span><br><span style="color: hsl(120, 100%, 40%);">+ .log_subsys = DABIS,</span><br><span style="color: hsl(120, 100%, 40%);">+ .event_names = abis_link_fsm_event_names,</span><br><span style="color: hsl(120, 100%, 40%);">+ .allstate_action = abis_link_allstate,</span><br><span style="color: hsl(120, 100%, 40%);">+ .allstate_event_mask = S(ABIS_LINK_EV_VTY_RM_ADDR),</span><br><span style="color: hsl(120, 100%, 40%);">+};</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> int abis_oml_sendmsg(struct msgb *msg)</span><br><span> {</span><br><span> struct gsm_bts *bts = msg->trx->bts;</span><br><span>@@ -144,41 +344,8 @@</span><br><span> </span><br><span> static void sign_link_down(struct e1inp_line *line)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">- struct gsm_bts_trx *trx;</span><br><span> LOGPIL(line, DABIS, LOGL_ERROR, "Signalling link down\n");</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- /* First remove the OML signalling link */</span><br><span style="color: hsl(0, 100%, 40%);">- if (g_bts->oml_link) {</span><br><span style="color: hsl(0, 100%, 40%);">- struct timespec now;</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- e1inp_sign_link_destroy(g_bts->oml_link);</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- /* Log a special notice if the OML connection was dropped relatively quickly. */</span><br><span style="color: hsl(0, 100%, 40%);">- if (g_bts->oml_conn_established_timestamp.tv_sec != 0 && clock_gettime(CLOCK_MONOTONIC, &now) == 0 &&</span><br><span style="color: hsl(0, 100%, 40%);">- g_bts->oml_conn_established_timestamp.tv_sec + OSMO_BTS_OML_CONN_EARLY_DISCONNECT >= now.tv_sec) {</span><br><span style="color: hsl(0, 100%, 40%);">- LOGP(DABIS, LOGL_FATAL, "OML link was closed early within %" PRIu64 " seconds. "</span><br><span style="color: hsl(0, 100%, 40%);">- "If this situation persists, please check your BTS and BSC configuration files for errors. "</span><br><span style="color: hsl(0, 100%, 40%);">- "A common error is a mismatch between unit_id configuration parameters of BTS and BSC.\n",</span><br><span style="color: hsl(0, 100%, 40%);">- (uint64_t)(now.tv_sec - g_bts->oml_conn_established_timestamp.tv_sec));</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">- g_bts->oml_link = NULL;</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">- memset(&g_bts->oml_conn_established_timestamp, 0, sizeof(g_bts->oml_conn_established_timestamp));</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- if (g_bts->osmo_link) {</span><br><span style="color: hsl(0, 100%, 40%);">- e1inp_sign_link_destroy(g_bts->osmo_link);</span><br><span style="color: hsl(0, 100%, 40%);">- g_bts->osmo_link = NULL;</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- /* Then iterate over the RSL signalling links */</span><br><span style="color: hsl(0, 100%, 40%);">- llist_for_each_entry(trx, &g_bts->trx_list, list) {</span><br><span style="color: hsl(0, 100%, 40%);">- if (trx->rsl_link) {</span><br><span style="color: hsl(0, 100%, 40%);">- e1inp_sign_link_destroy(trx->rsl_link);</span><br><span style="color: hsl(0, 100%, 40%);">- trx->rsl_link = NULL;</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- bts_model_abis_close(g_bts);</span><br><span style="color: hsl(120, 100%, 40%);">+ osmo_fsm_inst_dispatch(g_bts->abis_link_fi, ABIS_LINK_EV_SIGN_LINK_DOWN, NULL);</span><br><span> }</span><br><span> </span><br><span> </span><br><span>@@ -277,33 +444,27 @@</span><br><span> osmo_signal_register_handler(SS_L_INPUT, &inp_s_cbfn, bts);</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-struct e1inp_line *abis_open(struct gsm_bts *bts, char *dst_host,</span><br><span style="color: hsl(0, 100%, 40%);">- char *model_name)</span><br><span style="color: hsl(120, 100%, 40%);">+int abis_open(struct gsm_bts *bts, char *model_name)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">- struct e1inp_line *line;</span><br><span style="color: hsl(120, 100%, 40%);">+ struct abis_link_fsm_priv *abis_link_fsm_priv;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- /* patch in various data from VTY and other sources */</span><br><span style="color: hsl(0, 100%, 40%);">- line_ops.cfg.ipa.addr = dst_host;</span><br><span style="color: hsl(0, 100%, 40%);">- osmo_get_macaddr(bts_dev_info.mac_addr, "eth0");</span><br><span style="color: hsl(0, 100%, 40%);">- bts_dev_info.site_id = bts->ip_access.site_id;</span><br><span style="color: hsl(0, 100%, 40%);">- bts_dev_info.bts_id = bts->ip_access.bts_id;</span><br><span style="color: hsl(0, 100%, 40%);">- bts_dev_info.unit_name = model_name;</span><br><span style="color: hsl(0, 100%, 40%);">- if (bts->description)</span><br><span style="color: hsl(0, 100%, 40%);">- bts_dev_info.unit_name = bts->description;</span><br><span style="color: hsl(0, 100%, 40%);">- bts_dev_info.location2 = model_name;</span><br><span style="color: hsl(120, 100%, 40%);">+ if (llist_empty(&bts->bsc_oml_hosts)) {</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGP(DABIS, LOGL_FATAL, "No BSC configured, cannot start BTS without knowing BSC OML IP\n");</span><br><span style="color: hsl(120, 100%, 40%);">+ return -EINVAL;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- line = e1inp_line_find(0);</span><br><span style="color: hsl(0, 100%, 40%);">- if (line) {</span><br><span style="color: hsl(0, 100%, 40%);">- e1inp_line_get2(line, __FILE__); /* We want a new reference for returned line */</span><br><span style="color: hsl(0, 100%, 40%);">- } else</span><br><span style="color: hsl(0, 100%, 40%);">- line = e1inp_line_create(0, "ipa"); /* already comes with a reference */</span><br><span style="color: hsl(0, 100%, 40%);">- if (!line)</span><br><span style="color: hsl(0, 100%, 40%);">- return NULL;</span><br><span style="color: hsl(0, 100%, 40%);">- e1inp_line_bind_ops(line, &line_ops);</span><br><span style="color: hsl(120, 100%, 40%);">+ OSMO_ASSERT(osmo_fsm_register(&abis_link_fsm) == 0);</span><br><span style="color: hsl(120, 100%, 40%);">+ bts->abis_link_fi = osmo_fsm_inst_alloc(&abis_link_fsm, bts, NULL, LOGL_DEBUG, "abis_link");</span><br><span style="color: hsl(120, 100%, 40%);">+ OSMO_ASSERT(bts->abis_link_fi);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- /* This will open the OML connection now */</span><br><span style="color: hsl(0, 100%, 40%);">- if (e1inp_line_update(line) < 0)</span><br><span style="color: hsl(0, 100%, 40%);">- return NULL;</span><br><span style="color: hsl(120, 100%, 40%);">+ abis_link_fsm_priv = talloc_zero(bts->abis_link_fi, struct abis_link_fsm_priv);</span><br><span style="color: hsl(120, 100%, 40%);">+ OSMO_ASSERT(abis_link_fsm_priv);</span><br><span style="color: hsl(120, 100%, 40%);">+ abis_link_fsm_priv->bsc_oml_host = bts->bsc_oml_hosts.next;</span><br><span style="color: hsl(120, 100%, 40%);">+ abis_link_fsm_priv->bts = bts;</span><br><span style="color: hsl(120, 100%, 40%);">+ abis_link_fsm_priv->model_name = model_name;</span><br><span style="color: hsl(120, 100%, 40%);">+ bts->abis_link_fi->priv = abis_link_fsm_priv;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- return line;</span><br><span style="color: hsl(120, 100%, 40%);">+ osmo_fsm_inst_state_chg_ms(bts->abis_link_fi, ABIS_LINK_ST_CONNECTING, 1, 0);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ return 0;</span><br><span> }</span><br><span>diff --git a/src/common/bts.c b/src/common/bts.c</span><br><span>index 27c7f74..48adf42 100644</span><br><span>--- a/src/common/bts.c</span><br><span>+++ b/src/common/bts.c</span><br><span>@@ -402,6 +402,7 @@</span><br><span> bts->smscb_queue_hyst = 2;</span><br><span> </span><br><span> INIT_LLIST_HEAD(&bts->oml_queue);</span><br><span style="color: hsl(120, 100%, 40%);">+ INIT_LLIST_HEAD(&bts->bsc_oml_hosts);</span><br><span> </span><br><span> /* register DTX DL FSM */</span><br><span> rc = osmo_fsm_register(&dtx_dl_amr_fsm);</span><br><span>diff --git a/src/common/main.c b/src/common/main.c</span><br><span>index 0b7d3fb..bc5cf3b 100644</span><br><span>--- a/src/common/main.c</span><br><span>+++ b/src/common/main.c</span><br><span>@@ -272,7 +272,6 @@</span><br><span> int bts_main(int argc, char **argv)</span><br><span> {</span><br><span> struct gsm_bts_trx *trx;</span><br><span style="color: hsl(0, 100%, 40%);">- struct e1inp_line *line;</span><br><span> int rc;</span><br><span> </span><br><span> /* Track the use of talloc NULL memory contexts */</span><br><span>@@ -397,16 +396,8 @@</span><br><span> signal(SIGUSR2, &signal_handler);</span><br><span> osmo_init_ignore_signals();</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- if (!g_bts->bsc_oml_host) {</span><br><span style="color: hsl(0, 100%, 40%);">- fprintf(stderr, "Cannot start BTS without knowing BSC OML IP\n");</span><br><span style="color: hsl(120, 100%, 40%);">+ if (abis_open(g_bts, "osmo-bts") != 0)</span><br><span> exit(1);</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- line = abis_open(g_bts, g_bts->bsc_oml_host, "osmo-bts");</span><br><span style="color: hsl(0, 100%, 40%);">- if (!line) {</span><br><span style="color: hsl(0, 100%, 40%);">- fprintf(stderr, "unable to connect to BSC\n");</span><br><span style="color: hsl(0, 100%, 40%);">- exit(2);</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span> </span><br><span> rc = phy_links_open();</span><br><span> if (rc < 0) {</span><br><span>diff --git a/src/common/vty.c b/src/common/vty.c</span><br><span>index a7d1e84..fe506a5 100644</span><br><span>--- a/src/common/vty.c</span><br><span>+++ b/src/common/vty.c</span><br><span>@@ -41,7 +41,7 @@</span><br><span> #include <osmocom/core/utils.h></span><br><span> #include <osmocom/core/sockaddr_str.h></span><br><span> #include <osmocom/trau/osmo_ortp.h></span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(120, 100%, 40%);">+#include <osmocom/core/fsm.h></span><br><span> </span><br><span> #include <osmo-bts/logging.h></span><br><span> #include <osmo-bts/gsm_data.h></span><br><span>@@ -282,6 +282,7 @@</span><br><span> const struct gsm_bts_trx *trx;</span><br><span> const char *sapi_buf;</span><br><span> int i;</span><br><span style="color: hsl(120, 100%, 40%);">+ struct bsc_oml_host *bsc_oml_host;</span><br><span> </span><br><span> vty_out(vty, "bts %u%s", bts->nr, VTY_NEWLINE);</span><br><span> if (bts->description)</span><br><span>@@ -291,7 +292,8 @@</span><br><span> vty_out(vty, " auto-band%s", VTY_NEWLINE);</span><br><span> vty_out(vty, " ipa unit-id %u %u%s",</span><br><span> bts->ip_access.site_id, bts->ip_access.bts_id, VTY_NEWLINE);</span><br><span style="color: hsl(0, 100%, 40%);">- vty_out(vty, " oml remote-ip %s%s", bts->bsc_oml_host, VTY_NEWLINE);</span><br><span style="color: hsl(120, 100%, 40%);">+ llist_for_each_entry(bsc_oml_host, &bts->bsc_oml_hosts, list)</span><br><span style="color: hsl(120, 100%, 40%);">+ vty_out(vty, " oml remote-ip %s%s", bsc_oml_host->addr, VTY_NEWLINE);</span><br><span> vty_out(vty, " rtp jitter-buffer %u", bts->rtp_jitter_buf_ms);</span><br><span> if (bts->rtp_jitter_adaptive)</span><br><span> vty_out(vty, " adaptive");</span><br><span>@@ -507,11 +509,51 @@</span><br><span> "OML Parameters\n" "OML IP Address\n" "OML IP Address\n")</span><br><span> {</span><br><span> struct gsm_bts *bts = vty->index;</span><br><span style="color: hsl(120, 100%, 40%);">+ struct bsc_oml_host *bsc_oml_host;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- if (bts->bsc_oml_host)</span><br><span style="color: hsl(0, 100%, 40%);">- talloc_free(bts->bsc_oml_host);</span><br><span style="color: hsl(120, 100%, 40%);">+ /* stop when the address is already in the list */</span><br><span style="color: hsl(120, 100%, 40%);">+ llist_for_each_entry(bsc_oml_host, &bts->bsc_oml_hosts, list) {</span><br><span style="color: hsl(120, 100%, 40%);">+ if (strcmp(argv[0], bsc_oml_host->addr) == 0) {</span><br><span style="color: hsl(120, 100%, 40%);">+ vty_out(vty, "%% duplicate BSC (A-Bis/OML) ip address configured ('%s')%s",</span><br><span style="color: hsl(120, 100%, 40%);">+ argv[0], VTY_NEWLINE);</span><br><span style="color: hsl(120, 100%, 40%);">+ return CMD_WARNING;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- bts->bsc_oml_host = talloc_strdup(bts, argv[0]);</span><br><span style="color: hsl(120, 100%, 40%);">+ bsc_oml_host = talloc_zero(bts, struct bsc_oml_host);</span><br><span style="color: hsl(120, 100%, 40%);">+ OSMO_ASSERT(bsc_oml_host);</span><br><span style="color: hsl(120, 100%, 40%);">+ bsc_oml_host->addr = talloc_strdup(bsc_oml_host, argv[0]);</span><br><span style="color: hsl(120, 100%, 40%);">+ OSMO_ASSERT(bsc_oml_host->addr);</span><br><span style="color: hsl(120, 100%, 40%);">+ llist_add_tail(&bsc_oml_host->list, &bts->bsc_oml_hosts);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ return CMD_SUCCESS;</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+DEFUN(cfg_bts_no_oml_ip,</span><br><span style="color: hsl(120, 100%, 40%);">+ cfg_bts_no_oml_ip_cmd,</span><br><span style="color: hsl(120, 100%, 40%);">+ "no oml remote-ip A.B.C.D",</span><br><span style="color: hsl(120, 100%, 40%);">+ NO_STR "OML Parameters\n" "OML IP Address\n" "OML IP Address\n")</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+ struct gsm_bts *bts = vty->index;</span><br><span style="color: hsl(120, 100%, 40%);">+ struct bsc_oml_host *bsc_oml_host;</span><br><span style="color: hsl(120, 100%, 40%);">+ struct bsc_oml_host *bsc_oml_host_del = NULL;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ llist_for_each_entry(bsc_oml_host, &bts->bsc_oml_hosts, list) {</span><br><span style="color: hsl(120, 100%, 40%);">+ if (strcmp(argv[0], bsc_oml_host->addr) == 0)</span><br><span style="color: hsl(120, 100%, 40%);">+ bsc_oml_host_del = bsc_oml_host;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ if (bsc_oml_host_del) {</span><br><span style="color: hsl(120, 100%, 40%);">+ if (bts->abis_link_fi) {</span><br><span style="color: hsl(120, 100%, 40%);">+ osmo_fsm_inst_dispatch(bts->abis_link_fi, ABIS_LINK_EV_VTY_RM_ADDR, bsc_oml_host_del);</span><br><span style="color: hsl(120, 100%, 40%);">+ llist_del(&bsc_oml_host_del->list);</span><br><span style="color: hsl(120, 100%, 40%);">+ talloc_free(bsc_oml_host_del);</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ } else {</span><br><span style="color: hsl(120, 100%, 40%);">+ vty_out(vty, "%% no such BSC (A-Bis/OML) ip address configured ('%s')%s",</span><br><span style="color: hsl(120, 100%, 40%);">+ argv[0], VTY_NEWLINE);</span><br><span style="color: hsl(120, 100%, 40%);">+ return CMD_WARNING;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span> </span><br><span> return CMD_SUCCESS;</span><br><span> }</span><br><span>@@ -2378,6 +2420,7 @@</span><br><span> install_element(CONFIG_NODE, &cfg_vty_telnet_port_cmd);</span><br><span> install_element(BTS_NODE, &cfg_bts_unit_id_cmd);</span><br><span> install_element(BTS_NODE, &cfg_bts_oml_ip_cmd);</span><br><span style="color: hsl(120, 100%, 40%);">+ install_element(BTS_NODE, &cfg_bts_no_oml_ip_cmd);</span><br><span> install_element(BTS_NODE, &cfg_bts_rtp_bind_ip_cmd);</span><br><span> install_element(BTS_NODE, &cfg_bts_rtp_jitbuf_cmd);</span><br><span> install_element(BTS_NODE, &cfg_bts_rtp_port_range_cmd);</span><br><span>diff --git a/src/osmo-bts-omldummy/main.c b/src/osmo-bts-omldummy/main.c</span><br><span>index a36e0db..c74af74 100644</span><br><span>--- a/src/osmo-bts-omldummy/main.c</span><br><span>+++ b/src/osmo-bts-omldummy/main.c</span><br><span>@@ -107,7 +107,7 @@</span><br><span> {</span><br><span> struct gsm_bts *bts;</span><br><span> struct gsm_bts_trx *trx;</span><br><span style="color: hsl(0, 100%, 40%);">- struct e1inp_line *line;</span><br><span style="color: hsl(120, 100%, 40%);">+ struct bsc_oml_host *bsc_oml_host;</span><br><span> int i;</span><br><span> </span><br><span> parse_cmdline(argc, argv);</span><br><span>@@ -144,9 +144,13 @@</span><br><span> //btsb = bts_role_bts(bts);</span><br><span> abis_init(bts);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- line = abis_open(bts, cmdline.dst_host, "OMLdummy");</span><br><span style="color: hsl(0, 100%, 40%);">- if (!line)</span><br><span style="color: hsl(0, 100%, 40%);">- exit(2);</span><br><span style="color: hsl(120, 100%, 40%);">+ bsc_oml_host = talloc_zero(bts, struct bsc_oml_host);</span><br><span style="color: hsl(120, 100%, 40%);">+ OSMO_ASSERT(bsc_oml_host);</span><br><span style="color: hsl(120, 100%, 40%);">+ bsc_oml_host->addr = talloc_strdup(bsc_oml_host, cmdline.dst_host);</span><br><span style="color: hsl(120, 100%, 40%);">+ OSMO_ASSERT(bsc_oml_host->addr);</span><br><span style="color: hsl(120, 100%, 40%);">+ llist_add_tail(&bsc_oml_host->list, &bts->bsc_oml_hosts);</span><br><span style="color: hsl(120, 100%, 40%);">+ if (abis_open(bts, "OMLdummy") != 0)</span><br><span style="color: hsl(120, 100%, 40%);">+ exit(1);</span><br><span> </span><br><span> while (1) {</span><br><span> osmo_select_main(0);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bts/+/24513">change 24513</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bts/+/24513"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I205f68a3a7f35fee4c38a7cfba2b014237df2727 </div>
<div style="display:none"> Gerrit-Change-Number: 24513 </div>
<div style="display:none"> Gerrit-PatchSet: 11 </div>
<div style="display:none"> Gerrit-Owner: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: daniel <dwillmann@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>