<p>neels <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/libosmo-sccp/+/24909">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  fixeria: Looks good to me, but someone else must approve
  pespin: Looks good to me, but someone else must approve
  neels: Looks good to me, approved
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">m3ua: fix leaky usage of m3ua_tx_xua_asp<br><br>m3ua_tx_xua_asp will at some point convert the xua msg to a msgb by<br>copying and then send it, the xua msg still needs to be freed by the<br>caller.<br><br>Closes: OS#5185<br>Change-Id: Id8584b99f30f2db602d4d129e4114821697272ab<br>---<br>M src/m3ua.c<br>1 file changed, 5 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/m3ua.c b/src/m3ua.c</span><br><span>index e2db6c1..4583683 100644</span><br><span>--- a/src/m3ua.c</span><br><span>+++ b/src/m3ua.c</span><br><span>@@ -752,8 +752,10 @@</span><br><span>              err = m3ua_gen_error_msg(rc, msg);</span><br><span> </span><br><span> out:</span><br><span style="color: hsl(0, 100%, 40%);">-  if (err)</span><br><span style="color: hsl(120, 100%, 40%);">+      if (err) {</span><br><span>           m3ua_tx_xua_asp(asp, err);</span><br><span style="color: hsl(120, 100%, 40%);">+            xua_msg_free(err);</span><br><span style="color: hsl(120, 100%, 40%);">+    }</span><br><span> </span><br><span>        xua_msg_free(xua);</span><br><span> </span><br><span>@@ -856,6 +858,7 @@</span><br><span>                 xua = m3ua_encode_duna(rctx, num_rctx, aff_pc, num_aff_pc, info_string);</span><br><span> </span><br><span>         m3ua_tx_xua_asp(asp, xua);</span><br><span style="color: hsl(120, 100%, 40%);">+    xua_msg_free(xua);</span><br><span> }</span><br><span> </span><br><span> /*! Transmit SSNM DUPU message indicating user unavailability.</span><br><span>@@ -871,6 +874,7 @@</span><br><span> {</span><br><span>     struct xua_msg *xua = m3ua_encode_dupu(rctx, num_rctx, dpc, user, cause, info_str);</span><br><span>  m3ua_tx_xua_asp(asp, xua);</span><br><span style="color: hsl(120, 100%, 40%);">+    xua_msg_free(xua);</span><br><span> }</span><br><span> </span><br><span> /* received SNM message on ASP side */</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmo-sccp/+/24909">change 24909</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmo-sccp/+/24909"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmo-sccp </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Id8584b99f30f2db602d4d129e4114821697272ab </div>
<div style="display:none"> Gerrit-Change-Number: 24909 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Hoernchen <ewild@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>