<p>osmith has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24917">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">bsc: fix encryption a5/4 missing in TC_*_a5_4<br><br>After removing a5/4 from the default config, it also needs to be<br>explicitly enabled for these two tests.<br><br>Fixes: 26a3db ("bsc: change encryption a5 via VTY where needed")<br>Change-Id: Ibe00edb096f94b500869c46a39a694a73133c716<br>---<br>M bsc/BSC_Tests.ttcn<br>1 file changed, 6 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/17/24917/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn</span><br><span>index 2a89659..97ec4c6 100644</span><br><span>--- a/bsc/BSC_Tests.ttcn</span><br><span>+++ b/bsc/BSC_Tests.ttcn</span><br><span>@@ -3479,9 +3479,11 @@</span><br><span>   pars.encr := valueof(t_EncrParams('10'O, f_rnd_octstring(8), f_rnd_octstring(16)));</span><br><span> </span><br><span>      f_init(1, true);</span><br><span style="color: hsl(120, 100%, 40%);">+      f_vty_encryption_a5("0 1 3 4");</span><br><span>    f_sleep(1.0);</span><br><span>        vc_conn := f_start_handler(refers(f_tc_assignment_fr_a5), pars);</span><br><span>     vc_conn.done;</span><br><span style="color: hsl(120, 100%, 40%);">+ f_vty_encryption_a5_reset();</span><br><span>         f_shutdown_helper();</span><br><span> }</span><br><span> </span><br><span>@@ -4816,12 +4818,13 @@</span><br><span>      f_shutdown_helper();</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-function f_tc_ho_int_a5(OCT1 encr_alg) runs on test_CT {</span><br><span style="color: hsl(120, 100%, 40%);">+function f_tc_ho_int_a5(OCT1 encr_alg, charstring enc_a5 := "0 1 3") runs on test_CT {</span><br><span>      var MSC_ConnHdlr vc_conn;</span><br><span>    var TestHdlrParams pars := f_gen_test_hdlr_pars();</span><br><span>   pars.encr := valueof(t_EncrParams(encr_alg, f_rnd_octstring(8), f_rnd_octstring(16)));</span><br><span> </span><br><span>   f_init(2, true);</span><br><span style="color: hsl(120, 100%, 40%);">+      f_vty_encryption_a5(enc_a5);</span><br><span>         f_sleep(1.0);</span><br><span> </span><br><span>    f_ctrs_bsc_and_bts_init();</span><br><span>@@ -4838,6 +4841,7 @@</span><br><span>   f_ctrs_bsc_and_bts_add(0, "intra_bsc_ho:attempted");</span><br><span>       f_ctrs_bsc_and_bts_add(0, "intra_bsc_ho:completed");</span><br><span>       f_ctrs_bsc_and_bts_verify();</span><br><span style="color: hsl(120, 100%, 40%);">+  f_vty_encryption_a5_reset();</span><br><span>         f_shutdown_helper();</span><br><span> }</span><br><span> </span><br><span>@@ -4854,7 +4858,7 @@</span><br><span> }</span><br><span> </span><br><span> testcase TC_ho_int_a5_4() runs on test_CT {</span><br><span style="color: hsl(0, 100%, 40%);">-   f_tc_ho_int_a5('10'O);</span><br><span style="color: hsl(120, 100%, 40%);">+        f_tc_ho_int_a5('10'O, "0 1 3 4");</span><br><span> }</span><br><span> </span><br><span> /* intra-BSC hand-over with CONNection FAILure and cause Radio Link Failure: check RR release cause */</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24917">change 24917</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24917"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ibe00edb096f94b500869c46a39a694a73133c716 </div>
<div style="display:none"> Gerrit-Change-Number: 24917 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: osmith <osmith@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>