<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ci/+/24865">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  pespin: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved; Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">lint: checkpatch.pl: exclude pattern, not dir<br><br>Allow to exclude files in a follow-up commit, not just directories.<br><br>Related: OS#5087<br>Change-Id: Ic3990fba60060c331c479174183924b9cdbdb4c8<br>---<br>M lint/checkpatch/checkpatch.pl<br>M lint/checkpatch/checkpatch_osmo.sh<br>2 files changed, 4 insertions(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/lint/checkpatch/checkpatch.pl b/lint/checkpatch/checkpatch.pl</span><br><span>index 2cd5402..dc56812 100755</span><br><span>--- a/lint/checkpatch/checkpatch.pl</span><br><span>+++ b/lint/checkpatch/checkpatch.pl</span><br><span>@@ -105,7 +105,7 @@</span><br><span>   --list-types               list the possible message types</span><br><span>   --types TYPE(,TYPE2...)    show only these comma separated message types</span><br><span>   --ignore TYPE(,TYPE2...)   ignore various comma separated message types</span><br><span style="color: hsl(0, 100%, 40%);">-  --exclude DIR(,DIR22...)   exclude directories</span><br><span style="color: hsl(120, 100%, 40%);">+  --exclude PATTERN(,P2...)  exclude pattern</span><br><span>   --show-types               show the specific message type in the output</span><br><span>   --max-line-length=n        set the maximum line length, (default $max_line_length)</span><br><span>                              if exceeded, warn on patches</span><br><span>@@ -2811,7 +2811,7 @@</span><br><span> </span><br><span>          my $skipme = 0;</span><br><span>              foreach (@exclude) {</span><br><span style="color: hsl(0, 100%, 40%);">-                    if ($realfile =~ m@^(?:$_/)@) {</span><br><span style="color: hsl(120, 100%, 40%);">+                       if ($realfile =~ m@$_@) {</span><br><span>                            $skipme = 1;</span><br><span>                         }</span><br><span>            }</span><br><span>diff --git a/lint/checkpatch/checkpatch_osmo.sh b/lint/checkpatch/checkpatch_osmo.sh</span><br><span>index 0a5c65f..bdbd125 100755</span><br><span>--- a/lint/checkpatch/checkpatch_osmo.sh</span><br><span>+++ b/lint/checkpatch/checkpatch_osmo.sh</span><br><span>@@ -2,7 +2,7 @@</span><br><span> SCRIPT_DIR="$(dirname "$(realpath "$0")")"</span><br><span> </span><br><span> # Excluded paths:</span><br><span style="color: hsl(0, 100%, 40%);">-# * lint/checkpath: so it does not warn about spelling errors in spelling.txt :)</span><br><span style="color: hsl(120, 100%, 40%);">+# * ^lint/checkpatch/: so it does not warn about spelling errors in spelling.txt :)</span><br><span> </span><br><span> # Ignored checks:</span><br><span> # * ASSIGN_IN_IF: not followed (e.g. 'if ((u8 = gsup_msg->cause))')</span><br><span>@@ -23,7 +23,7 @@</span><br><span> # * STRING_FRAGMENTS: sometimes used intentionally to improve readability</span><br><span> </span><br><span> $SCRIPT_DIR/checkpatch.pl \</span><br><span style="color: hsl(0, 100%, 40%);">-       --exclude lint/checkpatch \</span><br><span style="color: hsl(120, 100%, 40%);">+   --exclude '^lint/checkpatch/' \</span><br><span>      --ignore ASSIGN_IN_IF \</span><br><span>      --ignore AVOID_EXTERNS \</span><br><span>     --ignore BLOCK_COMMENT_STYLE \</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ci/+/24865">change 24865</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ci/+/24865"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ci </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ic3990fba60060c331c479174183924b9cdbdb4c8 </div>
<div style="display:none"> Gerrit-Change-Number: 24865 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: osmith <osmith@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>